On Mon, 29 Jun 2020 16:41:53 GMT, Frederic Thevenet
wrote:
>> I have changed the test setup to fill up the scene with a gradient instead
>> of random noise; it should be as able to
>> catch misalignment, while not looking like something's gone horribly wrong.
>
> Also, while running the tests a
On Mon, 29 Jun 2020 16:16:58 GMT, Frederic Thevenet
wrote:
>> Thanks for your review.
>>
>> I don't have access to a Mac so I can't check that directly.
>> The tests pass on both my Windows 10 and Ubuntu 20.04 environments and the
>> stack isn't very helpful (it simply
>> indicates the renderI
On Mon, 29 Jun 2020 14:35:00 GMT, Frederic Thevenet
wrote:
>> I observed that the added tests are failing on mac machine(Mojave 10.14.6),
>> but they do pass on windows10. Can you
>> please verify ? Timeout and Unrecognized Image loader errors from the log,
>> test.javafx.scene.Snapshot2Test >
On Mon, 29 Jun 2020 14:02:11 GMT, Ambarish Rapte wrote:
>> I went ahead and wrote a bunch of tests that:
>> 1. Setup a scene to display an `ImageView` of a selected dimensions chosen
>> to trigger tiling in different ways when
>> taking snapshots. 2. Fill up the image with noise.
>> 3. Take a sn
On Wed, 17 Jun 2020 11:33:27 GMT, Frederic Thevenet
wrote:
>>> [...] I'd like to see some additional system tests that cover all of the
>>> cases of X and Y fitting/not-fitting exactly
>>> (and if you stick with your current approach, X or Y as the inner loop).
>>
>> What kind of tests do you
