Re: Review request for #151 Open VirtualFlow and other relating classes API for sublclassing

2018-10-15 Thread Kevin Rushforth
Samir, Also, can you provide JBS bug ID? The one you listed in your review request is the wrong Bug ID. Thanks. -- Kevin On 10/15/2018 6:00 AM, Kevin Rushforth wrote: Note that since this is request for a new feature there are a couple other steps needed: 1. The proposed feature, along w

Re: Review request for #151 Open VirtualFlow and other relating classes API for sublclassing

2018-10-15 Thread Kevin Rushforth
Note that since this is request for a new feature there are a couple other steps needed: 1. The proposed feature, along with the new API should be discussed and general agreement reached. This is already in progress and is happening in the PR itself. Mainly what needs to be ironed out now is t

Review request for #151 Open VirtualFlow and other relating classes API for sublclassing

2018-10-15 Thread Sam'
Please review the GitHub pull request: https://github.com/javafxports/openjdk-jfx/pull/163 which fixes: Open VirtualFlow API for subclassing https://github.com/javafxports/openjdk-jfx/issues/151