[9] Review request: 8167132: Menu keyboard navigation retains previous focus index

Vadim, Please review the following webrev: https://bugs.openjdk.java.net/browse/JDK-8167132 http://cr.openjdk.java.net/~jgiles/8167132/ Thanks! -- -- Jonathan

[9] Code Review Request For 8166934: Cleanup obsolete impl_ references in JavaFX modules

Hi Kevin, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8166934 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8166934/webrev.00/ Thanks, - Chien

[9] Code Review Request For 8166933: Clean up private TextAttributes class

Kevin, Please review the proposed fix. In this fix I also took the chance to fix the wildcard import issue in this file: https://bugs.openjdk.java.net/browse/JDK-8166933 http://cr.openjdk.java.net/~ckyang/JDK-8166933/webrev.00/ Thanks, - Chien

[9] Review request: 8167055: TableViews with many columns lose alignment between headers and cells

Vadim, Please review the webrev for the following issue: https://bugs.openjdk.java.net/browse/JDK-8167055 http://cr.openjdk.java.net/~jgiles/8167055/ Thanks! -- -- Jonathan

[webkit] [9] Review request for 8088205: [Mac] WebView renders icons instead of letters on some sites

Hello Kevin, Phil, Guru Please review the following fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8088205 Webrev: http://cr.openjdk.java.net/~arajkumar/8088205/webrev.00 Analysis: Some Web Fonts(like Thin.ttf, refer the attachment) doesn’t have valid entry in the TTF Naming Table. Due

[9] Review request: 8166950,Memory Leak: MenuBar added to Tab is still referenced on tab close and is not garbage collected

Kevin, Chien, Please can you review the webrev for the following issue: https://bugs.openjdk.java.net/browse/JDK-8166950 http://cr.openjdk.java.net/~jgiles/8166950 Thanks -- -- Jonathan

[9] Review request for 8166677: HTMLEditor freezes after restoring previously maximized window

  Hi Kevin, Arun, Guru, Please review the following fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8166677 Webrev: http://cr.openjdk.java.net/~mbilla/8166677/webrev.00/   Thanks, Murali

Re: [9] Review request: 8166565 [hidpi] a flickering scrollbar when using Caspian style sheet

() or snapFooY() and made a best guess and added a comment. Please advise. Also, advise if someone else should be CC'd on the review thread...? ...jim

[9] Review request: 8166025: TableColumnHeader: loses custom style classes

Kevin and / or Vadim, Please review the fix for the following issue: https://bugs.openjdk.java.net/browse/JDK-8166025 http://cr.openjdk.java.net/~jgiles/8166025.3/ Thanks! -- Jonathan

[9] Review Request: 8166544 ANT issues in Mac developer build

Kevin, Java Packager ANT scripts need to work with non modular jars. This fixes that. Webrev: https://bugs.openjdk.java.net/browse/JDK-8166544 JIRA: http://cr.openjdk.java.net/~cbensen/JDK-8166544/ Chris

[9] Review request: 8166021: NestedTableColumnHeader: package private access to skin prevents custom headers

Kevin and / or Vadim, Please review the fix for the following issue: https://bugs.openjdk.java.net/browse/JDK-8166021 http://cr.openjdk.java.net/~jgiles/8166021/ Thanks! -- -- Jonathan

[9] Review request: 8166013: NestedTableColumnHeader: must use factory method for header creation always

Kevin and / or Vadim, Please review the fix for the following issue: https://bugs.openjdk.java.net/browse/JDK-8166013 http://cr.openjdk.java.net/~jgiles/8166013.1/ Thanks! -- -- Jonathan

[9,8u] Review request: 8150982: Crash when calling WebEngine.print on background thread

Phil, Please review the fix for the following related bugs: https://bugs.openjdk.java.net/browse/JDK-8150982 https://bugs.openjdk.java.net/browse/JDK-8165098 http://cr.openjdk.java.net/~kcr/8150982/webrev.00/ -- Kevin

[9] Review request for 8163486: NumberAxis: inaccurate rendering of ticks when tick unit is low

Hi Jonathan, Kevin, Could you please review the fix: https://bugs.openjdk.java.net/browse/JDK-8163486 http://cr.openjdk.java.net/~vadim/8163486/webrev.00/ Thanks, Vadim

[9] Review request: 8166565 [hidpi] a flickering scrollbar when using Caspian style sheet

comment, there are a couple of places where I could not decide if the call should be for snapFooX() or snapFooY() and made a best guess and added a comment. Please advise. Also, advise if someone else should be CC'd on the review thread...? ...jim

Re: [9] Review Request: 8165383 [packager] -native image generates all bundlers

Kevin, have you had time to review this? Chris > On Sep 22, 2016, at 8:25 AM, Chris Bensen wrote: > > Kevin, > > The -native CLI argument is 100% working. "-native image” for example > generates all bundles rather than just the image. This obviously fixes

Review request for 8166776: Add HelloWebView with navigation and stop button

Hi Kevin, Arun & Guru, Please review the fix for JBS : https://bugs.openjdk.java.net/browse/JDK-8166776 Webrev : http://cr.openjdk.java.net/~ghb/vpaliwal/8166776/webrev.00/ <http://cr.openjdk.java.net/%7Eghb/vpaliwal/8166776/webrev.00/> Fix description is updated in JBS. Thanks, Viplove

[webkit] [9] Review request for 8166759: jfxwebkit.dll is missing file detail for 8u112 and 9

Hello Kevin, Guru, Murali, Please review the following fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8166759 Webrev: http://cr.openjdk.java.net/~arajkumar/8166759/webrev.00 Analysis: Newly merged WexbKit doesn't include version.res file generated by build.gradle, version.res

Review: separate building of ant-javafx.jar from fxpackager proper

Chris, Kevin, https://bugs.openjdk.java.net/browse/JDK-8166570 In a future modular build, ant-javafx.jar will need to be compiled separately from the fxpackager module sources. This is because a module compile cannot be dependent on a non-module (like the ant jar) webrev: http://cr.openjdk.j

[webkit] [9] Review request for 8166265: jfxwebkit.dll is missing file detail for 8u112 and 9

Hello Kevin, Guru, Murali, Please review the following fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8166265 Webrev: http://cr.openjdk.java.net/~arajkumar/8166265/webrev.00 Analysis: Newly merged WebKit doesn't include version.res file generated by build.gradle, version.res

review: @Native for mac

Kevin, Chien, https://bugs.openjdk.java.net/browse/JDK-8166564 http://cr.openjdk.java.net/~ddhill/8166564 -- David Hill Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George S

[9] Review Request: 8165383 [packager] -native image generates all bundlers

Kevin, The -native CLI argument is 100% working. "-native image” for example generates all bundles rather than just the image. This obviously fixes that. Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8165383/webrev.00/ JIRA: https:/

Re: Review request for 8166242: Removal of com.sun.javafx.embed.AbstractEvents

Hi Kevin, I had already expected something like this (while I did not know the process in detail). It's definitely not an urgent thing, postponing it will not block other work. I already investigated it now, because applying it would probably make things easier when fixing other issues related

Re: Review request for 8166242: Removal of com.sun.javafx.embed.AbstractEvents

Hi Alexander, Since this is an enhancement, it needs to go through the FC extension process indicated here: http://openjdk.java.net/projects/jdk9/fc-extension-process First and foremost, we will need to assess the impact of the change and whether this is the right time to consider such a cha

Review request for 8166242: Removal of com.sun.javafx.embed.AbstractEvents

Hallo Kevin, Alexander Z, Vadim, I have created an initial patch for the replacement of AbstractEvents with direct usage of JavaFX representations: https://bugs.openjdk.java.net/browse/JDK-8166242 http://cr.openjdk.java.net/~anyssen/8166242/webrev.00/ Best Regards, Alexander

review @Native in graphics windows build

Kevin, Chien, https://bugs.openjdk.java.net/browse/JDK-8166471 webrev: http://cr.openjdk.java.net/~ddhill/8166471 -- David Hill Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- G

Re: [9] Review request for 8165853: Loading "https://www.windyty.com" with JavaFX WebView crashes JVM.

x27; Bottom Right). b. Launch dev tool before launching windyty.com and use the debugger tabs. -Guru On 20/9/16 4:31 AM, Dan Howard wrote: I can't even right-click view source. Is this Flash or something? On 9/19/2016 6:15 PM, Guru Hb wrote: Hi Kevin, Arun & Murali, Please review the

Re: [9] Review request for 8165853: Loading "https://www.windyty.com" with JavaFX WebView crashes JVM.

I can't even right-click view source. Is this Flash or something? On 9/19/2016 6:15 PM, Guru Hb wrote: Hi Kevin, Arun & Murali, Please review the fix for (RC and fix updated in JBS) JBS : https://bugs.openjdk.java.net/browse/JDK-8165853 Webrev : http://cr.openjdk.java.net/~ghb/81658

[9] Review request for 8165853: Loading "https://www.windyty.com" with JavaFX WebView crashes JVM.

Hi Kevin, Arun & Murali, Please review the fix for (RC and fix updated in JBS) JBS : https://bugs.openjdk.java.net/browse/JDK-8165853 Webrev : http://cr.openjdk.java.net/~ghb/8165853/webrev.00/index.html Thanks, Guru

review: @native annotations

Kevin, Guru, The javac tool now provides the ability to generate native headers as needed. This removes the need to run the javah tool as a separate step in the build pipeline. The feature is enabled in javac by using the new -h option, which is used to specify a directory in which the header

[9] Review Request:

Kevin, Add modules and limit modules are broken in some situations. JIRA: https://bugs.openjdk.java.net/browse/JDK-8166172 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8166172/webrev.00/

Review request [2] for 8143596: FXCanvas does not forward touch gestures to embedded scene

Hallo Alexander Z., Kevin, I have adjusted the patch for JDK-8143596 to reflect the initial review finding of Alexander Z. and to fix some whitespace issues: https://bugs.openjdk.java.net/browse/JDK-8143596 http://cr.openjdk.java.net/~anyssen/8143596/webrev.01/ <http://cr.openjdk.java.

[9] Review request for 8144258: Ensemble Advanced Media sample hangs after going full screen

Hi David, Alexander, Please review this fix: https://bugs.openjdk.java.net/browse/JDK-8144258 http://cr.openjdk.java.net/~vadim/8144258/webrev.00/ Thanks, Vadim

[9] Review Request: 8165059 Many jdk.packager properties files are missing from javafxsdk.tbom

Kevin, Files for translation. JIRA: https://bugs.openjdk.java.net/browse/JDK-8165059 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8165059/webrev.00/ Chris

[9] Review Request: 8147392 [launcher] Change Linux to use JLI rather than JNI

Kevin, This change goes hand in hand with the change in JDK-8165524 that will be pushed shortly. JNI is the only way to launch a modular application, so the Java Package’s launcher needs to be changed on Linux to launch this way (Windows has already been changed). JIRA: https://bugs.openjdk.ja

[9] Review Request: 8165882 Java Packager Cleanup

Kevin, Just some minor cleanup. JIRA: https://bugs.openjdk.java.net/browse/JDK-8165882 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8165882/webrev.00/ Chris

review: change checkWhiteSpace to match jcheck extension list

Kevin, https://bugs.openjdk.java.net/browse/JDK-8165963 (JDK-8165963) change checkWhiteSpace to match jcheck extension list diff in JBS. -- David Hill Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 -

review: Rework build to enable future jigsaw aware JDK9 build

Kevin, would you review this build change please. https://bugs.openjdk.java.net/browse/JDK-8165809 http://cr.openjdk.java.net/~ddhill/8165809.1 -- David Hill Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world.&

Review request for 8143596: FXCanvas does not forward touch gestures to embedded scene

Hi Alexander Z., Kevin, I have adopted my latest patch for JDK-8143596 (uploaded yesterday as patch file) to the latest tip and created a webrev for it (the uploaded patch is therefore now obsolete): https://bugs.openjdk.java.net/browse/JDK-8143596 http://cr.openjdk.java.net/~anyssen/8143596/we

[9] review request: 8095297: [Windows] Ensemble 8: Spinner example layout is broken

Hi Vadim or Jonathan, Please review the following to backport (forward-port) a fix that went into 8u-dev last year shortly after we forked 9-dev and stropped auto-syncing. This needs to be pushed to 9 or will cause a regression. https://bugs.openjdk.java.net/browse/JDK-8095297 http

[9] Review request: 8165373: Ensemble8 uses setAccessible to access methods and fields of various classes

Hi Vadim, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8165373 http://cr.openjdk.java.net/~kcr/8165373/webrev.01/ Details are in the bug report. Thanks. -- Kevin

[9] Review Request: 8165721 jmods folder is not auto discovered

Kevin, Please review this change to auto discovery of the jmods directory. JIRA: https://bugs.openjdk.java.net/browse/JDK-8165721 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8165721/webrev.00/ <http://cr.openjdk.java.net/~cbensen/JDK-8165548/webrev.00/> Chris

[9] Code Review Request For 8165363: PlatformImpl in javafx.graphics uses setAccessible to access method in javafx.swing

Hi Kevin, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8165363 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8165363/webrev.00/ Thanks, - Chien

[9] Code Review Request For 8165378: HelloDialog program in apps/toys uses setAccessible

Hi Kevin, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8165378 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8165378/webrev.00/ Thanks, - Chien

[9] Review Request 8165173 : DRT test canvas/philip/tests/2d.path.clip.empty.html fails with 8u112

Hi Kevin, Murali and Guru, Please review the below patch. JBS: https://bugs.openjdk.java.net/browse/JDK-8165173 Webrev : http://cr.openjdk.java.net/~asrivastava/8165173/webrev.00/ Tested on Win64 and Linux 64 The null path check was redundant and was applied making an

[9] Review Request for 8165508: Incorrect Bug ID in comment for JDK-8164076

Hi Ankit, Murali & Kevin, Please review the fix for https://bugs.openjdk.java.net/browse/JDK-8165508 <https://bugs.openjdk.java.net/browse/JDK-8165508> Webrev : http://cr.openjdk.java.net/~ghb/8165508/webrev.00/index.html <http://cr.openjdk.java.net/~ghb/8165508/webrev.00/index.

[9] Review Request: 8165548 javapackager -help shows --modulepath not --module-path

Kevin, Please review this simple string change. JIRA: https://bugs.openjdk.java.net/browse/JDK-8165548 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8165548/webrev.00/ Chris

Re: [9] Review request for 8090176: Pisces software renderer shows incomplete border images in particular situation

PM, Jim Graham wrote: JBS: https://bugs.openjdk.java.net/browse/JDK-8090176 webrev for 9u: http://cr.openjdk.java.net/~flar/JDK-8090176/webrev.9u.01/ The webrev is prepared for 8u, but I will be holding off on submitting that for backport review until the fix has baked in the 9u-dev repo for a

[9] Review request for 8137141: Fatal error in Method::build_method_counters when called from libglass.so

Hi David, Kevin, Could you please review the fix: https://bugs.openjdk.java.net/browse/JDK-8137141 http://cr.openjdk.java.net/~vadim/8137141/webrev.00/ Thanks, Vadim

[9] Review request for 8090176: Pisces software renderer shows incomplete border images in particular situation

JBS: https://bugs.openjdk.java.net/browse/JDK-8090176 webrev for 9u: http://cr.openjdk.java.net/~flar/JDK-8090176/webrev.9u.01/ The webrev is prepared for 8u, but I will be holding off on submitting that for backport review until the fix has baked in the 9u-dev repo for a couple of weeks

[9] Review Request:

Kevin, Please review this change to fix the .properties files. JIRA: https://bugs.openjdk.java.net/browse/JDK-8165057 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8165057/webrev.00/ Chris

Re: JDK-8165224 Review request

Hello, everyone. Please have a look at my review request for test bug: Jira issue: https://bugs.openjdk.java.net/browse/JDK-8165238 Webrev: http://cr.openjdk.java.net/~arusakov/8165238/webrev.00/ Thanks in advance.

JDK-8165224 Review request

Hello, everyone. Please have a look at my review request for test bug: Jira issue: https://bugs.openjdk.java.net/browse/JDK-8165224 Webrev: http://cr.openjdk.java.net/~arusakov/8165224/webrev.00/ Thanks in advance.

[9] Review request for 8164076: [Windows] JavaFX crash in WebPage.twkOpen in 8u112 when closing WebView while debugging

Hi Kevin, Murali & Ankit, Please review the fix for JBS : https://bugs.openjdk.java.net/browse/JDK-8164076 Webrev : http://cr.openjdk.java.net/~ghb/8164960/webrev.00/ RC and Solution updated in JBS. Thanks, Guru

[9] Review Request: 8163076 javapackager bundling fails due to issue in JAVA-API

Kevin, Please review this change to fix invoking the Java Packager through the Java Packager API. JIRA: https://bugs.openjdk.java.net/browse/JDK-8163076 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8163076/webrev.00/ Chris

[9] Review request for 8160988: NoClassDefFound exception when using getDeclaredMethod method of MediaView class

Hi Kevin and David, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8160988 Removed dependency on IOSMediaPlayer. Thanks, Alexander

[9] Review request for 8164914: Add Test Case for JDK-8162979

  Hi Kevin, Arun, Guru, Please review the following fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8164914 Webrev: http://cr.openjdk.java.net/~mbilla/8164914/webrev.00/ Thanks, Murali

[9] Review request for 8134315: [LineChart] Blurry elements since 8u60

Hi Jim, Jonathan, Could you please review the fix: https://bugs.openjdk.java.net/browse/JDK-8134315 http://cr.openjdk.java.net/~vadim/8134315/webrev.00/ Thanks, Vadim

HEADS UP and review for new gnu style java command line options

HEADS UP: I just commited a change that will require a JIGSAW_HOME that is build jdk-9+132 or later. That build is now available for download from the JDK9 EA site (actually b133) . This commit went in a bit early to squeeze it into this weeks promotion to a

Review request for 8144263 : [WebView, OS X] Webkit rendering artifacts with inertia scrolling

Hi Kevin, Arun & Murali, Please review the fix for https://bugs.openjdk.java.net/browse/JDK-8144263 <https://bugs.openjdk.java.net/browse/JDK-8144263> Webrev : http://cr.openjdk.java.net/~ghb/8144263/webrev.00/ <http://cr.openjdk.java.net/~ghb/8144263/webrev.00/> RC and Sol

[9, 8u] Review request for 8087565: Scaling problem on OSX Retina

Same patch applies to both (modulo source code paths). jbs: https://bugs.openjdk.java.net/browse/JDK-8087565 8u webrev: http://cr.openjdk.java.net/~flar/JDK-8087565/webrev.8u.00/ 9u webrev: http://cr.openjdk.java.net/~flar/JDK-8087565/webrev.9u.00/ This is a minor improvement on the earlier fix

[9] Review Request: 8164248 [packager] New Modular Arguments to be made public for Packager API

Kevin, Please review the change to make all the modular arguments part of the Java Packager public API. JIRA: https://bugs.openjdk.java.net/browse/JDK-8164248 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8164248/webrev.00/ Thanks, Chris

[9] Review Request: 8155956 Java Packager runtime argument

Kevin, Please review change for Java Packager runtime argument and a few other minor changes. Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8155956/webrev.00/ JIRA: https://bugs.openjdk.java.net/browse/JDK-8155956 Chris

[9] Review request for 8162979: Website weibo.com cannot be loaded

  Hi Kevin, Arun, Guru, Please review the following fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8162979 Webrev: http://cr.openjdk.java.net/~mbilla/8162979/webrev.00/   Thanks, Murali

HEADS UP and review for new gnu style java command line options

general are not going to impact most developers. Please download and reset your JIGSAW_HOME to point to jdk-9+132 (or later) now. A last note: We still require JDK9 ea build 109 as teh bootstrap JDK ( JDK_HOME/JAVA_HOME ) Kevin, please review: Update FX to use new gnu style java command line opt

[9][tests]Review request for 8164498 : Backout changeset c9f45449d053 which has wrong bug id and commit message

Hi Kevin, Please review the change for (Backing out the changes done for JDK-8163084 with wrong bug ID and commit message). Webrev : http://cr.openjdk.java.net/~ghb/rbgangad/8164498/webrev.00/ JBS : https://bugs.openjdk.java.net/browse/JDK-8164498 Thanks, Guru

[webkit] [9] Review request for 8164495: [WebView] Backout changeset 653ce34aafba

Hello Kevin, Guru, Murali, Please review the simple fix to revert the unintentional change. JIRA: https://bugs.openjdk.java.net/browse/JDK-8164495 Webrev: http://cr.openjdk.java.net/~arajkumar/8164495/webrev.00/ Regards, Arun

Review request: JDK-8164212

Hello, guys. I have another improvement for our test workspace, so please have a look at it. Fix is applicable for both 8/tests and 9/tests without change. Jira: https://bugs.openjdk.java.net/browse/JDK-8164212 Webrev, 9: http://cr.openjdk.java.net/~arusakov/8164212/webrev-9.00/ Webrev, 8: http

[webkit] [9] Review request for 8164314: [WebView] Debug build is no longer working in OSX

Hello Kevin, Guru, Murali, Please review the simple debug build fix for OSX. JIRA: https://bugs.openjdk.java.net/browse/JDK-8164314 <https://bugs.openjdk.java.net/browse/JDK-8164314> Webrev: http://cr.openjdk.java.net/~arajkumar/8164314/webrev.00 <http://cr.openjdk.java.net/~arajkuma

[9] Review request for JDK-8160073: menu issues in case of two-display configuration

JBS: https://bugs.openjdk.java.net/browse/JDK-8160073 webrev: http://cr.openjdk.java.net/~flar/JDK-8160073/webrev.00/ The details are in the comments in the bug report. To summarize: - send a notification when DPI changes to reevaluate scene.getXY() - correctly scale event screen coordinates fo

[9] Review request for 8164096: ListChangeListener on ReadOnlyListWrapper's getReadOnlyProperty() does not reset change

Hi Chien, Could you please review the fix: https://bugs.openjdk.java.net/browse/JDK-8164096 http://cr.openjdk.java.net/~vadim/8164096/webrev.00/ Thanks, Vadim

[9] Code Review Request For 8164141: [Javadoc] Replace references of Stage with Window in the Window class

Hi Kevin, Please review the proposed doc fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8164141 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8164141/webrev.00/ Thanks, - Chien

[9] Code Review Request For 8130675:Document that setting scene on stage changes stage size unless explicitly set

Hi Kevin, Please review this proposed doc fix: JIRA:https://bugs.openjdk.java.net/browse/JDK-8130675 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8130675/webrev.00/ Thanks, - Chien

[9] Review request 8163971: Revert "MiscellaneousTest.testRT26306 and testWebViewWithoutSceneGraph" Indentation done while JDK-8163582 fix

Hi Kevin, Please review the fix for JBS : https://bugs.openjdk.java.net/browse/JDK-8163971 Webrev : http://cr.openjdk.java.net/~ghb/8163971/webrev.00/ Accidentally Indent two other Unit test case while merging JDK-8163582. Thanks, Guru

[9] Review request 8163582: JavaFX browser can get stuck in an infinite loop when calling path.getTotalLength()

Hi Kevin, Arun & Murali, Please review the fix for : JBS : https://bugs.openjdk.java.net/browse/JDK-8163582 Webrev : http://cr.openjdk.java.net/~ghb/8163582/webrev.00/ RC : Merged back JDK-8090035 and added Unit test case. Thanks, Guru

Re: [9] Review request for 8159892: Ubuntu 16.04: invalid rendering of FX app stage in case of scaling

New webrev: http://cr.openjdk.java.net/~flar/JDK-8159892/webrev.01/ This one makes the presence of the new functions being used optional. Details are in JBS. With respect to my comment below about the consistency of declarations and definitions, there didn't seem to be much consistency in the

[9] Review request: 8144768: Update version numbers in FX docs for JDK 9

Dave, Please review this (hopefully) simple fix: https://bugs.openjdk.java.net/browse/JDK-8144768 http://cr.openjdk.java.net/~kcr/8144768/webrev.01/ Thanks. -- Kevin

[9] Review request for 8163576: StackedBarChart.getSeriesSize is unneeded

Hi Jonathan, Could you please review the fix: https://bugs.openjdk.java.net/browse/JDK-8163576 http://cr.openjdk.java.net/~vadim/8163576/webrev.00/ Thanks, Vadim

[9] Review request for 8159892: Ubuntu 16.04: invalid rendering of FX app stage in case of scaling

Bug: https://bugs.openjdk.java.net/browse/JDK-8159892 webrev: http://cr.openjdk.java.net/~flar/JDK-8159892/webrev.00/ There are a number of bugs filed on this, or very similar issues as well - all related to broken DPI scaling on GTK3. It looks like there is a simple way of disabling automatic

review: protect FileChooser return from internal NPE

Kevin, protect FileChooser return from internal NPE https://bugs.openjdk.java.net/browse/JDK-8163526 inline in jbs. Tested with a problem reproducer on windows. -- David Hill Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." --

review: Add HelloDirectoryChooser toy.

Kevin or Chien, could you review this toy addition: https://bugs.openjdk.java.net/browse/JDK-8163514 webrev: http://cr.openjdk.java.net/~ddhill/8163514 -- David Hill Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world.&

review: Support Gradle version 2.14+

jbs: https://bugs.openjdk.java.net/browse/JDK-8163502 webrev: http://cr.openjdk.java.net/~ddhill/8163502/ Had to handle a couple of new package renames. -- David Hill Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George San

[9] Code Review Request For 8163383: Fix doclint errors and warnings in javafx.base module

Hi Kevin, Please review this proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8163383 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8163383/webrev.00/ Thanks, - Chien

[9] Review request for 8163358: BubbleChart.updateLegend should add all LegendItems with setAll

Hi Jonathan, Kevin, Could you please review this enhancement: https://bugs.openjdk.java.net/browse/JDK-8163358 http://cr.openjdk.java.net/~vadim/8163358/webrev.00/ Thanks, Vadim

[9] Review request for 8163454: PieChart legend is not updated while invisible

Jonathan, Could you please review the fix: https://bugs.openjdk.java.net/browse/JDK-8163454 http://cr.openjdk.java.net/~vadim/8163454/webrev.00/ Thanks, Vadim

[9, 8u] Review request: 8159726: Cleanup whitespace and file permission in tests repo

Andrey, Please review the following white-space-only change: https://bugs.openjdk.java.net/browse/JDK-8159726 http://cr.openjdk.java.net/~kcr/8159726/webrev-9.01/ With this change the openjfx tests repo in both 8u and 9 will be jcheck compliant. Thanks. -- Kevin

[9] Review request: 8163183: [test] Correct assertEquals ("", actual, expected) in LoadTest.loadJarFile

Hi Kevin & Arun, Please review the fix for JBS : https://bugs.openjdk.java.net/browse/JDK-8163183 Webrev : http://cr.openjdk.java.net/~ghb/8163183/webrev.00/ Thanks, Guru

[9] Review request: 8162783: [Windows] HiDPI screenshot artifacts using glass Robot

Hi Jim and Dave, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8162783 http://cr.openjdk.java.net/~kcr/8162783/webrev.00/ Details are in the bug report. Thanks. -- Kevin

Re: [8udev (backport)] Code Review Request For 8163302: Stage alwaysOnTop property not reset to false if permission is denied

Thanks for the reminder. I have just resent it with the main Bug ID and updated the JIRA. - Chien On 08/05/16 13:47, Kevin Rushforth wrote: This review request is using the wrong Bug ID. We never use the backport ID for anything (ever), so please resend with the correct subject line, which

[8udev (backport)] Code Review Request For 8156078: Stage alwaysOnTop property not reset to false if permission is denied

Hi Kevin, Please review the proposed backport: JIRA: https://bugs.openjdk.java.net/browse/JDK-8156078 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8156078/backport.00/ Thanks, - Chien

Re: [8udev (backport)] Code Review Request For 8163302: Stage alwaysOnTop property not reset to false if permission is denied

This review request is using the wrong Bug ID. We never use the backport ID for anything (ever), so please resend with the correct subject line, which should have the Bug ID of the main bug: 8156078 Thanks. -- Kevin Chien Yang wrote: Hi Kevin, Please review the proposed backport: JIRA

[8udev (backport)] Code Review Request For 8163302: Stage alwaysOnTop property not reset to false if permission is denied

Hi Kevin, Please review the proposed backport: JIRA: https://bugs.openjdk.java.net/browse/JDK-8163302 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8163302/webrev.00/ Thanks, - Chien

review: Build should fail fast with unsupported OS/ARCH

thanks to Jyri's email, I have a simple fix to fail quickly and with a understandable error message. jbs: https://bugs.openjdk.java.net/browse/JDK-8163196 simple diff inside jbs -- David Hill Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey

[webkit] [9] Review request for 8162949: [WebView] WebView can't display social network icons on wellsfargo.com

Hello Kevin, Guru, Murali, Please review the following fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8162949 Webrev: http://cr.openjdk.java.net/~arajkumar/8162949/webrev.00 Regards, Arun

[9] Review request for 8161673: Scatter-Chart is incompatible with ListProperty

Jonathan, Could you please review the fix: https://bugs.openjdk.java.net/browse/JDK-8161673 http://cr.openjdk.java.net/~vadim/8161673/webrev.00/ Thanks, Vadim

[9] Review request for 8089337 : JDK crash on Mac 10.10 with very large stage

Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8089337/00 for the issue https://bugs.openjdk.java.net/browse/JDK-8089337 -- -- Thanks, Alexander.

[9] Review request for 8087498 [Mac] : Full screen mode fails for certain StageStyles

Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8087498/00 for the issue https://bugs.openjdk.java.net/browse/JDK-8087498 -- -- Thanks, Alexander.

[9] Review request for 8163137 [Mac] : Maximizing a window with Cmd+Green button with Screen-Size hides it

Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8163137/00 for the issue https://bugs.openjdk.java.net/browse/JDK-8163137 -- -- Thanks, Alexander.

[9] Review request for 8162977: General sibling selector is broken for selected input boxes in WebView

    Hi Kevin, Arun, Guru, Please review the following fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8162977 Webrev: http://cr.openjdk.java.net/~mbilla/8162977/webrev.00/ Thanks, Murali

review: (JDK-8163010) support macosx with fix_patch scripts

Kevin, I really dislike platform specific code :-) yet another review (JDK-8163010) support macosx with fix_patch scripts <https://bugs.openjdk.java.net/browse/JDK-8163010> attached new versions of the files as it is a pretty big makeover. Diff is in the jbs. -- David Hill Java Em

<    5   6   7   8   9   10   11   12   13   14   >