Re: Ability to decorate ChangeListener

2014-03-22 Thread Tomas Mikula
The suspicious thing about your solution is that your smart implementation of equals() is not symmetric. In case the observable value is visible only within your project, you could do this: interface Subscription { void unsubscribe(); } class MyObservableValueT implements

Error in tablevie ghost error

2014-03-22 Thread siput
Why when i clik in the area outside row contain a data and outside column area I get an error? red area of eror

Re: Ability to decorate ChangeListener

2014-03-22 Thread Tomas Mikula
A simpler and more universal solution is to also override removeListener: public void removeListener(ChangeListener? super T listener) { super.removeListener(decorated(listener)); } And the equals() method on decorated listeners only compares the delegates (thus is symmetric). Regards,

LNK1123: failure during conversion to COFF when building under windows

2014-03-22 Thread Michael Berry
Hi, I'm currently trying to build OpenJFX from source on Windows - I've followed the instructions on the build page and have Visual Studio 2010, the June 2010 directx sdk, cygwin and its relevant modules installed. However, when building it fails at the buildJavaFXPackage task (output below.)

Re: *PropertyBase vs Simple*Property

2014-03-22 Thread Tomas Mikula
On Fri, Mar 21, 2014 at 8:53 PM, Tom Schindl tom.schi...@bestsolution.at wrote: Hi Richard, Coming back to this old thread and now that we are using lamdas all over I guess we could take one more look into that. I've prototyped an initial version by introducing a new internal type named

Re: Ability to decorate ChangeListener

2014-03-22 Thread Mario Ivankovits
Hi Thomas! Thanks for your input. Because I want to decorated listeners added by JavaFX core I can not use the sub/unsub pattern. Your second proposal is almost what I do right now. In removeListener I consult a map where the decorated listeners and their undecorated one lives. Regarding the

Re: Ability to decorate ChangeListener

2014-03-22 Thread Kevin Rushforth
If you are talking about a change to the JavaFX API, we are not likely to accept such a change if it breaks the contract of equals() or hashcode(). In your own app it may not matter, but it is dangerous to assume it won't matter to anyone. Martin owns the core libraries and can comment

Re: Ability to decorate ChangeListener

2014-03-22 Thread Mario Ivankovits
The only thing which I ask for is to flip this „if in the *ExpressionHelper classes: So, JavaFX does not break anything and it is up to the app developer to take the risk or not. if (listener.equals(changeListeners[index])) { If we flip this to if

Re: LNK1123: failure during conversion to COFF when building under windows

2014-03-22 Thread Kevin Rushforth
Do you have VS 2010 Service Pack 1? I've seen this failure on machines that don't have SP1 installed. -- Kevin Michael Berry wrote: Hi, I'm currently trying to build OpenJFX from source on Windows - I've followed the instructions on the build page and have Visual Studio 2010, the June 2010

Re: Ability to decorate ChangeListener

2014-03-22 Thread Mario Ivankovits
Yep, null throws a NullPointerException in addListener by design (also in removeListener) - the listener collection is safe. Am 22.03.2014 um 15:50 schrieb Kevin Rushforth kevin.rushfo...@oracle.commailto:kevin.rushfo...@oracle.com: What if changeListeners[index] is null? Maybe this is

Re: Ability to decorate ChangeListener

2014-03-22 Thread Tomas Mikula
Hi Mario, even if your proposal gets accepted, you would still depend on an implementation detail of JavaFX, which is always good to avoid. To sum up, my second proposal compared to your current solution: (+) your equals() stays symmetric; (+) no need for an extra Map of listeners. My second

Re: Ability to decorate ChangeListener

2014-03-22 Thread Mario Ivankovits
Probably you avoid the map, but it requires to decorate the listener again, right? If you think about the tons of observable values and add/removeListener operations in an tree view when scrolling it might get costly and put pressure on the GC. Anyway, I will be more than happy to assist with

Re: *PropertyBase vs Simple*Property

2014-03-22 Thread Tom Schindl
Why not i expect the property to be fully initialize so this would be a breaking change in behavior. Tom Von meinem iPhone gesendet Am 22.03.2014 um 14:54 schrieb Tomas Mikula tomas.mik...@gmail.com: On Fri, Mar 21, 2014 at 8:53 PM, Tom Schindl tom.schi...@bestsolution.at wrote: Hi

Re: *PropertyBase vs Simple*Property

2014-03-22 Thread Tom Schindl
Ah i missed you passing them to the constructor. Still i don't see this as much an improvement because we still create a vast amount of anon inner classes. Tom Von meinem iPhone gesendet Am 22.03.2014 um 16:23 schrieb Tom Schindl tom.schi...@bestsolution.at: Why not i expect the property

Re: Ability to decorate ChangeListener

2014-03-22 Thread Tomas Mikula
On Sat, Mar 22, 2014 at 4:11 PM, Mario Ivankovits ma...@datenwort.at wrote: Probably you avoid the map, but it requires to decorate the listener again, right? Right. For a pair of addListener-removeListener calls, you have 2 decorations instead of 1. I usually think of the costs in asymptotic

Re: *PropertyBase vs Simple*Property

2014-03-22 Thread Tomas Mikula
On Sat, Mar 22, 2014 at 4:41 PM, Tom Schindl tom.schi...@bestsolution.at wrote: Ah i missed you passing them to the constructor. Still i don't see this as much an improvement because we still create a vast amount of anon inner classes. Sure, I just wanted to get the baseline for comparison

Re: LNK1123: failure during conversion to COFF when building under windows

2014-03-22 Thread Michael Berry
Hi Kevin, Many thanks for that - that has solved the problem! Perhaps the wiki pagehttps://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFXshould be updated to note that SP1 should be installed as well as vanilla VS2010? I would do it myself, but don't have the privileges. Thanks, Michael

Re: LNK1123: failure during conversion to COFF when building under windows

2014-03-22 Thread Kevin Rushforth
Glad this solved your problem. I added SP1 to the Wiki page. -- Kevin Michael Berry wrote: Hi Kevin, Many thanks for that - that has solved the problem! Perhaps the wiki page https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX should be updated to note that SP1 should be

Blog post: Trigger processing after a period of inactivity

2014-03-22 Thread Tomas Mikula
Hi all, I just want to quickly inform that I have a post on how to defer processing of user input until the user has been inactive for a certain amount of time. http://tomasmikula.github.io/blog/2014/03/22/trigger-processing-after-a-period-of-inactivity.html Best regards, Tomas

Adding GStreamer plugins

2014-03-22 Thread Michael Berry
Hi all, I've managed to clone and build OpenJFX successfully, and am now in the process of trying to see how feasible it would be to add support for other media formats. As a first port of call I'm attempting to see if I can get the framework accepting the Matroska plugin, but seem to be coming a