Re: RFR: [WIP] 8277785: ListView scrollTo jumps to wrong location when CellHeight is changed [v7]

2022-05-30 Thread Johan Vos
ediately resize the cell and sets the new value in the cache > containing the cellsizes. Johan Vos has updated the pull request incrementally with one additional commit since the last revision: Precalculate size of cells that are likely going to be used in rendering. This avoid re

Re: RFR: [WIP] 8277785: ListView scrollTo jumps to wrong location when CellHeight is changed [v6]

2022-05-23 Thread Johan Vos
On Mon, 23 May 2022 20:44:47 GMT, Johan Vos wrote: >> When the size of a ListCell is changed and a scrollTo method is invoked >> without having a layout calculation in between, the old (wrong) size is used >> to calculcate the total estimate. This happens e.g. when t

Re: RFR: 8277785: ListView scrollTo jumps to wrong location when CellHeight is changed [v6]

2022-05-23 Thread Johan Vos
ediately resize the cell and sets the new value in the cache > containing the cellsizes. Johan Vos has updated the pull request incrementally with one additional commit since the last revision: Try to keep visible cells at their original position when improving the estimate. This reduce

Re: RFR: JDK-8286256 : Update libxml2 to 2.9.14 [v4]

2022-05-23 Thread Johan Vos
On Wed, 18 May 2022 13:39:12 GMT, Hima Bindu Meda wrote: >> Updated libxml to version 2.9.14.As mentioned in UPDATING.txt, configured >> for windows , linux and Mac platforms and updated the files accordingly. >> >> Updated libxslt to version 1.1.35. Generated the config.h files for windows

Re: [jfx17u] RFR: 8283218: Update GStreamer to 1.20.1

2022-05-11 Thread Johan Vos
On Mon, 9 May 2022 21:07:39 GMT, Kevin Rushforth wrote: > Almost clean backport to `jfx17u`. Tested in connection with libffi update in > the `test-kcr-17.0.4` branch. > > The only difference from the mainline patch is that the following file is not > present in `jfx17u`, so that part of the

Re: RFR: 8285217: [Android] Window's screen is not updated after native screen was disposed [v4]

2022-05-10 Thread Johan Vos
On Tue, 10 May 2022 15:19:58 GMT, Jose Pereda wrote: >> This PR updates the screen for each window even for the case where the old >> screen has been disposed but there is a new screen instance found for such >> window. >> >> This is the case of Android, where the lifecycle of the application

Re: RFR: 8285217: [Android] Window's screen is not updated after native screen was disposed [v3]

2022-05-10 Thread Johan Vos
On Wed, 4 May 2022 16:55:30 GMT, Jose Pereda wrote: >> This PR updates the screen for each window even for the case where the old >> screen has been disposed but there is a new screen instance found for such >> window. >> >> This is the case of Android, where the lifecycle of the application

Re: RFR: 8285217: [Android] Window's screen is not updated after native screen was disposed [v3]

2022-05-10 Thread Johan Vos
On Wed, 4 May 2022 16:55:30 GMT, Jose Pereda wrote: >> This PR updates the screen for each window even for the case where the old >> screen has been disposed but there is a new screen instance found for such >> window. >> >> This is the case of Android, where the lifecycle of the application

Re: RFR: 8277785: ListView scrollTo jumps to wrong location when CellHeight is changed [v4]

2022-05-08 Thread Johan Vos
On Mon, 25 Apr 2022 09:00:54 GMT, Florian Kirmaier wrote: >> I agree with that observation. The mathematical perfect situation would be >> to pre-calculate the height of all items, so that the scrolbar position can >> be exact, and the content placing can be exact as well. That would be at

Re: RFR: 8277785: ListView scrollTo jumps to wrong location when CellHeight is changed [v5]

2022-05-04 Thread Johan Vos
ediately resize the cell and sets the new value in the cache > containing the cellsizes. Johan Vos has updated the pull request incrementally with one additional commit since the last revision: Don't recalculate estimated size while doing a layout cycle. There are a number of paths p

[jfx17u] Integrated: 8276167: VirtualFlow.scrollToTop doesn't scroll to the top of the last element

2022-05-02 Thread Johan Vos
On Mon, 2 May 2022 13:14:05 GMT, Johan Vos wrote: > Reviewed-by: aghaisas, jvos This pull request has now been integrated. Changeset: 62ab00bd Author: Johan Vos URL: https://git.openjdk.java.net/jfx17u/commit/62ab00bd5c8913fb8089b3d02404366db1d52c37 Stats: 42 lines in 4 fi

[jfx17u] Integrated: 8276167: VirtualFlow.scrollToTop doesn't scroll to the top of the last element

2022-05-02 Thread Johan Vos
Reviewed-by: aghaisas, jvos - Commit messages: - 8276167: VirtualFlow.scrollToTop doesn't scroll to the top of the last element Changes: https://git.openjdk.java.net/jfx17u/pull/52/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx17u=52=00 Issue:

[jfx17u] Integrated: 8276553: ListView scrollTo() is broken after fix for JDK-8089589

2022-05-02 Thread Johan Vos
On Sat, 30 Apr 2022 18:48:06 GMT, Johan Vos wrote: > Reviewed-by: kcr, mstrauss This pull request has now been integrated. Changeset: 83534e2d Author: Johan Vos URL: https://git.openjdk.java.net/jfx17u/commit/83534e2df8f4d20a661ae68c1c6f9925302953e3 Stats: 29 lines in 5 fi

[jfx17u] Integrated: 8274137: TableView scrollbar/header misaligned when reloading data

2022-05-02 Thread Johan Vos
On Sat, 30 Apr 2022 18:44:09 GMT, Johan Vos wrote: > Reviewed-by: kcr, aghaisas This pull request has now been integrated. Changeset: ca0e5a47 Author: Johan Vos URL: https://git.openjdk.java.net/jfx17u/commit/ca0e5a4752e3a0ab2c9b6950c61678b4b07c4749 Stats: 34 lines in 3 fi

[jfx17u] RFR: 8276553: ListView scrollTo() is broken after fix for JDK-8089589

2022-04-30 Thread Johan Vos
Reviewed-by: kcr, mstrauss - Commit messages: - 8276553: ListView scrollTo() is broken after fix for JDK-8089589 Changes: https://git.openjdk.java.net/jfx17u/pull/50/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx17u=50=00 Issue:

[jfx17u] RFR: 8274137: TableView scrollbar/header misaligned when reloading data

2022-04-30 Thread Johan Vos
Reviewed-by: kcr, aghaisas - Commit messages: - 8274137: TableView scrollbar/header misaligned when reloading data Changes: https://git.openjdk.java.net/jfx17u/pull/49/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx17u=49=00 Issue:

Re: [jfx11u] RFR: 8283218: Update GStreamer to 1.20.1

2022-04-30 Thread Johan Vos
On Sat, 30 Apr 2022 13:37:08 GMT, Kevin Rushforth wrote: > Backport to `jfx11u`. Tested in connection with libffi update in the > `test-kcr-11.0.16` branch. > > This was not a clean backport, but the merge conflicts were trivial to > resolve. Here is a summary of the changes. The jfx mainline

Re: [jfx11u] RFR: 8276174: JavaFX build fails on macOS aarch64

2022-04-30 Thread Johan Vos
On Sat, 30 Apr 2022 13:51:23 GMT, Kevin Rushforth wrote: > Backport to `jfx11u` so we can build on macOS / aarch64 without needing to > specify `-PCOMPILE_TARGET=arm64`. It isn't a clean backport, since I also had > to include the definition of `IS_AARCH64` which is present in mainline, but >

Re: RFR: 8283218: Update GStreamer to 1.20.1 [v5]

2022-04-21 Thread Johan Vos
On Wed, 20 Apr 2022 23:08:00 GMT, Alexander Matveev wrote: >> - GStreamer updated to 1.20.1 and GLib updated to 2.72.0. >> - No changes to our code, except in GstAudioSpectrum.cpp >> g_atomic_pointer_compare_and_exchange() was changed to >> g_atomic_pointer_set(). For some reason I was not

[jfx11u] Integrated: 8283328: Update libxml2 to 2.9.13

2022-04-20 Thread Johan Vos
On Wed, 20 Apr 2022 13:21:39 GMT, Johan Vos wrote: > Reviewed-by: jvos, kcr, arapte This pull request has now been integrated. Changeset: 1b214b04 Author: Johan Vos URL: https://git.openjdk.java.net/jfx11u/commit/1b214b04f78e5bbf2d49f63e7995f55141dba6b4 Stats: 55661 lines in

[jfx18] Integrated: 8283328: Update libxml2 to 2.9.13

2022-04-20 Thread Johan Vos
On Wed, 20 Apr 2022 13:29:36 GMT, Johan Vos wrote: > Reviewed-by: jvos, kcr, arapte This pull request has now been integrated. Changeset: 2a1805a2 Author: Johan Vos URL: https://git.openjdk.java.net/jfx/commit/2a1805a2b9ac83011677b654d2505d7147a6e916 Stats: 55661 lines in

[jfx17u] Integrated: 8283328: Update libxml2 to 2.9.13

2022-04-20 Thread Johan Vos
On Wed, 20 Apr 2022 13:24:53 GMT, Johan Vos wrote: > Reviewed-by: jvos, kcr, arapte This pull request has now been integrated. Changeset: 5c0d0a65 Author: Johan Vos URL: https://git.openjdk.java.net/jfx17u/commit/5c0d0a653f6066c545b2cc61655f29e99c9ccca6 Stats: 55661 lines in

[jfx18] RFR: 8283328: Update libxml2 to 2.9.13

2022-04-20 Thread Johan Vos
Reviewed-by: jvos, kcr, arapte - Commit messages: - 8283328: Update libxml2 to 2.9.13 Changes: https://git.openjdk.java.net/jfx/pull/777/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=777=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8283328 Stats: 55661 lines

[jfx17u] RFR: 8283328: Update libxml2 to 2.9.13

2022-04-20 Thread Johan Vos
Reviewed-by: jvos, kcr, arapte - Commit messages: - 8283328: Update libxml2 to 2.9.13 Changes: https://git.openjdk.java.net/jfx17u/pull/41/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx17u=41=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8283328 Stats: 55661

[jfx11u] RFR: 8283328: Update libxml2 to 2.9.13

2022-04-20 Thread Johan Vos
Reviewed-by: jvos, kcr, arapte - Commit messages: - 8283328: Update libxml2 to 2.9.13 Changes: https://git.openjdk.java.net/jfx11u/pull/84/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u=84=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8283328 Stats: 55661

[jfx18] Integrated: 8285181: Change JavaFX release version to 18.0.2 in jfx18 branch

2022-04-20 Thread Johan Vos
On Wed, 20 Apr 2022 07:00:46 GMT, Johan Vos wrote: > Increase security version to 2 for JavaFX 18.0.2 This pull request has now been integrated. Changeset: 60d76c8b Author: Johan Vos URL: https://git.openjdk.java.net/jfx/commit/60d76c8b5d60a816376aa569ad562b56fc790b4c Stats:

Backport requests for JavaFX 11, 17, 18

2022-04-20 Thread Johan Vos
Hi Kevin, I request permission to backport the following issue to JavaFX 11.0.16, JavaFX 17.0.4 and JavaFX 18.0.2 https://bugs.openjdk.java.net/browse/JDK-8283328 Apart from whitespace warnings, the patch applies clean - Johan

[jfx11u] Integrated: 8285152: Change JavaFX release version to 11.0.16 in jfx11u

2022-04-20 Thread Johan Vos
On Wed, 20 Apr 2022 06:37:08 GMT, Johan Vos wrote: > Update security version for JavaFX 11 to 16. This pull request has now been integrated. Changeset: f0440390 Author: Johan Vos URL: https://git.openjdk.java.net/jfx11u/commit/f0440390bdb064c7a5a4cfd19bdba47322cd3009 Stats:

[jfx17u] Integrated: 8285153: Change JavaFX release version to 17.0.4 in jfx17u

2022-04-20 Thread Johan Vos
On Wed, 20 Apr 2022 06:43:32 GMT, Johan Vos wrote: > Update security version for JavaFX 17 to 4. This pull request has now been integrated. Changeset: b41307ff Author: Johan Vos URL: https://git.openjdk.java.net/jfx17u/commit/b41307ff3f0cec70f1eafe808173ec0fb0cba36c Stats:

[jfx17u] RFR: 8285153: Change JavaFX release version to 17.0.4 in jfx17u

2022-04-20 Thread Johan Vos
Update security version for JavaFX 17 to 4. - Commit messages: - Increase security version to 4 Changes: https://git.openjdk.java.net/jfx17u/pull/40/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx17u=40=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8285153 Stats:

[jfx18] RFR: 8285181: Change JavaFX release version to 18.0.2 in jfx18 branch

2022-04-20 Thread Johan Vos
Increase security version to 2 for JavaFX 18.0.2 - Commit messages: - Increase security version to 2 for JavaFX 18.0.2 Changes: https://git.openjdk.java.net/jfx/pull/776/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=776=00 Issue:

[jfx11u] RFR: 8285152: Change JavaFX release version to 11.0.16 in jfx11u

2022-04-20 Thread Johan Vos
Update security version for JavaFX 11 to 16. - Commit messages: - Update security version for JavaFX 11 to 16. Changes: https://git.openjdk.java.net/jfx11u/pull/83/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u=83=00 Issue:

Re: [jfx18, jfx17u, jfx11u] RFR: Request to backport April 2022 CPU changes

2022-04-19 Thread Johan Vos
Approved. On Tue, Apr 19, 2022 at 6:03 PM Kevin Rushforth wrote: > Hi Johan, > > I request approval to backport the changes from the just-released April > 2022 CPU to jfx:jfx18 (for 18.0.1), jfx17u (for 17.0.3) and to jfx11u > (for 11.0.15) . > >

Re: RFR: Request to sync April 2022 changes into jfx master

2022-04-19 Thread Johan Vos
Approved. On Tue, Apr 19, 2022 at 6:03 PM Kevin Rushforth wrote: > Hi Johan, > > I request approval to sync changes from to the just-released April 2022 > CPU release into the 'master' branch of the 'jfx' repo. Here is the > aggregate set of changes for the fixes: > >

Re: RFR: 8277785: ListView scrollTo jumps to wrong location when CellHeight is changed [v4]

2022-04-14 Thread Johan Vos
On Wed, 30 Mar 2022 13:27:40 GMT, Johan Vos wrote: >> When the size of a ListCell is changed and a scrollTo method is invoked >> without having a layout calculation in between, the old (wrong) size is used >> to calculcate the total estimate. This happens e.g. when t

[jfx18] Integrated: 8282099: Cherry-pick WebKit 613.1 stabilization fixes (2)

2022-04-13 Thread Johan Vos
On Wed, 13 Apr 2022 16:00:41 GMT, Johan Vos wrote: > Reviewed-by: kcr, jvos This pull request has now been integrated. Changeset: 7e2cefba Author: Johan Vos URL: https://git.openjdk.java.net/jfx/commit/7e2cefba7f28fc0570b7495a08203756caa5327c Stats: 186 lines in 11 files chan

[jfx18] RFR: 8282099: Cherry-pick WebKit 613.1 stabilization fixes (2)

2022-04-13 Thread Johan Vos
Reviewed-by: kcr, jvos - Commit messages: - 8282099: Cherry-pick WebKit 613.1 stabilization fixes (2) Changes: https://git.openjdk.java.net/jfx/pull/774/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=774=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282099

[jfx18] Integrated: 8281711: Cherry-pick WebKit 613.1 stabilization fixes

2022-04-13 Thread Johan Vos
On Wed, 13 Apr 2022 15:22:22 GMT, Johan Vos wrote: > Stabilization fixes from WebKitGTK 2.34.5 > > Reviewed-by: jvos, kcr This pull request has now been integrated. Changeset: 0402975a Author: Johan Vos URL: https://git.openjdk.java.net/j

[jfx18] RFR: 8281711: Cherry-pick WebKit 613.1 stabilization fixes

2022-04-13 Thread Johan Vos
Stabilization fixes from WebKitGTK 2.34.5 Reviewed-by: jvos, kcr - Commit messages: - 8281711: Cherry-pick WebKit 613.1 stabilization fixes Changes: https://git.openjdk.java.net/jfx/pull/773/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=773=00 Issue:

[jfx18] Withdrawn: 8281711: Cherry-pick WebKit 613.1 stabilization fixes

2022-04-13 Thread Johan Vos
On Wed, 13 Apr 2022 14:15:29 GMT, Johan Vos wrote: > Stabilization fixes from WebKitGTK 2.34.5 > > Reviewed-by: jvos, kcr This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jfx/pull/772

[jfx18] RFR: 8281711: Cherry-pick WebKit 613.1 stabilization fixes

2022-04-13 Thread Johan Vos
Stabilization fixes from WebKitGTK 2.34.5 Reviewed-by: jvos, kcr - Commit messages: - 8281711: Cherry-pick WebKit 613.1 stabilization fixes Changes: https://git.openjdk.java.net/jfx/pull/772/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=772=00 Issue:

[jfx18] Integrated: 8281459: WebKit 613.1 build broken on M1

2022-04-13 Thread Johan Vos
On Wed, 13 Apr 2022 13:43:18 GMT, Johan Vos wrote: > Reviewed-by: kcr, jvos This pull request has now been integrated. Changeset: 1d74 Author: Johan Vos URL: https://git.openjdk.java.net/jfx/commit/1d74d01addf3b6481f0af7866c8454b6cfdf Stats: 20 lines in 1 file changed

[jfx18] RFR: 8281459: WebKit 613.1 build broken on M1

2022-04-13 Thread Johan Vos
Reviewed-by: kcr, jvos - Commit messages: - 8281459: WebKit 613.1 build broken on M1 Changes: https://git.openjdk.java.net/jfx/pull/771/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=771=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8281459 Stats: 20 lines in 1

[jfx18] Integrated: 8278980: Update WebKit to 613.1

2022-04-13 Thread Johan Vos
On Wed, 13 Apr 2022 12:35:18 GMT, Johan Vos wrote: > Co-authored-by: Ajit Ghaisas > Co-authored-by: Jay Bhaskar > Co-authored-by: Kevin Rushforth > Reviewed-by: kcr, jvos, aghaisas This pull request has now been integrated. Changeset: f19b57ae Author: Johan Vos URL:

[jfx18] RFR: 8278980: Update WebKit to 613.1

2022-04-13 Thread Johan Vos
Co-authored-by: Ajit Ghaisas Co-authored-by: Jay Bhaskar Co-authored-by: Kevin Rushforth Reviewed-by: kcr, jvos, aghaisas - Commit messages: - 8278980: Update WebKit to 613.1 Changes: https://git.openjdk.java.net/jfx/pull/770/files Webrev:

[jfx18] Integrated: 8284812: Change JavaFX release version in jfx18 branch to 18.0.1

2022-04-13 Thread Johan Vos
On Wed, 13 Apr 2022 08:59:45 GMT, Johan Vos wrote: > Update JavaFX release version to 18.0.1 in jfx18 branch This pull request has now been integrated. Changeset: 87cb6594 Author: Johan Vos URL: https://git.openjdk.java.net/jfx/commit/87cb65949c468774bd6973198e45bb3e372f52f3 St

Re: [jfx18] RFR: 8284812: Change JavaFX release version in jfx18 branch to 18.0.1 [v2]

2022-04-13 Thread Johan Vos
> Update JavaFX release version to 18.0.1 in jfx18 branch Johan Vos has updated the pull request incrementally with one additional commit since the last revision: Update version in .jcheck/conf to 18.0.1 - Changes: - all: https://git.openjdk.java.net/jfx/pull/769/files -

backport requests for 18.0.1

2022-04-13 Thread Johan Vos
Hi Kevin, I request approval to backport the following issues to the jfx18 branch, for JavaFX 18.0.1: JDK-8278980: Update WebKit to 613.1 JDK-8281459: WebKit 613.1 build broken on M1 JDK-8281711: Cherry-pick WebKit 613.1 stabilization fixes JDK-8282099: Cherry-pick WebKit 613.1 stabilization

[jfx18] RFR: 8284812: Change JavaFX release version in jfx18 branch to 18.0.1

2022-04-13 Thread Johan Vos
Update JavaFX release version to 18.0.1 in jfx18 branch - Commit messages: - Update JavaFX release version to 18.0.1 in jfx18 branch Changes: https://git.openjdk.java.net/jfx/pull/769/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=769=00 Issue:

Re: RFR: 8281564: Update cmake to 3.22.3

2022-04-05 Thread Johan Vos
On Tue, 5 Apr 2022 04:54:55 GMT, Ambarish Rapte wrote: > Update cmake to 3.22.3 > Verified build on all three platforms. > The sanity test looks good. Marked as reviewed by jvos (Reviewer). - PR: https://git.openjdk.java.net/jfx/pull/767

Re: RFR: 8283328: Update libxml2 to 2.9.13 [v2]

2022-04-01 Thread Johan Vos
On Fri, 1 Apr 2022 08:19:28 GMT, Hima Bindu Meda wrote: >> We currently use libxml2 version 2.9.12. It should be updated to latest >> stable release, which is version 2.9.13. >> The steps to update libxml are documented in UPDATING.txt. >> There is compilation issue with the release 2.9.13, as

Re: RFR: 8283328: Update libxml2 to 2.9.13 [v2]

2022-04-01 Thread Johan Vos
On Fri, 1 Apr 2022 08:19:28 GMT, Hima Bindu Meda wrote: >> We currently use libxml2 version 2.9.12. It should be updated to latest >> stable release, which is version 2.9.13. >> The steps to update libxml are documented in UPDATING.txt. >> There is compilation issue with the release 2.9.13, as

Re: RFR: 8277785: ListView scrollTo jumps to wrong location when CellHeight is changed [v3]

2022-03-30 Thread Johan Vos
On Fri, 25 Mar 2022 16:26:34 GMT, Kevin Rushforth wrote: > It looks like there are some failing unit tests now. I fixed them. - PR: https://git.openjdk.java.net/jfx/pull/712

Re: RFR: 8277785: ListView scrollTo jumps to wrong location when CellHeight is changed [v4]

2022-03-30 Thread Johan Vos
ediately resize the cell and sets the new value in the cache > containing the cellsizes. Johan Vos has updated the pull request incrementally with one additional commit since the last revision: Don't shift cells if we are already showing the lowest index cell. - Chang

Re: RFR: 8283402: Update to gcc 11.2 on Linux

2022-03-29 Thread Johan Vos
On Tue, 29 Mar 2022 11:50:32 GMT, Kevin Rushforth wrote: >> No, it will use whatever the latest is for GitHub actions. There doesn't >> seem to be an 11.2 package for GHA. It should be sufficient for most >> testing, but highlights one of the limitations of relying on GitHub Actions >> for

Re: RFR: 8283517: Update boot JDK to 18

2022-03-29 Thread Johan Vos
On Fri, 25 Mar 2022 12:16:18 GMT, Kevin Rushforth wrote: > JDK 18 has been released, so we should update the default boot JDK used to > build JavaFX to JDK 18. This will not affect the minimum boot JDK version. I > have confirmed that gradle 7.3 works with JDK 18, so we don't need to update >

Re: RFR: 8283402: Update to gcc 11.2 on Linux

2022-03-29 Thread Johan Vos
On Fri, 25 Mar 2022 12:19:10 GMT, Kevin Rushforth wrote: > This patch updates the compiler to gcc 11.2 on Linux, in order to match JDK > 17 -- see [JDK-8283057](https://bugs.openjdk.java.net/browse/JDK-8283057). > > I ran a full build and test, including media and WebKit.

Re: RFR: 8280369: native library cache should be platform/arch specific

2022-03-29 Thread Johan Vos
On Fri, 25 Mar 2022 18:12:23 GMT, Glavo wrote: > Currently, OpenJFX extracts the native library into a local folder and loads > it when it is not part of the JRE. > > Now we have a notable problem with the fact that a platform may actually run > programs of multiple CPU architectures. > >

Re: RFR: 8280369: native library cache should be platform/arch specific

2022-03-29 Thread Johan Vos
On Fri, 25 Mar 2022 18:12:23 GMT, Glavo wrote: > Currently, OpenJFX extracts the native library into a local folder and loads > it when it is not part of the JRE. > > Now we have a notable problem with the fact that a platform may actually run > programs of multiple CPU architectures. > >

Re: RFR: 8277785: ListView scrollTo jumps to wrong location when CellHeight is changed [v2]

2022-03-24 Thread Johan Vos
On Tue, 22 Mar 2022 08:47:42 GMT, Johan Vos wrote: >> When the size of a ListCell is changed and a scrollTo method is invoked >> without having a layout calculation in between, the old (wrong) size is used >> to calculcate the total estimate. This happens e.g. when t

Re: RFR: 8277785: ListView scrollTo jumps to wrong location when CellHeight is changed [v3]

2022-03-24 Thread Johan Vos
ediately resize the cell and sets the new value in the cache > containing the cellsizes. Johan Vos has updated the pull request incrementally with one additional commit since the last revision: Add test to check if there are no empty cells at the end of a List in case there are en

Re: RFR: 8277309: Add support for H.265/HEVC to HTTP Live Streaming [v3]

2022-03-23 Thread Johan Vos
On Fri, 18 Mar 2022 02:20:11 GMT, Alexander Matveev wrote: >> - Added support for fragmented MP4 with HEVC/H.265, H.264 and AAC. >> - Added support for elementary AAC streams without any container for audio >> only streams. >> - Added "aacparse" plugin from GStreamer. Required on Linux,

Re: RFR: 8277309: Add support for H.265/HEVC to HTTP Live Streaming [v3]

2022-03-22 Thread Johan Vos
On Fri, 18 Mar 2022 02:20:11 GMT, Alexander Matveev wrote: >> - Added support for fragmented MP4 with HEVC/H.265, H.264 and AAC. >> - Added support for elementary AAC streams without any container for audio >> only streams. >> - Added "aacparse" plugin from GStreamer. Required on Linux,

Re: RFR: 8277785: ListView scrollTo jumps to wrong location when CellHeight is changed [v2]

2022-03-22 Thread Johan Vos
ediately resize the cell and sets the new value in the cache > containing the cellsizes. Johan Vos has updated the pull request incrementally with one additional commit since the last revision: Add the option to shift all cells down in case the current calculations would lead to empt

[jfx11u] Integrated: 8203463: [Accessibility, Narrator] NPE in TableView

2022-03-18 Thread Johan Vos
On Thu, 17 Mar 2022 20:56:32 GMT, Johan Vos wrote: > Reviewed-by: kcr This pull request has now been integrated. Changeset: bf32dd8a Author: Johan Vos URL: https://git.openjdk.java.net/jfx11u/commit/bf32dd8a52876b0c0a53e9f73d64b0a986829626 Stats: 1 line in 1 file changed: 1

[jfx17u] Integrated: 8197991: Selecting many items in a TableView is very slow

2022-03-18 Thread Johan Vos
On Fri, 18 Mar 2022 07:42:37 GMT, Johan Vos wrote: > Co-authored-by: Naohiro Yoshimoto > Reviewed-by: kcr, aghaisas This pull request has now been integrated. Changeset: 4af7ee97 Author: Johan Vos URL: https://git.openjdk.java.net/jfx17u/

[jfx17u] Integrated: 8203463: [Accessibility, Narrator] NPE in TableView

2022-03-18 Thread Johan Vos
On Fri, 18 Mar 2022 07:42:11 GMT, Johan Vos wrote: > Reviewed-by: kcr This pull request has now been integrated. Changeset: 53d443bf Author: Johan Vos URL: https://git.openjdk.java.net/jfx17u/commit/53d443bffa34c971c7c6192649caa9aba2acb5f5 Stats: 1 line in 1 file changed: 1

[jfx11u] Integrated: 8197991: Selecting many items in a TableView is very slow

2022-03-18 Thread Johan Vos
On Thu, 17 Mar 2022 21:01:51 GMT, Johan Vos wrote: > Co-authored-by: Naohiro Yoshimoto > Reviewed-by: kcr, aghaisas This pull request has now been integrated. Changeset: 1c3d9666 Author: Johan Vos URL: https://git.openjdk.java.net/jfx11u/

[jfx17u] RFR: 8197991: Selecting many items in a TableView is very slow

2022-03-18 Thread Johan Vos
Co-authored-by: Naohiro Yoshimoto Reviewed-by: kcr, aghaisas - Commit messages: - 8197991: Selecting many items in a TableView is very slow Changes: https://git.openjdk.java.net/jfx17u/pull/39/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx17u=39=00 Issue:

[jfx17u] RFR: 8203463: [Accessibility, Narrator] NPE in TableView

2022-03-18 Thread Johan Vos
Reviewed-by: kcr - Commit messages: - 8203463: [Accessibility, Narrator] NPE in TableView Changes: https://git.openjdk.java.net/jfx17u/pull/38/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx17u=38=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8203463 Stats: 1

[jfx11u] RFR: 8197991: Selecting many items in a TableView is very slow

2022-03-17 Thread Johan Vos
Co-authored-by: Naohiro Yoshimoto Reviewed-by: kcr, aghaisas - Commit messages: - 8197991: Selecting many items in a TableView is very slow Changes: https://git.openjdk.java.net/jfx11u/pull/82/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u=82=00 Issue:

[jfx11u] RFR: 8203463: [Accessibility, Narrator] NPE in TableView

2022-03-17 Thread Johan Vos
Reviewed-by: kcr - Commit messages: - 8203463: [Accessibility, Narrator] NPE in TableView Changes: https://git.openjdk.java.net/jfx11u/pull/81/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u=81=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8203463 Stats: 1

Re: RFR: 8283183: Skip failing PredefinedMeshManagerTest tests

2022-03-16 Thread Johan Vos
On Tue, 15 Mar 2022 18:50:15 GMT, Kevin Rushforth wrote: > We continue to get intermittent test failures in `PredefinedMeshManagerTest` > due to an OOM error. See the GitHub Actions run for [PR > 753](https://github.com/openjdk/jfx/pull/753/checks?check_run_id=5559141397) > for a recent

Re: RFR: 8283183: Skip failing PredefinedMeshManagerTest tests

2022-03-15 Thread Johan Vos
On Tue, 15 Mar 2022 18:50:15 GMT, Kevin Rushforth wrote: > We continue to get intermittent test failures in `PredefinedMeshManagerTest` > due to an OOM error. See the GitHub Actions run for [PR > 753](https://github.com/openjdk/jfx/pull/753/checks?check_run_id=5559141397) > for a recent

Re: [jfx18] RFR: 8282766: Create release notes for JavaFX 18 [v2]

2022-03-14 Thread Johan Vos
On Sun, 13 Mar 2022 10:07:26 GMT, Abhinay Agarwal wrote: >> Add release notes for JavaFX 18 to the repository > > Abhinay Agarwal has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains two commits: > > - s/Enhancement/Enhancements > -

Re: RFR: 8282099: Cherry-pick WebKit 613.1 stabilization fixes (2)

2022-02-22 Thread Johan Vos
On Tue, 22 Feb 2022 17:15:19 GMT, Ambarish Rapte wrote: > Include additional stabilization fixes of WebKit 613.1 > Sanity testing did not show any concerns. Ok on mac/linux/win x86_64 and on linux aarch64 - Marked as reviewed by jvos (Reviewer). PR:

Re: RFR: 8282099: Cherry-pick WebKit 613.1 stabilization fixes (2)

2022-02-22 Thread Johan Vos
On Tue, 22 Feb 2022 17:15:19 GMT, Ambarish Rapte wrote: > Include additional stabilization fixes of WebKit 613.1 > Sanity testing did not show any concerns. I notice changes specific to AArch64 and Linux, so I did a testbuild on Linux AArch64 which was successful. Will test the

Re: RFR: 8281711: Cherry-pick WebKit 613.1 stabilization fixes [v2]

2022-02-17 Thread Johan Vos
On Wed, 16 Feb 2022 13:08:04 GMT, Ambarish Rapte wrote: >> Include additional stabilization fixes of WebKit 613.1 >> Sanity testing did not show any concerns. > > Ambarish Rapte has updated the pull request incrementally with one additional > commit since the last revision: > > correct

Re: RFR: 8281711: Cherry-pick WebKit 613.1 stabilization fixes [v2]

2022-02-17 Thread Johan Vos
On Wed, 16 Feb 2022 13:08:04 GMT, Ambarish Rapte wrote: >> Include additional stabilization fixes of WebKit 613.1 >> Sanity testing did not show any concerns. > > Ambarish Rapte has updated the pull request incrementally with one additional > commit since the last revision: > > correct

Re: RFR: 8281459: WebKit 613.1 build broken on M1

2022-02-10 Thread Johan Vos
On Wed, 9 Feb 2022 19:14:47 GMT, Ambarish Rapte wrote: > This seems like a bad merge issue. > There were duplicate copies of four methods in `MacroAssemblerARM64.h` which > caused WebKit build failure on Mac M1 machines. > Just removing the methods removes the error. > With the changes in

Re: RFR: 8281459: WebKit 613.1 build broken on M1

2022-02-09 Thread Johan Vos
On Wed, 9 Feb 2022 19:14:47 GMT, Ambarish Rapte wrote: > This seems like a bad merge issue. > There were duplicate copies of four methods in `MacroAssemblerARM64.h` which > caused WebKit build failure on Mac M1 machines. > Just removing the methods removes the error. > With the changes in

Re: JavaFX with Python/JS

2022-02-07 Thread Johan Vos
Hi Thiago, Yes, that is possible, and I've done that years ago with some simple python code, that resulted in a array of numbers that can then be visualised with JavaFX. It is really cool indeed, but back then the Python support was limited (e.g. no numpy). As for huge marketing opportunity: the

Re: RFR: 8278980: Update WebKit to 613.1 [v2]

2022-02-04 Thread Johan Vos
On Wed, 2 Feb 2022 15:29:51 GMT, Ambarish Rapte wrote: >> Update JavaFX WebKit to GTK WebKit 2.34 (613.1). >> >> Verified the updated version build, tests run and sanity testing. >> This does not cause any issues except a unit test failure >> `IrresponsiveScriptTest`. >> It is recorded and

Re: RFR: 8278980: Update WebKit to 613.1

2022-02-02 Thread Johan Vos
Hi Kevin, Thanks for filing [JDK-8281089]. I think this is the way forward indeed. The longer we delay moving to VS 2019, the more problems we can expect. I'll build/test the WebKit 613.1 as well. - Johan On Wed, Feb 2, 2022 at 1:49 PM Kevin Rushforth wrote: > On Wed, 2 Feb 2022 07:34:55 GMT,

Re: RFR: 8279013 : ES2Pipeline fails to detect AMD vega20 graphics card

2022-01-25 Thread Johan Vos
On Mon, 20 Dec 2021 17:48:19 GMT, Paul wrote: > I have an AMD Radeon VII (vega20) series GPU which is identifying with a > vendor string of "AMD". > > This is not present in the `X11GLFactory` list of `preQualificationFilter` > vendor names, so my system (and probably any other vega20 based

Re: [jfx11u] RFR: 8280489: Change JavaFX release version in jfx11u to 11.0.15

2022-01-25 Thread Johan Vos
On Tue, 25 Jan 2022 01:20:04 GMT, Kevin Rushforth wrote: > Bump release version in `jfx11u` repo to 11.0.15 for the start of a new > release. Marked as reviewed by jvos (Reviewer). - PR: https://git.openjdk.java.net/jfx11u/pull/69

Re: [jfx17u] RFR: 8280490: Change JavaFX release version in jfx17u to 17.0.3

2022-01-25 Thread Johan Vos
On Tue, 25 Jan 2022 01:19:11 GMT, Kevin Rushforth wrote: > Bump release version in `jfx17u` repo to 17.0.3 for the start of a new > release. Marked as reviewed by jvos (Reviewer). - PR: https://git.openjdk.java.net/jfx17u/pull/29

Re: The openjfx native library cache path should be platform dependent

2022-01-20 Thread Johan Vos
That sounds correct indeed. I filed https://bugs.openjdk.java.net/browse/JDK-8280369 for this. Thanks for reporting! - Johan On Thu, Jan 20, 2022 at 6:14 AM Glavo wrote: > I noticed that openjfx packaged in jar caches native libraries in > ~/.openjfx/cache/${version}, it is not related to the

Re: [jfx17u, jfx11u] RFR: Request to backport January 2022 CPU changes

2022-01-18 Thread Johan Vos
Approved Op di 18 jan. 2022 om 18:25 schreef Kevin Rushforth < kevin.rushfo...@oracle.com>: > Hi Johan, > > I request approval to backport the changes from the just-released > January 2022 CPU to jfx17u (for 17.0.2) and to jfx11u (for 11.0.14) . > >

Re: [jfx18] RFR: Request to sync January 2022 changes into jfx

2022-01-18 Thread Johan Vos
Approved. Op di 18 jan. 2022 om 18:25 schreef Kevin Rushforth < kevin.rushfo...@oracle.com>: > Hi Johan, > > I request approval to sync changes from to the just-released January > 2022 CPU release into the 'jfx18' branch of the 'jfx' repo. Here is the > aggregate set of changes for the fixes: >

Re: [jfx18] RFR: 8273998: Clarify specification for Window properties controlled by the window manager

2022-01-13 Thread Johan Vos
On Fri, 7 Jan 2022 18:19:23 GMT, Kevin Rushforth wrote: > Update the API specification for the `Window` and `Stage` classes to clarify > that the values for some properties and methods can be changed or ignored by > the platform. Several of the properties already have a comment to the effect

Re: RFR: 8273998: Clarify specification for Window properties controlled by the window manager

2022-01-13 Thread Johan Vos
On Fri, 7 Jan 2022 18:19:23 GMT, Kevin Rushforth wrote: > Update the API specification for the `Window` and `Stage` classes to clarify > that the values for some properties and methods can be changed or ignored by > the platform. Several of the properties already have a comment to the effect

Re: RFR: 8274066: Polygon filled outside its area when very large coordinates are used [v2]

2022-01-13 Thread Johan Vos
On Mon, 10 Jan 2022 00:04:00 GMT, Laurent Bourgès wrote: >> Changelog for this MarlinFX 0.9.4.5 release: >> >> The Marlin-renderer 0.9.4.5 release provides bug fixes on Marlin's path >> clipper: >> - improved Stroker to handle huge coordinates, up to 1E15 >> - improved PathClipFilter (filler)

Re: RFR: 8242544: CMD+ENTER key event crashes the application when invoked on dialog

2022-01-12 Thread Johan Vos
On Tue, 11 Jan 2022 22:18:53 GMT, Martin Fox wrote: > The OS crashes if the contentView of a window is set to nil while handling > processKeyEquivalent. With this PR we just set the contentView to a basic > do-nothing NSView for the interim. This looks good with the current tools/OS

Re: RFR: 8273998: Clarify specification for Window properties controlled by the window manager

2022-01-10 Thread Johan Vos
On Fri, 7 Jan 2022 18:19:23 GMT, Kevin Rushforth wrote: > Update the API specification for the `Window` and `Stage` classes to clarify > that the values for some properties and methods can be changed or ignored by > the platform. Several of the properties already have a comment to the effect

RFR: 8277785: ListView scrollTo jumps to wrong location when CellHeight is changed

2022-01-09 Thread Johan Vos
When the size of a ListCell is changed and a scrollTo method is invoked without having a layout calculation in between, the old (wrong) size is used to calculcate the total estimate. This happens e.g. when the size is changed in the `updateItem` method. This PR will immediately resize the cell

Re: RFR: 8279615: Change JavaFX release version to 19

2022-01-07 Thread Johan Vos
On Fri, 7 Jan 2022 12:55:33 GMT, Kevin Rushforth wrote: > Bump the version number of JavaFX to 19. I will integrate this immediately > after forking the `jfx18` stabilization branch, which is scheduled for > Thursday, January 13, 2022 at 16:00 UTC. ok (once 18 is branched) -

Re: RFR: 8274066: Polygon filled outside its area when very large coordinates are used

2022-01-07 Thread Johan Vos
On Wed, 17 Nov 2021 22:05:25 GMT, Laurent Bourgès wrote: > Draft PR to see how big is the MarlinFX 0.9.4.5 patch (DPQS, Path clipper > fixes to handle huge coords) @bourgesl can you rename the title of this PR to 8274066: Polygon filled outside its area when very large coordinates are used

Re: [jfx17u] RFR: 8279396: Define version in .jcheck/conf

2022-01-04 Thread Johan Vos
On Tue, 4 Jan 2022 16:39:00 GMT, Kevin Rushforth wrote: > Backport fix to add `version` property to `.jcheck/conf`. This is needed in > support of a Skara bot config change to take the fix version from the repo. Marked as reviewed by jvos (Reviewer). - PR:

Re: [jfx11u] RFR: 8279396: Define version in .jcheck/conf

2022-01-04 Thread Johan Vos
On Tue, 4 Jan 2022 16:45:52 GMT, Kevin Rushforth wrote: > Backport fix to add `version` property to `.jcheck/conf`. This is needed in > support of a Skara bot config change to take the fix version from the repo. > > NOTE: the `UPDATING-version.md` file was not present in the repo. I copied it

  1   2   3   4   5   6   7   8   9   10   >