Re: RFR: 8284654: Modal behavior returns to wrong stage [v3]

2022-05-31 Thread Kevin Rushforth
On Tue, 10 May 2022 12:56:53 GMT, Thiago Milczarek Sayao wrote: >> When there's an APPLICATION_MODAL window, all other windows are disabled and >> re-enabled when the APPLICATION_MODAL window closes. This causes >> `requestToFront()` to be called on every window, and it does not guarantee >>

Re: RFR: 8274066: Polygon filled outside its area when very large coordinates are used [v2]

2022-05-31 Thread Kevin Rushforth
On Wed, 25 May 2022 07:37:38 GMT, Laurent Bourgès wrote: > keep dpqs for corner cases and keep my coding life simple I think this approach is fine. Diverging the code would likely make it less stable, and you answered the question about the provenance of the code, so there's no issue there.

Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v14]

2022-05-27 Thread Kevin Rushforth
On Tue, 22 Mar 2022 07:46:40 GMT, John Hendrikx wrote: >> This is an implementation of the proposal in >> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker >> (@nlisker) have been working on. It's a complete implementation including >> good test coverage. >> >> This

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v9]

2022-05-27 Thread Kevin Rushforth
On Fri, 27 May 2022 16:47:04 GMT, Jay Bhaskar wrote: >> This PR is new implementation of JavaEvent listener memory management. >> Issue >> [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) >> >> 1. Calling remove event listener does not free jni global references. >>

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v8]

2022-05-27 Thread Kevin Rushforth
On Fri, 27 May 2022 12:13:43 GMT, Jay Bhaskar wrote: >> This PR is new implementation of JavaEvent listener memory management. >> Issue >> [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) >> >> 1. Calling remove event listener does not free jni global references. >>

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v7]

2022-05-26 Thread Kevin Rushforth
On Thu, 26 May 2022 07:26:38 GMT, Jay Bhaskar wrote: >> This PR is new implementation of JavaEvent listener memory management. >> Issue >> [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) >> >> 1. Calling remove event listener does not free jni global references. >>

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v4]

2022-05-25 Thread Kevin Rushforth
On Tue, 24 May 2022 15:20:01 GMT, Kevin Rushforth wrote: >> Jay Bhaskar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Adding JGObject in plave of raw jni object > > modules/javafx.web/src/t

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v4]

2022-05-25 Thread Kevin Rushforth
On Sun, 22 May 2022 14:06:41 GMT, Jay Bhaskar wrote: >> This PR is new implementation of JavaEvent listener memory management. >> Issue >> [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) >> >> 1. Calling remove event listener does not free jni global references. >>

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v5]

2022-05-25 Thread Kevin Rushforth
On Wed, 25 May 2022 10:10:08 GMT, Jay Bhaskar wrote: >> This PR is new implementation of JavaEvent listener memory management. >> Issue >> [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) >> >> 1. Calling remove event listener does not free jni global references. >>

Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v14]

2022-05-24 Thread Kevin Rushforth
On Tue, 22 Mar 2022 07:46:40 GMT, John Hendrikx wrote: >> This is an implementation of the proposal in >> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker >> (@nlisker) have been working on. It's a complete implementation including >> good test coverage. >> >> This

[jfx17u] Integrated: 8283869: Update attribution in webkit.md file

2022-05-24 Thread Kevin Rushforth
On Tue, 24 May 2022 17:34:25 GMT, Kevin Rushforth wrote: > Clean backport to `jfx17u`. This pull request has now been integrated. Changeset: 1835d1f5 Author: Kevin Rushforth URL: https://git.openjdk.java.net/jfx17u/commit/1835d1f59104136d6cb34090bd69091433ddac00 Stats: 5

[jfx17u] Integrated: 8286256: Update libxml2 to 2.9.14

2022-05-24 Thread Kevin Rushforth
On Tue, 24 May 2022 17:33:57 GMT, Kevin Rushforth wrote: > Clean backport to `jfx17u`. This pull request has now been integrated. Changeset: 7b1637f8 Author: Kevin Rushforth URL: https://git.openjdk.java.net/jfx17u/commit/7b1637f8f617639ddc0c93e15589824c6a0d71b1 Stats: 21

[jfx11u] Integrated: 8283869: Update attribution in webkit.md file

2022-05-24 Thread Kevin Rushforth
On Tue, 24 May 2022 17:31:58 GMT, Kevin Rushforth wrote: > Clean backport to `jfx11u`. This pull request has now been integrated. Changeset: f89a5139 Author: Kevin Rushforth URL: https://git.openjdk.java.net/jfx11u/commit/f89a513980c2c2637c4f3d2b80f0708fd6f9e252 Stats: 5

[jfx11u] Integrated: 8283869: Update attribution in webkit.md file

2022-05-24 Thread Kevin Rushforth
Clean backport to `jfx11u`. - Commit messages: - 8283869: Update attribution in webkit.md file Changes: https://git.openjdk.java.net/jfx11u/pull/102/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u=102=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8283869

[jfx11u] Integrated: 8286256: Update libxml2 to 2.9.14

2022-05-24 Thread Kevin Rushforth
Clean backport to `jfx11u`. - Commit messages: - 8286256: Update libxml2 to 2.9.14 Changes: https://git.openjdk.java.net/jfx11u/pull/101/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u=101=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8286256 Stats: 21664

[jfx11u] Integrated: 8286256: Update libxml2 to 2.9.14

2022-05-24 Thread Kevin Rushforth
On Tue, 24 May 2022 17:31:27 GMT, Kevin Rushforth wrote: > Clean backport to `jfx11u`. This pull request has now been integrated. Changeset: 8504dad2 Author: Kevin Rushforth URL: https://git.openjdk.java.net/jfx11u/commit/8504dad26ac0f0dcbf7cb62ac58642dc8a91f02e Stats: 21

[jfx17u] RFR: 8283869: Update attribution in webkit.md file

2022-05-24 Thread Kevin Rushforth
Clean backport to `jfx17u`. - Commit messages: - 8283869: Update attribution in webkit.md file Changes: https://git.openjdk.java.net/jfx17u/pull/62/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx17u=62=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8283869 Stats:

[jfx17u] RFR: 8286256: Update libxml2 to 2.9.14

2022-05-24 Thread Kevin Rushforth
Clean backport to `jfx17u`. - Commit messages: - 8286256: Update libxml2 to 2.9.14 Changes: https://git.openjdk.java.net/jfx17u/pull/61/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx17u=61=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8286256 Stats: 21664 lines

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v4]

2022-05-24 Thread Kevin Rushforth
On Sun, 22 May 2022 14:06:41 GMT, Jay Bhaskar wrote: >> This PR is new implementation of JavaEvent listener memory management. >> Issue >> [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) >> >> 1. Calling remove event listener does not free jni global references. >>

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v2]

2022-05-20 Thread Kevin Rushforth
On Thu, 19 May 2022 22:01:31 GMT, Kevin Rushforth wrote: >> Jay Bhaskar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Platform.exit() , removing code block, as it is causing other test fail > > modules

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v2]

2022-05-19 Thread Kevin Rushforth
On Thu, 19 May 2022 15:57:46 GMT, Jay Bhaskar wrote: >> This PR is new implementation of JavaEvent listener memory management. >> Issue >> [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) >> >> 1. Calling remove event listener does not free jni global references. >>

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener

2022-05-19 Thread Kevin Rushforth
On Thu, 19 May 2022 13:13:01 GMT, Jay Bhaskar wrote: > This PR is new implementation of JavaEvent listener memory management. > Issue > [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) > > 1. Calling remove event listener does not free jni global references. > 2. When

Re: RFR: 8090522: Allow support for disabling stage iconification (minimization)

2022-05-19 Thread Kevin Rushforth
On Thu, 19 May 2022 12:44:44 GMT, Paweł Kruszczyński wrote: > `Stage` minimalizing (iconified state) cannot be disabled for the user. The > same for `Stage` closable state. > PR adds these features without breaking backward compatibility. Marking this as "Draft" since it is not ready for

Re: RFR: 8090522: Allow support for disabling stage iconification (minimization)

2022-05-19 Thread Kevin Rushforth
On Thu, 19 May 2022 12:44:44 GMT, Paweł Kruszczyński wrote: > `Stage` minimalizing (iconified state) cannot be disabled for the user. The > same for `Stage` closable state. > PR adds these features without breaking backward compatibility. @xardif It is premature to review this PR. Please read

Re: RFR: 8286867: Update #getGlyphCode return a negative number

2022-05-18 Thread Kevin Rushforth
On Tue, 17 May 2022 13:08:10 GMT, Tomator wrote: > Hello,i have signed oca ,and pull /signed command ,so I'm just wait for OCA > to pass? Yes, at this point you wait for your OCA to be processed. - PR: https://git.openjdk.java.net/jfx/pull/795

Re: RFR: 8286867: Update #getGlyphCode return a negative number

2022-05-18 Thread Kevin Rushforth
On Fri, 13 May 2022 12:21:32 GMT, Kevin Rushforth wrote: > * Submit a bug report with a test case at > [bugreport.java.com](https://bugreport.java.com/) I see that you already have submitted a bug report. You should get an email when it is made public. - PR:

Re: RFR: 8286867: Update #getGlyphCode return a negative number

2022-05-18 Thread Kevin Rushforth
On Fri, 13 May 2022 05:36:03 GMT, Tomator wrote: >> When I used BlueJ, I found a problem with Chinese display. >> /javafx.graphics/com/sun/javafx/font/CompositeGlyphMapper.java#getGlyphCode >> may return a negative number when no font library is specified in Linux,and >> this could cause

Re: RFR: JDK-8286256 : Update libxml2 to 2.9.14 [v4]

2022-05-18 Thread Kevin Rushforth
On Wed, 18 May 2022 13:39:12 GMT, Hima Bindu Meda wrote: >> Updated libxml to version 2.9.14.As mentioned in UPDATING.txt, configured >> for windows , linux and Mac platforms and updated the files accordingly. >> >> Updated libxslt to version 1.1.35. Generated the config.h files for windows

Re: RFR: JDK-8286256 : Update libxml2 to 2.9.14 [v3]

2022-05-18 Thread Kevin Rushforth
On Wed, 18 May 2022 07:26:56 GMT, Hima Bindu Meda wrote: >> Updated libxml to version 2.9.14.As mentioned in UPDATING.txt, configured >> for windows , linux and Mac platforms and updated the files accordingly. >> >> Updated libxslt to version 1.1.35. Generated the config.h files for windows

Re: RFR: JDK-8286256 : Update libxml2 to 2.9.14 [v2]

2022-05-18 Thread Kevin Rushforth
On Tue, 17 May 2022 17:25:16 GMT, Kevin Rushforth wrote: >> Hima Bindu Meda has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add UPDATING.txt for libxslt update > > modules/javafx.web/src/main/native/S

Re: RFR: JDK-8286256 : Update libxml2 to 2.9.14 [v3]

2022-05-18 Thread Kevin Rushforth
On Wed, 18 May 2022 07:26:56 GMT, Hima Bindu Meda wrote: >> Updated libxml to version 2.9.14.As mentioned in UPDATING.txt, configured >> for windows , linux and Mac platforms and updated the files accordingly. >> >> Updated libxslt to version 1.1.35. Generated the config.h files for windows

Re: Looked-up color fails for -fx-background-color in JavaFX CSS file

2022-05-18 Thread Kevin Rushforth
Hi Davide, Are you referring to https://bugs.openjdk.java.net/browse/JDK-8268657 ? I just tried it again, and it works fine for me. -- Kevin On 5/18/2022 4:12 AM, Davide Perini wrote: Hi all, someone else opened an issue in past on this problem. I have the exact same problem:

Re: RFR: JDK-8286256 : Update libxml2 to 2.9.14 [v2]

2022-05-17 Thread Kevin Rushforth
On Tue, 17 May 2022 17:06:51 GMT, Hima Bindu Meda wrote: >> Updated libxml to version 2.9.14.As mentioned in UPDATING.txt, configured >> for windows , linux and Mac platforms and updated the files accordingly. >> >> Updated libxslt to version 1.1.35. Generated the config.h files for windows

Re: RFR: 8284665: First selected item of a TreeItem multiple selection gets removed if new items are constantly added to the TreeTableView

2022-05-14 Thread Kevin Rushforth
On Thu, 5 May 2022 16:21:45 GMT, Jose Pereda wrote: > This PR fixes an issue with selection of multiple items in TableView and > TreeTableView controls that gets moved unexpectedly when new items are added > even way below the selected items. > > A couple of tests have been added. They fail

Re: RFR: 8286552: TextFormatter: UpdateValue/UpdateText is called, when no ValueConverter is set [v2]

2022-05-13 Thread Kevin Rushforth
On Fri, 13 May 2022 08:28:50 GMT, Marius Hanl wrote: >> A common reason for using the `TextFormatter` is the need for a `filter`. >> Therefore, the following constructor is typically used: >> `public TextFormatter(@NamedArg("filter") UnaryOperator filter) { >> ... }` >> >> With that, no

Re: RFR: 8181084: JavaFX show big icons in system menu on macOS with Retina display [v3]

2022-05-12 Thread Kevin Rushforth
On Sun, 8 May 2022 06:31:49 GMT, Paul wrote: >> I hit on JDK-8181084 while making some changes to Scene Builder, so I >> decided to investigate. >> >> Please note: I have not done any Objective-C or MacOS development before. So >> I would really like some feedback from someone else who knows

Re: RFR: 8286552: TextFormatter: UpdateValue/UpdateText is called, when no ValueConverter is set

2022-05-12 Thread Kevin Rushforth
On Tue, 10 May 2022 20:03:08 GMT, Marius Hanl wrote: > A common reason for using the `TextFormatter` is the need for a `filter`. > Therefore, the following constructor is typically used: > `public TextFormatter(@NamedArg("filter") UnaryOperator filter) { ... > }` > > With that, no

[jfx17u] Integrated: 8283218: Update GStreamer to 1.20.1

2022-05-12 Thread Kevin Rushforth
On Mon, 9 May 2022 21:07:39 GMT, Kevin Rushforth wrote: > Almost clean backport to `jfx17u`. Tested in connection with libffi update in > the `test-kcr-17.0.4` branch. > > The only difference from the mainline patch is that the following file is not > present in `jfx17u

[jfx17u] Integrated: 8280840: Update libFFI to 3.4.2

2022-05-12 Thread Kevin Rushforth
On Mon, 9 May 2022 21:05:17 GMT, Kevin Rushforth wrote: > Clean backport to `jfx17u`. Tested in connection with gstreamer / glib update > in the `test-kcr-17.0.4` branch. This pull request has now been integrated. Changeset: 1c376ebd Author: Kevin Rushforth URL:

Re: What can I do with the GStreamer bundled in JavaFX? Can I record the screen?

2022-05-11 Thread Kevin Rushforth
GStreamer is used by the JavaFX media API. It is an implementation detail, and is not exposed. There are no media capture APIs, although that is something we have considered providing in the future. -- Kevin On 5/10/2022 1:02 PM, Davide Perini wrote: Hi all, I haven't understood what part

Integrated: 8283869: Update attribution in webkit.md file

2022-05-10 Thread Kevin Rushforth
On Tue, 10 May 2022 16:37:57 GMT, Kevin Rushforth wrote: > Doc-only change to update the license attribution in our `webkit.md` file. This pull request has now been integrated. Changeset: 7bb48194 Author: Kevin Rushforth URL: https://git.openjdk.java.net/jfx/com

RFR: 8283869: Update attribution in webkit.md file

2022-05-10 Thread Kevin Rushforth
Doc-only change to update the license attribution in our `webkit.md` file. - Commit messages: - 8283869: Update attribution in webkit.md file Changes: https://git.openjdk.java.net/jfx/pull/793/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=793=00 Issue:

Re: [jfx17u] RFR: 8283218: Update GStreamer to 1.20.1

2022-05-10 Thread Kevin Rushforth
On Mon, 9 May 2022 21:07:39 GMT, Kevin Rushforth wrote: > Almost clean backport to `jfx17u`. Tested in connection with libffi update in > the `test-kcr-17.0.4` branch. > > The only difference from the mainline patch is that the following file is not > present in `jfx17u

[jfx17u] Integrated: 8280275: JUnit5 tests using Assumptions API fail to compile in some cases

2022-05-10 Thread Kevin Rushforth
On Mon, 9 May 2022 21:20:29 GMT, Kevin Rushforth wrote: > This PR is dependent on #58 so it is in Draft for now. Once #58 is > integrated, I will rebase this and submit it, at which time it will be a > clean backport, and the diffs will only show the updated test and build

[jfx17u] RFR: 8280275: JUnit5 tests using Assumptions API fail to compile in some cases

2022-05-10 Thread Kevin Rushforth
This PR is dependent on #58 so it is in Draft for now. Once #58 is integrated, I will rebase this and submit it, at which time it will be a clean backport, and the diffs will only show the updated test and build changes associated with just this fix. - Commit messages: - 8280275:

[jfx17u] Integrated: 8276142: Update gradle to version 7.3

2022-05-10 Thread Kevin Rushforth
On Mon, 9 May 2022 21:14:23 GMT, Kevin Rushforth wrote: > Clean backport to `jfx17u`. This pull request has now been integrated. Changeset: be207ddb Author: Kevin Rushforth URL: https://git.openjdk.java.net/jfx17u/commit/be207ddb7249b369a028bc6fb6985adda7841648 Stats: 227 li

[jfx17u] Integrated: 8276174: JavaFX build fails on macOS aarch64

2022-05-10 Thread Kevin Rushforth
On Mon, 9 May 2022 21:22:04 GMT, Kevin Rushforth wrote: > Clean backport to `jfx17u` so we can build on macOS / aarch64 without needing > to specify `-PCOMPILE_TARGET=arm64`. This pull request has now been integrated. Changeset: a5edae13 Author: Kevin Rushforth URL:

[jfx17u] Integrated: 8273998: Clarify specification for Window properties controlled by the window manager

2022-05-10 Thread Kevin Rushforth
On Mon, 9 May 2022 21:15:34 GMT, Kevin Rushforth wrote: > Clean backport to `jfx17u`. This pull request has now been integrated. Changeset: bdb8d28e Author: Kevin Rushforth URL: https://git.openjdk.java.net/jfx17u/commit/bdb8d28ecc7bb10278a9a8385da79b5f5652bb09 Stats: 84 li

[jfx17u] Integrated: 8274274: Update JUnit to version 5.8.1

2022-05-10 Thread Kevin Rushforth
On Mon, 9 May 2022 21:18:07 GMT, Kevin Rushforth wrote: > Clean backport to `jfx17u`. This pull request has now been integrated. Changeset: 2ab0e82e Author: Kevin Rushforth URL: https://git.openjdk.java.net/jfx17u/commit/2ab0e82ee9cf2516b32914e2df4725becf8a2664 Stats: 161 li

[jfx17u] Integrated: 8281564: Update cmake to 3.22.3

2022-05-10 Thread Kevin Rushforth
On Mon, 9 May 2022 21:13:07 GMT, Kevin Rushforth wrote: > Clean backport to `jfx17u`. Tested along with the rest of the fixes in the > `test-kcr-17.0.4` branch. This pull request has now been integrated. Changeset: 684c80fc Author: Kevin Rushforth URL: https://git.openjdk.ja

Proposed schedule for JavaFX 19

2022-05-09 Thread Kevin Rushforth
Here is the proposed schedule for JavaFX 19. RDP1: Jul 14, 2022 (aka “feature freeze”) RDP2: Aug 4, 2022 Freeze: Aug 25, 2022 GA: Sep 13, 2022 We plan to fork a jfx19 stabilization branch at RDP1. The GA date is one week ahead of JDK 19, matching what we did for 18. The start of RDP1, the

[jfx17u] RFR: 8276174: JavaFX build fails on macOS aarch64

2022-05-09 Thread Kevin Rushforth
Clean backport to `jfx17u` so we can build on macOS / aarch64 without needing to specify `-PCOMPILE_TARGET=arm64`. - Commit messages: - 8276174: JavaFX build fails on macOS aarch64 Changes: https://git.openjdk.java.net/jfx17u/pull/60/files Webrev:

[jfx17u] RFR: 8274274: Update JUnit to version 5.8.1

2022-05-09 Thread Kevin Rushforth
Clean backport to `jfx17u`. - Commit messages: - 8274274: Update JUnit to version 5.8.1 Changes: https://git.openjdk.java.net/jfx17u/pull/58/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx17u=58=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8274274 Stats: 161

[jfx17u] RFR: 8273998: Clarify specification for Window properties controlled by the window manager

2022-05-09 Thread Kevin Rushforth
Clean backport to `jfx17u`. - Commit messages: - 8273998: Clarify specification for Window properties controlled by the window manager Changes: https://git.openjdk.java.net/jfx17u/pull/57/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx17u=57=00 Issue:

[jfx17u] RFR: 8276142: Update gradle to version 7.3

2022-05-09 Thread Kevin Rushforth
Clean backport to `jfx17u`. - Commit messages: - 8276142: Update gradle to version 7.3 Changes: https://git.openjdk.java.net/jfx17u/pull/56/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx17u=56=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276142 Stats: 227

Re: [jfx17u] RFR: 8281564: Update cmake to 3.22.3

2022-05-09 Thread Kevin Rushforth
On Mon, 9 May 2022 21:15:57 GMT, Kevin Rushforth wrote: > Reviewer: @arapte Since this is clean, a review is optional. - PR: https://git.openjdk.java.net/jfx17u/pull/55

[jfx17u] RFR: 8281564: Update cmake to 3.22.3

2022-05-09 Thread Kevin Rushforth
Clean backport to `jfx17u`. Tested along with the rest of the fixes in the `test-kcr-17.0.4` branch. - Commit messages: - 8281564: Update cmake to 3.22.3 Changes: https://git.openjdk.java.net/jfx17u/pull/55/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx17u=55=00

Re: [jfx17u] RFR: 8281564: Update cmake to 3.22.3

2022-05-09 Thread Kevin Rushforth
On Mon, 9 May 2022 21:13:07 GMT, Kevin Rushforth wrote: > Clean backport to `jfx17u`. Tested along with the rest of the fixes in the > `test-kcr-17.0.4` branch. Reviewer: @arapte - PR: https://git.openjdk.java.net/jfx17u/pull/55

[jfx17u] RFR: 8283218: Update GStreamer to 1.20.1

2022-05-09 Thread Kevin Rushforth
Almost clean backport to `jfx17u`. Tested in connection with libffi update in the `test-kcr-17.0.4` branch. The only difference from the mainline patch is that the following file is not present in `jfx17u`, so that part of the patch was skipped:

[jfx17u] RFR: 8280840: Update libFFI to 3.4.2

2022-05-09 Thread Kevin Rushforth
Clean backport to `jfx17u`. Tested in connection with gstreamer / glib update in the `test-kcr-17.0.4` branch. - Commit messages: - 8280840: Update libFFI to 3.4.2 Changes: https://git.openjdk.java.net/jfx17u/pull/53/files Webrev:

Re: RFR: 8285534: Update the 3D lighting test sample [v3]

2022-05-06 Thread Kevin Rushforth
On Thu, 28 Apr 2022 17:28:34 GMT, Nir Lisker wrote: >> Update the the test utility. Includes: >> * Refactoring since there is no more need the split pre- and >> post-attenuation and light types. >> * Added customizable material to the `Boxes` to test the interaction between >> lights and

Re: RFR: 8285217: [Android] Window's screen is not updated after native screen was disposed [v3]

2022-05-06 Thread Kevin Rushforth
On Wed, 4 May 2022 16:55:30 GMT, Jose Pereda wrote: >> This PR updates the screen for each window even for the case where the old >> screen has been disposed but there is a new screen instance found for such >> window. >> >> This is the case of Android, where the lifecycle of the application

Re: RFR: 8283318: Videos with unusual sizes cannot be played on windows

2022-05-06 Thread Kevin Rushforth
On Tue, 19 Apr 2022 22:38:13 GMT, Alexander Matveev wrote: > Fixed by removing check which enables dynamic format change, since it > requires for portrait videos, not standard resolutions and anything that has > width > 1920 or/and height > 1080. Looks good. I confirm that it fixes the

Re: RFR: 8285217: [Android] Window's screen is not updated after native screen was disposed

2022-05-03 Thread Kevin Rushforth
On Wed, 20 Apr 2022 18:26:06 GMT, Jose Pereda wrote: > This PR updates the screen for each window even for the case where the old > screen has been disposed but there is a new screen instance found for such > window. > > This is the case of Android, where the lifecycle of the application

[jfx11u] Integrated: 8280275: JUnit5 tests using Assumptions API fail to compile in some cases

2022-05-02 Thread Kevin Rushforth
On Sat, 30 Apr 2022 13:48:01 GMT, Kevin Rushforth wrote: > This PR is dependent on #97 so it is in Draft for now. Once #97 is > integrated, I will rebase this and submit it, at which time it will be a > clean backport, and the diffs will only show the updated test. This pull reques

[jfx11u] RFR: 8280275: JUnit5 tests using Assumptions API fail to compile in some cases

2022-05-02 Thread Kevin Rushforth
This PR is dependent on #97 so it is in Draft for now. Once #97 is integrated, I will rebase this and submit it, at which time it will be a clean backport, and the diffs will only show the updated test. - Commit messages: - 8280275: JUnit5 tests using Assumptions API fail to

[jfx11u] Integrated: 8276174: JavaFX build fails on macOS aarch64

2022-05-02 Thread Kevin Rushforth
On Sat, 30 Apr 2022 13:51:23 GMT, Kevin Rushforth wrote: > Backport to `jfx11u` so we can build on macOS / aarch64 without needing to > specify `-PCOMPILE_TARGET=arm64`. It isn't a clean backport, since I also had > to include the definition of `IS_AARCH64` which is present in

[jfx11u] Integrated: 8280840: Update libFFI to 3.4.2

2022-05-02 Thread Kevin Rushforth
On Sat, 30 Apr 2022 13:30:49 GMT, Kevin Rushforth wrote: > Clean backport to `jfx11u`. Tested in connection with gstreamer / glib update > in the `test-kcr-11.0.16` branch. This pull request has now been integrated. Changeset: 1e4862f4 Author: Kevin Rushforth URL:

[jfx11u] Integrated: 8283218: Update GStreamer to 1.20.1

2022-05-02 Thread Kevin Rushforth
On Sat, 30 Apr 2022 13:37:08 GMT, Kevin Rushforth wrote: > Backport to `jfx11u`. Tested in connection with libffi update in the > `test-kcr-11.0.16` branch. > > This was not a clean backport, but the merge conflicts were trivial to > resolve. Here is a summary of the changes. T

[jfx11u] Integrated: 8274274: Update JUnit to version 5.8.1

2022-05-02 Thread Kevin Rushforth
On Sat, 30 Apr 2022 13:45:39 GMT, Kevin Rushforth wrote: > Nearly clean backport to `jfx11u`. It isn't a clean backport since the > mainline patch updated `gradle/verification-metadata.xml`, which doesn't > exist in 11. This pull request has now been integrated. Changeset: 44e691

[jfx11u] Integrated: 8281564: Update cmake to 3.22.3

2022-05-02 Thread Kevin Rushforth
On Sat, 30 Apr 2022 13:39:32 GMT, Kevin Rushforth wrote: > Simple backport to `jfx11u`. It isn't a clean backport since the mainline > patch had an update to `gradle/verification-metadata.xml`, which doesn't > exist in 11. This pull request has now been integrated. Changeset: e877f3

[jfx11u] Integrated: 8276142: Update gradle to version 7.3

2022-04-30 Thread Kevin Rushforth
On Sat, 30 Apr 2022 13:43:09 GMT, Kevin Rushforth wrote: > Clean backport to `jfx11u`. This pull request has now been integrated. Changeset: e92f7fcd Author: Kevin Rushforth URL: https://git.openjdk.java.net/jfx11u/commit/e92f7fcd4f9e9bc89c91b06b1c7fa8296c4902bb Stats: 227 li

[jfx11u] Integrated: 8273998: Clarify specification for Window properties controlled by the window manager

2022-04-30 Thread Kevin Rushforth
On Sat, 30 Apr 2022 13:48:57 GMT, Kevin Rushforth wrote: > Clean backport to `jfx11u`. This pull request has now been integrated. Changeset: 1e62db92 Author: Kevin Rushforth URL: https://git.openjdk.java.net/jfx11u/commit/1e62db92944c545cc7dd333652819be1c50896ff Stats: 84 li

Re: [jfx11u] RFR: 8276174: JavaFX build fails on macOS aarch64

2022-04-30 Thread Kevin Rushforth
On Sat, 30 Apr 2022 13:51:23 GMT, Kevin Rushforth wrote: > Backport to `jfx11u` so we can build on macOS / aarch64 without needing to > specify `-PCOMPILE_TARGET=arm64`. It isn't a clean backport, since I also had > to include the definition of `IS_AARCH64` which is present in

[jfx11u] RFR: 8276174: JavaFX build fails on macOS aarch64

2022-04-30 Thread Kevin Rushforth
Backport to `jfx11u` so we can build on macOS / aarch64 without needing to specify `-PCOMPILE_TARGET=arm64`. It isn't a clean backport, since I also had to include the definition of `IS_AARCH64` which is present in mainline, but not in `jfx11u` (it was added as part of another unrelated fix

[jfx11u] RFR: 8273998: Clarify specification for Window properties controlled by the window manager

2022-04-30 Thread Kevin Rushforth
Clean backport to `jfx11u`. - Commit messages: - 8273998: Clarify specification for Window properties controlled by the window manager Changes: https://git.openjdk.java.net/jfx11u/pull/99/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u=99=00 Issue:

Re: [jfx11u] RFR: 8274274: Update JUnit to version 5.8.1

2022-04-30 Thread Kevin Rushforth
On Sat, 30 Apr 2022 13:45:39 GMT, Kevin Rushforth wrote: > Nearly clean backport to `jfx11u`. It isn't a clean backport since the > mainline patch updated `gradle/verification-metadata.xml`, which doesn't > exist in 11. Reviewer: @arapte - PR: https://git.openjdk.java.n

[jfx11u] RFR: 8274274: Update JUnit to version 5.8.1

2022-04-30 Thread Kevin Rushforth
Nearly clean backport to `jfx11u`. It isn't a clean backport since the mainline patch updated `gradle/verification-metadata.xml`, which doesn't exist in 11. - Commit messages: - 8274274: Update JUnit to version 5.8.1 Changes: https://git.openjdk.java.net/jfx11u/pull/97/files

[jfx11u] RFR: 8276142: Update gradle to version 7.3

2022-04-30 Thread Kevin Rushforth
Clean backport to `jfx11u`. - Commit messages: - 8276142: Update gradle to version 7.3 Changes: https://git.openjdk.java.net/jfx11u/pull/96/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u=96=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276142 Stats: 227

Re: [jfx11u] RFR: 8281564: Update cmake to 3.22.3

2022-04-30 Thread Kevin Rushforth
On Sat, 30 Apr 2022 13:39:32 GMT, Kevin Rushforth wrote: > Simple backport to `jfx11u`. It isn't a clean backport since the mainline > patch had an update to `gradle/verification-metadata.xml`, which doesn't > exist in 11. Reviewer: @arapte - PR: https://git.openjdk

[jfx11u] RFR: 8281564: Update cmake to 3.22.3

2022-04-30 Thread Kevin Rushforth
Simple backport to `jfx11u`. It isn't a clean backport since the mainline patch had an update to `gradle/verification-metadata.xml`, which doesn't exist in 11. - Commit messages: - 8281564: Update cmake to 3.22.3 Changes: https://git.openjdk.java.net/jfx11u/pull/95/files Webrev:

Re: [jfx11u] RFR: 8283218: Update GStreamer to 1.20.1

2022-04-30 Thread Kevin Rushforth
On Sat, 30 Apr 2022 13:37:08 GMT, Kevin Rushforth wrote: > Backport to `jfx11u`. Tested in connection with libffi update in the > `test-kcr-11.0.16` branch. > > This was not a clean backport, but the merge conflicts were trivial to > resolve. Here is a summary of the changes. T

[jfx11u] RFR: 8283218: Update GStreamer to 1.20.1

2022-04-30 Thread Kevin Rushforth
Backport to `jfx11u`. Tested in connection with libffi update in the `test-kcr-11.0.16` branch. This was not a clean backport, but the merge conflicts were trivial to resolve. Here is a summary of the changes. The jfx mainline patch applied cleanly to all other files. 1. The following file is

[jfx11u] RFR: 8280840: Update libFFI to 3.4.2

2022-04-30 Thread Kevin Rushforth
Clean backport to `jfx11u`. Tested in connection with gstreamer / glib update in the `test-kcr-11.0.16` branch. - Commit messages: - 8280840: Update libFFI to 3.4.2 Changes: https://git.openjdk.java.net/jfx11u/pull/93/files Webrev:

Re: RFR: 8285725: Wrong link to JBS in README.md

2022-04-27 Thread Kevin Rushforth
On Wed, 27 Apr 2022 14:01:06 GMT, Nir Lisker wrote: > Updated the README link to match the CONTRIBUTING link. Looks good. Thanks for fixing it. - Marked as reviewed by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/788

Re: Wrong link in README.md?

2022-04-27 Thread Kevin Rushforth
Yes, this seems like a bug. I agree that it would be better for the "issues list" link to use the same filtered list of issues that CONTRIBUTING.md links to. -- Kevin On 4/26/2022 8:54 PM, Nir Lisker wrote: In the README.md, under Issue Tracking, the link to "issues list" leads to the JBS

Re: D3D pipeline possible inconsistencies

2022-04-26 Thread Kevin Rushforth
As you note, there are a few different issues here. To answer your questions as best I can: 1 & 3. We should document that self-illum maps and specular only use the rgb components and that alpha should be ignored. It's possible (although I don't know for sure) that the image is being treated

Re: [jfx18] RFR: 8285475: Create release notes for 18.0.1

2022-04-26 Thread Kevin Rushforth
On Mon, 25 Apr 2022 06:50:07 GMT, Abhinay Agarwal wrote: > Add release notes for JavaFX 18.0.1 to the repository Marked as reviewed by kcr (Lead). - PR: https://git.openjdk.java.net/jfx/pull/785

Re: [jfx18] RFR: 8285475: Create release notes for 18.0.1

2022-04-26 Thread Kevin Rushforth
On Mon, 25 Apr 2022 06:50:07 GMT, Abhinay Agarwal wrote: > Add release notes for JavaFX 18.0.1 to the repository The following two non-public (security) fixes are also included in 18.0.1: JDK-8276371 (not public) | Better long buffering | web JDK-8277465 (not public) | Additional fix for

Re: RFR: 8284654: Modal behavior returns to wrong stage

2022-04-22 Thread Kevin Rushforth
On Fri, 22 Apr 2022 19:26:36 GMT, Thiago Milczarek Sayao wrote: > When there's an APPLICATION_MODAL window, all other windows are disabled and > re-enabled when the APPLICATION_MODAL window closes. This causes > `requestToFront()` to be called on every window, and it does not guarantee >

Re: RFR: 8193442: Removing TreeItem from a TreeTableView sometime changes selectedItem [v3]

2022-04-22 Thread Kevin Rushforth
On Thu, 21 Apr 2022 08:37:11 GMT, Jose Pereda wrote: >> This PR fixes >> JDK-[8193442](https://bugs.openjdk.java.net/browse/JDK-8193442), but also >> [JDK-8187596](https://bugs.openjdk.java.net/browse/JDK-8187596), and >> verifies that the tests mentioned in >>

Re: RFR: 8278430 : Several tests use terminally deprecated System.runFinalization method

2022-04-21 Thread Kevin Rushforth
On Thu, 21 Apr 2022 15:03:04 GMT, Hima Bindu Meda wrote: > This PR is to remove calls to deprecated method System.runFinalization. > Here is the list of module wise test cases affected by the removal: > > **web**: > test.javafx.scene.web.LeakTest > > **systemTests**: >

Re: RFR: 8282449: Intermittent OOM error in PredefinedMeshManagerTest

2022-04-21 Thread Kevin Rushforth
On Thu, 21 Apr 2022 15:07:38 GMT, Ambarish Rapte wrote: > This is a test only fix. The tests used to create Sphere and Cylinder of > large divisions, which could fail intermittently with OOM. > The tests were added along with the fix for >

Re: RFR: 8285034: Skip ServiceTest.testManyServicesRunConcurrently on Windows

2022-04-21 Thread Kevin Rushforth
On Thu, 21 Apr 2022 15:44:57 GMT, Ambarish Rapte wrote: > The test ServiceTest.testManyServicesRunConcurrently fails intermittently on > Windows platform with a time out error. > Test needs to be skipped until fixed. LGTM - Marked as reviewed by kcr (Lead). PR:

Re: RFR: 8283218: Update GStreamer to 1.20.1 [v5]

2022-04-21 Thread Kevin Rushforth
On Wed, 20 Apr 2022 23:08:00 GMT, Alexander Matveev wrote: >> - GStreamer updated to 1.20.1 and GLib updated to 2.72.0. >> - No changes to our code, except in GstAudioSpectrum.cpp >> g_atomic_pointer_compare_and_exchange() was changed to >> g_atomic_pointer_set(). For some reason I was not

Re: RFR: 8283218: Update GStreamer to 1.20.1 [v4]

2022-04-20 Thread Kevin Rushforth
On Mon, 18 Apr 2022 18:38:03 GMT, Alexander Matveev wrote: >> - GStreamer updated to 1.20.1 and GLib updated to 2.72.0. >> - No changes to our code, except in GstAudioSpectrum.cpp >> g_atomic_pointer_compare_and_exchange() was changed to >> g_atomic_pointer_set(). For some reason I was not

Re: [jfx18] RFR: 8283328: Update libxml2 to 2.9.13

2022-04-20 Thread Kevin Rushforth
On Wed, 20 Apr 2022 13:29:36 GMT, Johan Vos wrote: > Reviewed-by: jvos, kcr, arapte I confirm that this is a clean backport, but Skara failed to detect that it was clean due to [SKARA-1332](https://bugs.openjdk.java.net/browse/SKARA-1332). - PR:

Re: [jfx11u] RFR: 8283328: Update libxml2 to 2.9.13

2022-04-20 Thread Kevin Rushforth
On Wed, 20 Apr 2022 13:21:39 GMT, Johan Vos wrote: > Reviewed-by: jvos, kcr, arapte I confirm that this is a clean backport, but Skara failed to detect that it was clean due to [SKARA-1332](https://bugs.openjdk.java.net/browse/SKARA-1332). - PR:

Re: [jfx17u] RFR: 8283328: Update libxml2 to 2.9.13

2022-04-20 Thread Kevin Rushforth
On Wed, 20 Apr 2022 13:24:53 GMT, Johan Vos wrote: > Reviewed-by: jvos, kcr, arapte I confirm that this is a clean backport, but Skara failed to detect that it was clean due to [SKARA-1332](https://bugs.openjdk.java.net/browse/SKARA-1332). - PR:

Re: [External] : Backport requests for JavaFX 11, 17, 18

2022-04-20 Thread Kevin Rushforth
+1 On 4/20/2022 5:59 AM, Johan Vos wrote: Hi Kevin, I request permission to backport the following issue to JavaFX 11.0.16, JavaFX 17.0.4 and JavaFX 18.0.2 https://bugs.openjdk.java.net/browse/JDK-8283328 Apart from whitespace warnings, the patch applies clean - Johan

  1   2   3   4   5   6   7   8   9   10   >