Re: Proposal on getting warning free (controls) packages

2014-03-21 Thread John Hendrikx
On 20/03/2014 20:57, Tom Schindl wrote: Hi, I've just started looking into getting the controls package warning free and/or suppress them in case not fixable. Most of the generic warnings I've come accross in a first pass involve StyleableProperty cast like this:

Proposal on getting warning free (controls) packages

2014-03-20 Thread Tom Schindl
Hi, I've just started looking into getting the controls package warning free and/or suppress them in case not fixable. Most of the generic warnings I've come accross in a first pass involve StyleableProperty cast like this: ((StyleableProperty)graphicProperty()).applyStyle(origin, null); In

Re: Proposal on getting warning free (controls) packages

2014-03-20 Thread Jonathan Giles
I'll leave it to David to comment on the specifics of these warnings, but in general I'm very supportive of improving the quality of the controls code. It would be best to file a new jira issue and start putting patches up there (although for that to happen you'll need to email the patch to me so

Re: Proposal on getting warning free (controls) packages

2014-03-20 Thread David Grieve
Too bad we can't go back and have WritableValue also extend Styleable... I'm happy to live with the @SuppressWarnings in this particular context since we know that graphicProperty is indeed a StyleablePropertyNode, as is the case where we cast in implementations of the CssMetaData