On Tue, 17 Nov 2020 12:38:32 GMT, Jeanette Winzenburg
wrote:
>> Fixing IndexOutOfBoundsException in the MultipleSelectionModelBase and added
>> a unit-test for it.
>> ticket: https://bugs.openjdk.java.net/browse/JDK-8256397
>> run test: `./gradlew --continue -PFULL_TEST=true controls:test --tes
On Wed, 22 Jun 2022 09:48:14 GMT, Florian Kirmaier
wrote:
>> Fixing IndexOutOfBoundsException in the MultipleSelectionModelBase and added
>> a unit-test for it.
>> ticket: https://bugs.openjdk.java.net/browse/JDK-8256397
>> run test: `./gradlew --continue -PFULL_TEST=true controls:test --tests
On Wed, 23 Feb 2022 22:43:58 GMT, Marius Hanl wrote:
>> This PR fixes an issue where the item of the table row is null, although the
>> cell itself is not empty (non null value).
>>
>> The fix is to call `indexChanged(..)` immediately after the index was
>> changed, but before all `indexProper
> The children of HBox/VBox don't always pixel-snap to the same value as the
> container itself when a render scale other than 1 is used. This can lead to a
> visual glitch where the content bounds don't line up with the container
> bounds. In this case, the container will extend beyond its cont
On Mon, 27 Jun 2022 23:19:36 GMT, Andy Goryachev wrote:
> summary of changes:
> - fixed .classpath files
> - set UTF-8 encoding in the eclipse project config files
I found my branch that was dealing with the Eclipse files update:
https://github.com/openjdk/jfx/compare/master...nlisker:jfx:82217
As a reminder, Rampdown Phase 1 (RDP1) for JavaFX 19 starts on July 14,
2022 at 16:00 UTC (09:00 Pacific time), which is a little less than two
weeks from now.
During rampdown of JavaFX 19, the "master" branch of the jfx repo will
be open for JavaFX 20 fixes.
Please allow sufficient time for
On Fri, 1 Jul 2022 20:41:46 GMT, Alexander Matveev wrote:
>> Doc-only change to update the license attribution in our gstreamer.md and
>> glib.md files.
>
> Alexander Matveev has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8288450: Update
> Doc-only change to update the license attribution in our gstreamer.md and
> glib.md files.
Alexander Matveev has updated the pull request incrementally with one
additional commit since the last revision:
8288450: Update attribution in gstreamer.md file [v2]
-
Changes:
- all:
On Fri, 1 Jul 2022 12:16:36 GMT, Marius Hanl wrote:
>> This simple PR optimizes the observable `ArrayList` creation by using the
>> ArrayList constructor/array size so that the underlying array will be
>> initialized at the correct size which will speed up the creation as the
>> array does not
On Fri, 1 Jul 2022 12:16:36 GMT, Marius Hanl wrote:
>> This simple PR optimizes the observable `ArrayList` creation by using the
>> ArrayList constructor/array size so that the underlying array will be
>> initialized at the correct size which will speed up the creation as the
>> array does not
On Fri, 1 Jul 2022 15:16:24 GMT, John Hendrikx wrote:
>> This is an implementation of the proposal in
>> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker
>> (@nlisker) have been working on. It's a complete implementation including
>> good test coverage.
>>
>> This wa
On Fri, 1 Jul 2022 15:16:24 GMT, John Hendrikx wrote:
>> This is an implementation of the proposal in
>> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker
>> (@nlisker) have been working on. It's a complete implementation including
>> good test coverage.
>>
>> This wa
On Fri, 1 Jul 2022 13:23:58 GMT, Kevin Rushforth wrote:
> While running tests I noticed that your branch is very out of date w.r.t.
> master. Can you merge in the latest master in order to get a new GHA test run
> with the latest changes included?
It's updated, linux build just passed so proba
> This is an implementation of the proposal in
> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker
> (@nlisker) have been working on. It's a complete implementation including
> good test coverage.
>
> This was based on https://github.com/openjdk/jfx/pull/434 but with a
On Fri, 1 Jul 2022 09:04:11 GMT, John Hendrikx wrote:
>> This is an implementation of the proposal in
>> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker
>> (@nlisker) have been working on. It's a complete implementation including
>> good test coverage.
>>
>> This wa
On Fri, 1 Jul 2022 02:07:54 GMT, Alexander Matveev wrote:
> Doc-only change to update the license attribution in our gstreamer.md and
> glib.md files.
Looks good with a minor (optional) comment in two places.
modules/javafx.media/src/main/legal/glib.md line 38:
> 36: ```
> 37:
> 38: LGP
> This simple PR optimizes the observable `ArrayList` creation by using the
> ArrayList constructor/array size so that the underlying array will be
> initialized at the correct size which will speed up the creation as the array
> does not need to grow as a result of the `addAll` call.
>
> I als
On Thu, 30 Jun 2022 22:46:26 GMT, Kevin Rushforth wrote:
>> John Hendrikx has updated the pull request incrementally with five
>> additional commits since the last revision:
>>
>> - Move private binding classes to com.sun.javafx.binding package
>> - Add note to Bindings#select to consider Obs
> This is an implementation of the proposal in
> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker
> (@nlisker) have been working on. It's a complete implementation including
> good test coverage.
>
> This was based on https://github.com/openjdk/jfx/pull/434 but with a
On Thu, 30 Jun 2022 19:36:34 GMT, Nir Lisker wrote:
> Looks good. I left a few small comments.
>
> I ran some benchmarks and I can reproduce the performance improvement both in
> the array (varargs) and the collection variants of the method.
Thanks for the review and verifying the improvement.
> This simple PR optimizes the observable `ArrayList` creation by using the
> ArrayList constructor/array size so that the underlying array will be
> initialized at the correct size which will speed up the creation as the array
> does not need to grow as a result of the `addAll` call.
>
> I als
21 matches
Mail list logo
