- trivial change removes 4 eclipse warnings
-
Commit messages:
- 8289390: fixed type parameter hiding another type
Changes: https://git.openjdk.org/jfx/pull/812/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=812&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8289390
On Fri, 1 Jul 2022 15:16:24 GMT, John Hendrikx wrote:
>> This is an implementation of the proposal in
>> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker
>> (@nlisker) have been working on. It's a complete implementation including
>> good test coverage.
>>
>> This wa
> This patch updates the compiler to gcc 11.2 on Linux, in order to match JDK
> 19 -- see [JDK-8283057](https://bugs.openjdk.java.net/browse/JDK-8283057).
>
> I ran a full build and test, including media and WebKit.
Kevin Rushforth has updated the pull request with a new target base due to a
me
- removed meaningless test case
-
Commit messages:
- 8289396: removed meaningless test case
Changes: https://git.openjdk.org/jfx/pull/813/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=813&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8289396
Stats: 12 lines in 1
On Tue, 5 Jul 2022 23:21:19 GMT, Kevin Rushforth wrote:
> Thank you for fixing this quickly.
Thank you very much for your time as well! I am glad that I could help.
-
PR: https://git.openjdk.org/jfx/pull/811
On Wed, 6 Jul 2022 15:14:03 GMT, Andy Goryachev wrote:
> - removed meaningless test case
Looks good.
-
Marked as reviewed by kcr (Lead).
PR: https://git.openjdk.org/jfx/pull/813
> summary of changes:
> - fixed .classpath files
> - set UTF-8 encoding in the eclipse project config files
Andy Goryachev has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pul
On Mon, 30 May 2022 08:10:36 GMT, Johan Vos wrote:
>> When the size of a ListCell is changed and a scrollTo method is invoked
>> without having a layout calculation in between, the old (wrong) size is used
>> to calculcate the total estimate. This happens e.g. when the size is changed
>> in th
On Tue, 5 Jul 2022 23:09:37 GMT, Marius Hanl wrote:
> As also discussed in the ticket, we need to disable/ignore this two tests for
> now.
>
> With the fix for [JDK-8251483](https://bugs.openjdk.org/browse/JDK-8251483)
> the table row item is never null in a non empty table cell.
> In the mean
> summary of changes:
> - fixed .classpath files
> - set UTF-8 encoding in the eclipse project config files
Andy Goryachev has updated the pull request incrementally with one additional
commit since the last revision:
8289255 remove javafx.graphics/build/gensrc as source folder
-
On Sun, 3 Jul 2022 15:01:19 GMT, Michael Strauß wrote:
>> The children of HBox/VBox don't always pixel-snap to the same value as the
>> container itself when a render scale other than 1 is used. This can lead to
>> a visual glitch where the content bounds don't line up with the container
>> bo
On Tue, 5 Jul 2022 23:09:37 GMT, Marius Hanl wrote:
> As also discussed in the ticket, we need to disable/ignore this two tests for
> now.
>
> With the fix for [JDK-8251483](https://bugs.openjdk.org/browse/JDK-8251483)
> the table row item is never null in a non empty table cell.
> In the mean
On Tue, 5 Jul 2022 18:49:40 GMT, Andy Goryachev wrote:
>> 1. The way the apps are structured is that each app is its own project,
>> which means that there are many new projects to create and configure. It can
>> be a bit of work, though I have done it in my branch already. If you want to
>> l
On Tue, 5 Jul 2022 19:23:13 GMT, Jose Pereda wrote:
> This PR solves an IAE exception that happens when invoking a ColorChooser
> control within a WebView, by getting the r, g, b values from the Color before
> calling the colorChooser.
>
> A system test is included, to verify that there is no
On Tue, 5 Jul 2022 21:45:54 GMT, Nir Lisker wrote:
>> 1. I would rather leave the apps/ for day 2, if I may.
>> 2+3. Currently, on Mac, I don't see any issues related to build/...
>> folders. I think, generally speaking, it's a bad idea to refer to derived
>> folders as source - it complicate
As also discussed in the ticket, we need to disable/ignore this two tests for
now.
With the fix for [JDK-8251483](https://bugs.openjdk.org/browse/JDK-8251483) the
table row item is never null in a non empty table cell.
In the meantime with [JDK-8251480](https://bugs.openjdk.org/browse/JDK-825148
On Tue, 5 Jul 2022 19:23:13 GMT, Jose Pereda wrote:
> This PR solves an IAE exception that happens when invoking a ColorChooser
> control within a WebView, by getting the r, g, b values from the Color before
> calling the colorChooser.
>
> A system test is included, to verify that there is no
On Fri, 1 Jul 2022 15:16:24 GMT, John Hendrikx wrote:
>> This is an implementation of the proposal in
>> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker
>> (@nlisker) have been working on. It's a complete implementation including
>> good test coverage.
>>
>> This wa
> Initialize the `(Tree)TableView` when creating the measure row.
> This will guarantee, that we can access the `(Tree)TableView` in the
> `(Tree)TableRowSkin`, which is currently only null during the autosizing (It
> is always set otherwise).
>
> With this change, a NPE is happening as the `(Tr
19 matches
Mail list logo
