Re: Listeners behavior discussion

2022-07-09 Thread Michael Strauß
>From what I understand, you are essentially suggesting to solve an existing bug in ExpressionHelper, where inconsistent change notifications can be produced when a listener modifies its ObservableValue. At first, it seems like a good idea to defer a nested change notification until after all list

Re: RFR: 8283402: Update to gcc 11.2 on Linux [v4]

2022-07-09 Thread Johan Vos
On Wed, 6 Jul 2022 12:30:08 GMT, Kevin Rushforth wrote: >> This patch updates the compiler to gcc 11.2 on Linux, in order to match JDK >> 19 -- see [JDK-8283057](https://bugs.openjdk.java.net/browse/JDK-8283057). >> >> I ran a full build and test, including media and WebKit. > > Kevin Rushforth

Re: RFR: 8289389: Fix warnings: type should also implement hashCode() since it overrides Object.equals() [v2]

2022-07-09 Thread Kevin Rushforth
On Sat, 9 Jul 2022 01:28:20 GMT, Nir Lisker wrote: >> modules/javafx.graphics/src/main/java/com/sun/javafx/css/CalculatedValue.java >> line 101: >> >>> 99: } >>> 100: return h; >>> 101: } >> >> Just an example, but wouldn't: `Objects.hash(relative, origin, value)` here >>

Re: RFR: 8288137: The set of available printers is not updated without application restart [v4]

2022-07-09 Thread Kevin Rushforth
On Fri, 8 Jul 2022 22:27:41 GMT, Phil Race wrote: >> This fixes the issue that the default printer or set of available printers >> is fixed from the first call to it in the lifetime of the application. >> Now subsequent calls will check to see if there are changes. >> A manual test is provided f

Listeners behavior discussion

2022-07-09 Thread John Hendrikx
Hi all, I'm looking into ExpressionHelper as part of my evaluation of adding Cleaner's to clean up weak listeners stubs a bit more eagerly. I would like to hear your thoughts on the following: ExpressionHelper has a locking mechanism so that when an event occurs, it is fired to the listeners

Re: CFV: New OpenJFX Committer: Marius Hanl

2022-07-09 Thread Jeanette Winzenburg
Vote: YES -- Jeanette Zitat von Kevin Rushforth : I hereby nominate Marius Hanl [1] to OpenJFX Committer. Marius is an OpenJFX community member, who has contributed 22 commits [2] to OpenJFX. Votes are due by July 22, 2022 at 13:00 UTC. Only current OpenJFX Committers [3] are eligible

Re: CFV: New OpenJFX Committer: Michael Strauß

2022-07-09 Thread Jeanette Winzenburg
Vote: YES -- Jeanette Zitat von Kevin Rushforth : I hereby nominate Michael Strauß [1] to OpenJFX Committer. Michael is an OpenJFX community member, who has contributed 16 commits [2] to OpenJFX. Votes are due by July 22, 2022 at 13:00 UTC. Only current OpenJFX Committers [3] are eligi

Re: CFV: New OpenJFX Committer: Michael Strauß

2022-07-09 Thread Laurent Bourgès
Vote: YES Congratulations, michael ! Le sam. 9 juil. 2022, 07:53, Ajit Ghaisas a écrit : > Vote : YES > > Regards, > Ajit > > > On 08-Jul-2022, at 6:01 PM, Kevin Rushforth > wrote: > > > > I hereby nominate Michael Strauß [1] to OpenJFX Committer. > > > > Michael is an OpenJFX community member