Re: RFR: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs

2022-07-17 Thread John Hendrikx
On Sun, 17 Jul 2022 20:59:46 GMT, John Hendrikx wrote: > This contains the following: > - Nested changes or invalidations using ExpressionHelper are delayed until > the current emission completes > - This fixes odd change events being produced (with incorrect oldValue) > - Also fixes a bug i

RFR: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs

2022-07-17 Thread John Hendrikx
This contains the following: - Nested changes or invalidations using ExpressionHelper are delayed until the current emission completes - This fixes odd change events being produced (with incorrect oldValue) - Also fixes a bug in ExpressionHelper where a nested change would unlock the listener

Re: [jfx19] RFR: 8290348: TreeTableView jumping to top [v2]

2022-07-17 Thread Johan Vos
> Do not recalculate total estimated size recursively. > > In the (unlikely) event that the recalculation triggers a new recalculation > (e.g. when the height of a Cell is changed), do not start this recalculation. > The cache and cache size may become inconsistent if a recursive calculation > i

[jfx18] Integrated: 8282134: Certain regex can cause a JS trap in WebView

2022-07-17 Thread Johan Vos
On Sat, 16 Jul 2022 18:52:10 GMT, Johan Vos wrote: > Clean backport of 8282134: Certain regex can cause a JS trap in WebView > Reviewed-by: kcr, arapte This pull request has now been integrated. Changeset: 58170f44 Author:Johan Vos URL: https://git.openjdk.org/jfx/commit/58170f44095

[jfx18] Integrated: 8280841: Update SQLite to 3.37.2

2022-07-17 Thread Johan Vos
On Sat, 16 Jul 2022 18:44:29 GMT, Johan Vos wrote: > Clean backport of 8280841: Update SQLite to 3.37.2 Reviewed-by: kcr, arapte This pull request has now been integrated. Changeset: 2210a97d Author:Johan Vos URL: https://git.openjdk.org/jfx/commit/2210a97dbde56b2730e7b41edf6946597d

[jfx18] Integrated: 8286256: Update libxml2 to 2.9.14

2022-07-17 Thread Johan Vos
On Sat, 16 Jul 2022 18:48:55 GMT, Johan Vos wrote: > Clean backport of JDK-8286256 This pull request has now been integrated. Changeset: fc2983b6 Author:Johan Vos URL: https://git.openjdk.org/jfx/commit/fc2983b62b640be9bbdd3f52b2234456a661e6d2 Stats: 21664 lines in 81 files chan

[jfx19] RFR: 8290348: TreeTableView jumping to top

2022-07-17 Thread Johan Vos
Do not recalculate total estimated size recursively. In the (unlikely) event that the recalculation triggers a new recalculation (e.g. when the height of a Cell is changed), do not start this recalculation. The cache and cache size may become inconsistent if a recursive calculation is started. T

Re: CFV: New OpenJFX Committer: Michael Strauß

2022-07-17 Thread John Neffenger
Vote: YES John (Trying again ... message on July 12 didn't make it to mailing list.) On 7/8/22 5:31 AM, Kevin Rushforth wrote: I hereby nominate Michael Strauß [1] to OpenJFX Committer. Michael is an OpenJFX community member, who has contributed 16 commits [2] to OpenJFX. Votes are due by

Re: CFV: New OpenJFX Committer: Marius Hanl

2022-07-17 Thread John Neffenger
Vote: YES John (Trying again ... message on July 12 didn't make it to mailing list.) On 7/8/22 5:12 AM, Kevin Rushforth wrote: I hereby nominate Marius Hanl [1] to OpenJFX Committer. Marius is an OpenJFX community member, who has contributed 22 commits [2] to OpenJFX. Votes are due by July

Re: RFR: 8289394: Fix warnings: Unlikely argument type

2022-07-17 Thread Nir Lisker
On Fri, 8 Jul 2022 20:31:31 GMT, Andy Goryachev wrote: > Fixes "Unlikely argument type" warning generated by the latest Eclipse IDE. > > This warning should be reclassified as an error, as it catches bugs missed by > javac. In this case, the following places seem to contain bugs: > - > apps/s