Re: RFR: 8290473: update Eclipse .classpath in apps, buildSrc [v2]

2022-08-05 Thread Nir Lisker
On Mon, 1 Aug 2022 19:34:11 GMT, Andy Goryachev wrote: >> buildSrc/.classpath line 10: >> >>> 8: >> path="../build/libs/antlr-runtime-3.1.3.jar"/> >>> 9: >> path="../build/libs/stringtemplate-3.2.jar"/> >>> 10: >> path="../build/libs/swt-debug.jar"/> >> >> Why does buildSrc need to be a

Re: RFR: 8290473: update Eclipse .classpath in apps, buildSrc [v2]

2022-08-05 Thread Nir Lisker
On Mon, 1 Aug 2022 19:30:28 GMT, Andy Goryachev wrote: >> modules/javafx.graphics/.classpath line 5: >> >>> 3: >>> 4: >>> 5: >> >> How do you not get errors on these on Mac/Linux if they are not declared >> optional? >> >> Additionally, you need the hlsl folders as shown in the mailing

Re: RFR: 8290473: update Eclipse .classpath in apps, buildSrc [v2]

2022-08-05 Thread Kevin Rushforth
On Fri, 5 Aug 2022 18:25:50 GMT, Andy Goryachev wrote: > i was thinking of merely creating these two dirs in a new task 'initDirs' and > make 'sdk' depend on that task, in the top level build.gradle. Any objections I suppose that would be OK. I presume you'll check that the presence of the

Re: RFR: 8291087: Wrong position of focus of screen reader on Windows with screen scale > 1 [v2]

2022-08-05 Thread Kevin Rushforth
On Fri, 5 Aug 2022 18:42:34 GMT, Kevin Rushforth wrote: >> When using the Windows Narrator screen reader on a Hi-DPI screen, the >> visible focus is drawn in the wrong location and with the wrong size. This >> happens because the the JavaFX Windows accessibility code that returns the >>

Re: RFR: 8291087: Wrong position of focus of screen reader on Windows with screen scale > 1

2022-08-05 Thread Andy Goryachev
On Fri, 5 Aug 2022 18:38:28 GMT, Kevin Rushforth wrote: >> When using the Windows Narrator screen reader on a Hi-DPI screen, the >> visible focus is drawn in the wrong location and with the wrong size. This >> happens because the the JavaFX Windows accessibility code that returns the >>

Re: RFR: 8291087: Wrong position of focus of screen reader on Windows with screen scale > 1 [v2]

2022-08-05 Thread Kevin Rushforth
> When using the Windows Narrator screen reader on a Hi-DPI screen, the visible > focus is drawn in the wrong location and with the wrong size. This happens > because the the JavaFX Windows accessibility code that returns the screen > bounds of the requested UI element does not take the screen

Re: RFR: 8291087: Wrong position of focus of screen reader on Windows with screen scale > 1

2022-08-05 Thread Kevin Rushforth
On Thu, 28 Jul 2022 15:01:34 GMT, Kevin Rushforth wrote: > When using the Windows Narrator screen reader on a Hi-DPI screen, the visible > focus is drawn in the wrong location and with the wrong size. This happens > because the the JavaFX Windows accessibility code that returns the screen >

Re: RFR: 8290473: update Eclipse .classpath in apps, buildSrc [v2]

2022-08-05 Thread Andy Goryachev
On Fri, 5 Aug 2022 12:01:27 GMT, Jeanette Winzenburg wrote: >> hmm .. that's indeed weird - here (on win) both graphics/build/hlsl/Prism >> and graphics/build/hlsl/Decora are created by running ./gradlew sdk ... >> will re-check > > did re-check (added your fork as remote, checkout this

Re: RFR: 8235491: Tree/TableView: implementation of isSelected(int) violates contract [v6]

2022-08-05 Thread Kevin Rushforth
On Wed, 3 Aug 2022 23:28:24 GMT, Andy Goryachev wrote: >> 1. reword SelectionModel.isSelected(int) javadoc, removing incorrect >> statement "Is functionally equivalent to calling >> getSelectedIndices().contains(index)." >> 2. reimplement TableView.TableViewSelectionModel.isSelected(int)

Re: RFR: 8279640: ListView with null SelectionModel/FocusModel throws NPE

2022-08-05 Thread Marius Hanl
On Thu, 4 Aug 2022 21:29:49 GMT, Kevin Rushforth wrote: > As I mentioned in that JBS issue, I tend to agree that if we were starting > today with a blank sheet of paper, we might have disallowed null and defined > a "noop" selection model and/or focus model. At this point, though, it would >

Re: RFR: 8290473: update Eclipse .classpath in apps, buildSrc [v2]

2022-08-05 Thread Jeanette Winzenburg
On Fri, 5 Aug 2022 11:02:50 GMT, Jeanette Winzenburg wrote: >> This is puzzling, @kleopatra . >> I don't see a reference to [hlsl/]Prism or [hlsl/]Decora anywhere. Not in >> any gradle.build file, not in every file. I don't think these two >> directories are being built, though I can only

Re: RFR: 8290473: update Eclipse .classpath in apps, buildSrc [v2]

2022-08-05 Thread Jeanette Winzenburg
On Thu, 4 Aug 2022 17:07:53 GMT, Andy Goryachev wrote: >> the tests are fine - it happens if I have a separate project and let that >> depend on the controls, basic, graphics projects (just the same setup as >> described on the mailinglist) > > This is puzzling, @kleopatra . > I don't see a

Re: RFR: 8235491: Tree/TableView: implementation of isSelected(int) violates contract [v6]

2022-08-05 Thread Jeanette Winzenburg
On Fri, 5 Aug 2022 10:44:55 GMT, Jeanette Winzenburg wrote: >> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 11 additional >>

Re: RFR: 8235491: Tree/TableView: implementation of isSelected(int) violates contract [v6]

2022-08-05 Thread Jeanette Winzenburg
On Wed, 3 Aug 2022 23:28:24 GMT, Andy Goryachev wrote: >> 1. reword SelectionModel.isSelected(int) javadoc, removing incorrect >> statement "Is functionally equivalent to calling >> getSelectedIndices().contains(index)." >> 2. reimplement TableView.TableViewSelectionModel.isSelected(int)

Re: RFR: JDK-8269921 Text in Textflow and listeners on bounds can cause endless loop/crash and other performance issues [v3]

2022-08-05 Thread Marius Hanl
On Tue, 26 Jul 2022 11:51:10 GMT, Florian Kirmaier wrote: >> It's "a bit" complicated. >> In some situations, getRuns get's called because listeners on bounds are set. >> This causes TextFlow to layout to compute the runs. >> Afterward, the bounds of the parents get updated. >> This triggers a

Re: RFR: 8287604: Update MarlinFX to 0.9.4.5 [v3]

2022-08-05 Thread Kevin Rushforth
On Thu, 7 Jul 2022 22:46:53 GMT, Laurent Bourgès wrote: >> Changelog for this MarlinFX 0.9.4.5 release: >> >> The Marlin-renderer 0.9.4.5 release provides bug fixes on Marlin's path >> clipper: >> - improved Stroker to handle huge coordinates, up to 1E15 >> - improved PathClipFilter (filler)