Re: Missing 'vcruntime.h'

Kevin, can you update the windows_tools.properties file for the build page on the wiki [1] for VS 2022 since I see that we updated to use that version? [1] https://wiki.openjdk.org/pages/viewpage.action?pageId=66650334 On Sat, Aug 13, 2022 at 2:06 AM Nir Lisker wrote: > I see the file under

Re: RFR: 8290473: update Eclipse .classpath in apps, buildSrc [v9]

> The goal of this change is to make sure jfx repo can be imported as a gradle > project in eclipse and all nested projects in the workspace compile with no > errors. > > - updated .classpath entries in apps/ > - added utf-8 prefs in .settings/ Andy Goryachev has updated the pull request

Re: Missing 'vcruntime.h'

I see the file under \VC\Tools\MSVC\14.33.31629\include\vcruntime.h of the VS installation. The file calling it is under C:/Program Files (x86)/Windows Kits/10/include/10.0.17763.0/ucrt\corecrt.h. Is it supposed to look for some env variable to find it? I have MSVC_VER, VSINSTALLDIR and

Re: Missing 'vcruntime.h'

vcruntime.h is included with the Visual Studio compiler and has been for ages. I can't think of anything recently that would have changed relative to that. -- Kevin On 8/12/2022 2:12 PM, Nir Lisker wrote: Hi, I have just run gradle clean and gradle build, and I'm getting an error:

Missing 'vcruntime.h'

Hi, I have just run gradle clean and gradle build, and I'm getting an error: C:/Program Files (x86)/Windows Kits/10/include/10.0.17763.0/ucrt\corecrt.h(10): fatal error C1083: Cannot open include file: 'vcruntime.h': No such file or directory Indeed, vcruntime.h is not in that folder. Do I need

Re: RFR: 8290844: Add Skin.install() method [v3]

On Fri, 12 Aug 2022 17:00:07 GMT, Jeanette Winzenburg wrote: > A quick PoC is in [my fork off Andy's > PR](https://github.com/kleopatra/jfx/tree/exp-skin-install-supportsInstall) @kleopatra : Thank you so much for your effort to research the alternatives. The main issue that necessitates

Re: RFR: 8290844: Add Skin.install() method [v4]

> - added Skin.install() > - javadoc changes for Skinnable.setSkin(Skin) > > no code changes for Skinnable.setSkin(Skin) yet. Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision: 8290844: review comments - Changes: -

Re: RFR: 8290844: Add Skin.install() method [v3]

On Fri, 12 Aug 2022 17:51:20 GMT, Kevin Rushforth wrote: >> Good point! >> Actually, unbind() is sufficient, as it does the required check. From >> javadoc: _If the Property is not bound, calling this method has no effect._ >> Is there another reason to call isBound(), perhaps for clarity? > >

Re: RFR: 8290844: Add Skin.install() method [v3]

On Thu, 11 Aug 2022 23:11:45 GMT, Kevin Rushforth wrote: >> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 13 additional >>

Re: RFR: 8290844: Add Skin.install() method [v3]

On Fri, 12 Aug 2022 17:30:20 GMT, Andy Goryachev wrote: >> modules/javafx.controls/src/main/java/javafx/scene/control/Control.java line >> 245: >> >>> 243: if (skin != null) { >>> 244: if (skin.getSkinnable() != Control.this) { >>> 245: throw new

Re: RFR: 8290844: Add Skin.install() method [v3]

On Thu, 11 Aug 2022 23:03:49 GMT, Kevin Rushforth wrote: >> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 13 additional >>

Re: RFR: 8290844: Add Skin.install() method [v3]

On Thu, 11 Aug 2022 22:47:28 GMT, Kevin Rushforth wrote: >> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 13 additional >>

Re: RFR: 8235491: Tree/TableView: implementation of isSelected(int) violates contract [v11]

> 1. reword SelectionModel.isSelected(int) javadoc, removing incorrect > statement "Is functionally equivalent to calling > getSelectedIndices().contains(index)." > 2. reimplement TableView.TableViewSelectionModel.isSelected(int) method to > return true when at least one cell in *any* column

Re: RFR: 8290844: Add Skin.install() method [v3]

On Thu, 11 Aug 2022 22:19:39 GMT, Andy Goryachev wrote: >> - added Skin.install() >> - javadoc changes for Skinnable.setSkin(Skin) >> >> no code changes for Skinnable.setSkin(Skin) yet. > > Andy Goryachev has updated the pull request with a new target base due to a > merge or a rebase. The

Re: RFR: 8235491: Tree/TableView: implementation of isSelected(int) violates contract [v7]

On Fri, 12 Aug 2022 11:02:35 GMT, Jeanette Winzenburg wrote: > hmm .. in TreeTableViewSelectionModelImplTest, I don't see any of the > testRowSelectionAfterSelectAndHideLastColumnXX nor > testSelectRowWhenInSingleCellSelectionModeIsSelected, what am I missing? you are right... I am so sorry.

Re: RFR: 8290844: Add Skin.install() method [v2]

On Fri, 12 Aug 2022 14:45:13 GMT, Jeanette Winzenburg wrote: > only overriding and implementing `Skin::install` for those built-in controls > where it is needed to fix bugs. It also suggests that this possible > incompatibility ought to be highlighted in a release note (in addition to >

Re: RFR: 8290844: Add Skin.install() method [v2]

On Fri, 12 Aug 2022 14:45:13 GMT, Jeanette Winzenburg wrote: > only one [JDK-8268877](https://bugs.openjdk.org/browse/JDK-8268877) that > can't be handled without some kind of api change There might be more, for example MenuButtonSkinBase:96, MenuButtonSkinBase:105, MenuButtonSkin:108. I

Re: RFR: 8290844: Add Skin.install() method [v2]

On Thu, 11 Aug 2022 23:24:11 GMT, Kevin Rushforth wrote: > > How common do you think this sort of thing is in practice? can't do more than guessing (knowing that companies I worked for had done so before I got my hands onto their code) - so would say it's common enough to cause .. well,

Re: RFR: 8089009: TableView with CONSTRAINED_RESIZE_POLICY incorrectly displays a horizontal scroll bar. [v5]

On Fri, 12 Aug 2022 00:57:14 GMT, Sai Pradeep Dandem wrote: >> **Issue:** >> When the `TableView` is set with built-in `CONSTRAINED_RESIZE_POLICY`, the >> horizontal scroll bar keeps flickering when the `TableView` width is reduced. >> >> **Cause:** >> The table columns widths are recalculated

Re: Proposal: Add Skin.install() method

Zitat von Andy Goryachev : Dear Jeanette: Thank you for responding! You are right - some of the issues in JDK-8241364 ☂ Cleanup skin implementations to allow switching might be caused by other factors. Still, from a pure design

Integrated: 8291630: Update attribution in webkit.md file

On Fri, 12 Aug 2022 11:44:49 GMT, Kevin Rushforth wrote: > We need to update the attribution in `webkit.md` to reflect the latest WebKit > sources and a few missed items. This pull request has now been integrated. Changeset: 33534cb9 Author:Kevin Rushforth URL:

Re: RFR: 8291630: Update attribution in webkit.md file

On Fri, 12 Aug 2022 11:44:49 GMT, Kevin Rushforth wrote: > We need to update the attribution in `webkit.md` to reflect the latest WebKit > sources and a few missed items. LGTM - Marked as reviewed by arapte (Reviewer). PR: https://git.openjdk.org/jfx/pull/868

Re: RFR: 8089009: TableView with CONSTRAINED_RESIZE_POLICY incorrectly displays a horizontal scroll bar. [v3]

On Fri, 12 Aug 2022 00:52:58 GMT, Sai Pradeep Dandem wrote: >> modules/javafx.controls/src/main/java/javafx/scene/control/TableUtil.java >> line 2: >> >>> 1: /* >>> 2: * Copyright (c) 2012, 2016, 2022 Oracle and/or its affiliates. All >>> rights reserved. >> >> Not quite. There should be at

RFR: 8291630: Update attribution in webkit.md file

We need to update the attribution in `webkit.md` to reflect the latest WebKit sources and a few missed items. - Commit messages: - 8291630: Update attribution in webkit.md file Changes: https://git.openjdk.org/jfx/pull/868/files Webrev:

Re: RFR: 8235491: Tree/TableView: implementation of isSelected(int) violates contract [v7]

On Thu, 11 Aug 2022 16:14:08 GMT, Andy Goryachev wrote: > > The tests were added to both TableViewSelectionModelImplTest and > TreeTableViewSelectionModelImplTest. hmm .. in TreeTableViewSelectionModelImplTest, I don't see any of the testRowSelectionAfterSelectAndHideLastColumnXX nor