>
> I tried editing that file, too, but I couldn't get it working. It also
> has almost 80 program and SDK directory entries on its paths that aren't
> on my system at all, so I was reluctant even to start with it.
>
I also have entries there that don't exist. I suspect they have to do with
JavaFX supports animations using the tools in the `javafx.animation`
package, but it lacks an easy way of defining animations in
stylesheets. This feature has often been requested, but is still
missing [0] [1] [2].
While there are several ways to tackle this problem (an alternative
notation is
When you *initially* create the PR you can (and are encouraged to)
rebase your branch on master.
Subsequent updates to bring your branch up-to-date with master should be
done with a "git merge". The contributing guidelines strongly recommend
that you do not rebase your branch once you publish
On 8/15/22 12:32 AM, Nir Lisker wrote:
(I have '%SystemRoot%\system32' which is exported to Cygwin correctly).
That works, too. I have to admit, my troubles on Windows at the time
were self-inflicted. I was trying to reduce my PATH to its minimum
(shown formatted below), but I left off
Normally pulling in changes from master is done by rebasing the branch
on master, while putting in changes from a feature branch into master is
a merge. This avoids making it seem the commits on master are part of
your branch, and even avoids accidentally including something from
master when
> This PR fixes an issue which is probably in JavaFX since VirtualFlow exists.
> While horizontal scrolling any VirtualFlow control the left blue border
> sometimes disappear/gets smaller. (see also image below)
>
> This can be fixed by **snapping** the scroll bar value (similar like e.g. a
>
On Mon, 15 Aug 2022 15:19:38 GMT, Andy Goryachev wrote:
>> The goal of this change is to make sure jfx repo can be imported as a gradle
>> project in eclipse and all nested projects in the workspace compile with no
>> errors.
>>
>> - updated .classpath entries in apps/
>> - added utf-8 prefs
On Sat, 13 Aug 2022 06:58:13 GMT, Sai Pradeep Dandem wrote:
>> **Issue:**
>> When the `TableView` is set with built-in `CONSTRAINED_RESIZE_POLICY`, the
>> horizontal scroll bar keeps flickering when the `TableView` width is reduced.
>>
>> **Cause:**
>> The table columns widths are recalculated
On Mon, 15 Aug 2022 15:37:15 GMT, Jeanette Winzenburg
wrote:
>>> A quick PoC is in [my fork off Andy's
>>> PR](https://github.com/kleopatra/jfx/tree/exp-skin-install-supportsInstall)
>>
>> @kleopatra :
>> Thank you so much for your effort to research the alternatives.
>>
>> The main issue
On Fri, 12 Aug 2022 18:42:16 GMT, Andy Goryachev wrote:
>
> @kleopatra : Thank you so much for your effort to research the alternatives.
>
thinking about alternatives is our job, isn't it :)
> The main issue that necessitates creation of install() and moving it outside
> of the skin's
On Fri, 12 Aug 2022 18:15:37 GMT, Andy Goryachev wrote:
>> - added Skin.install()
>> - javadoc changes for Skinnable.setSkin(Skin)
>>
>> no code changes for Skinnable.setSkin(Skin) yet.
>
> Andy Goryachev has updated the pull request incrementally with one additional
> commit since the last
> The goal of this change is to make sure jfx repo can be imported as a gradle
> project in eclipse and all nested projects in the workspace compile with no
> errors.
>
> - updated .classpath entries in apps/
> - added utf-8 prefs in .settings/
Andy Goryachev has updated the pull request with
It depends on how out of date the PR branch gets from the upstream master.
For long-running PRs it is important to periodically merge master, or at
least to do it as the PR is winding down and before integration. See
JDK-8289751 [1], which was caused by PR #741 [2] being integrated
without
On Fri, 12 Aug 2022 23:23:46 GMT, Andy Goryachev wrote:
>> The goal of this change is to make sure jfx repo can be imported as a gradle
>> project in eclipse and all nested projects in the workspace compile with no
>> errors.
>>
>> - updated .classpath entries in apps/
>> - added utf-8 prefs
.. is something I _personally_ don't like: have to mentally sort the
related from the unrelated commits in the history.
The contributing guidelines do allow intermediate merges (bolding by me)
"If you __need__ to pick up changes from master, you can merge master
into your branch"
my
On Fri, 12 Aug 2022 17:21:24 GMT, Andy Goryachev wrote:
>> 1. reword SelectionModel.isSelected(int) javadoc, removing incorrect
>> statement "Is functionally equivalent to calling
>> getSelectedIndices().contains(index)."
>> 2. reimplement TableView.TableViewSelectionModel.isSelected(int)
On Thu, 11 Aug 2022 17:56:58 GMT, Andy Goryachev wrote:
> unnecessary in the case of TableRow.
that is .. why exactly?
> the change in TreeTableRow was necessary because otherwise selecting a cell
> by mouse selected the whole row.
it still does (if all cells are selected)
see me in
On Fri, 12 Aug 2022 15:08:27 GMT, Andy Goryachev wrote:
>
> you are right... I am so sorry. missed this one while cherry picking from
> another branch. will fix it soon.
no problem, shit happens :)
-
PR: https://git.openjdk.org/jfx/pull/839
On Tue, 2 Aug 2022 10:57:25 GMT, Ambarish Rapte wrote:
>> I'll have a look. What command did you run this test with?
>>
>> Can you also test the point light attenuation under
>> `tests\system\src\test\java\test\javafx\scene\lighting3D\PointLightAttenuationTest.java`?
>> (I think there's a bit
Thanks John. I managed to fix my issue by replacing the paths in the wiki's
'windows_tools.properties' file.
As for your fix, I did delete the build folder and had the VS150COMNTOOLS
variable defined, but didn't know about '/cygdrive/c/Windows/System32' (I
have '%SystemRoot%\system32' which is
20 matches
Mail list logo
