On Fri, 19 Aug 2022 00:18:37 GMT, Nir Lisker wrote:
> Added docs for inherited methods in `Bindings` subclasses.
This pull request has now been integrated.
Changeset: 5c007833
Author:Nir Lisker
URL:
https://git.openjdk.org/jfx/commit/5c00783352940b08f6254d2250524ef804984267
Stats:
On Sat, 20 Aug 2022 00:27:32 GMT, Kevin Rushforth wrote:
>> Added docs for inherited methods in `Bindings` subclasses.
>
> modules/javafx.base/src/main/java/javafx/beans/binding/Bindings.java line 174:
>
>> 172: /**
>> 173: * Returns an immutable list of the
On Fri, 19 Aug 2022 00:18:37 GMT, Nir Lisker wrote:
> Added docs for inherited methods in `Bindings` subclasses.
Looks fine. I left a question about the missing `@return` tags, but it might
not matter here depending on whether the IDEs care.
On Fri, 19 Aug 2022 00:18:37 GMT, Nir Lisker wrote:
> Added docs for inherited methods in `Bindings` subclasses.
I don't mind either way. I initially bundled it with the issue for fixing API
docs, but decoupled it later and just thought it would be fine to do them both.
The changes are very
> The issue is caused by TreeTableRow incorrectly selected when cell selection
> mode is enabled.
>
> Changes:
> - modified TreeTableRow.updateSelection()
Andy Goryachev has updated the pull request incrementally with one additional
commit since the last revision:
8292353: whitespace
On Thu, 18 Aug 2022 09:51:53 GMT, Jeanette Winzenburg
wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8292353: added tests
>
> modules/javafx.controls/src/main/java/javafx/scene/control/TreeTableRow.java
>
On Fri, 19 Aug 2022 00:18:37 GMT, Nir Lisker wrote:
> Added docs for inherited methods in `Bindings` subclasses.
As far as I can tell, none of these are public API and so don't show up in the
docs. (If they were, then the lack of an `@return` in a few places would
generate a warning which we
On Fri, 19 Aug 2022 14:34:19 GMT, Kevin Rushforth wrote:
> Backport fix to substitute openjdk.java.net with openjdk.org. Most of the
> patch applied cleanly, but there were a few files modified in mainline that
> don't exist in jfx17u (so excluded from backport). Additionally, I had to
>
On Fri, 19 Aug 2022 14:34:19 GMT, Kevin Rushforth wrote:
> Backport fix to substitute openjdk.java.net with openjdk.org. Most of the
> patch applied cleanly, but there were a few files modified in mainline that
> don't exist in jfx17u (so excluded from backport). Additionally, I had to
>
On Fri, 19 Aug 2022 00:37:34 GMT, Nir Lisker wrote:
>> Fixes the mistakes in the JBS ticket and some additional minor corrections.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix typo
I took a quick look and don't see
On Fri, 19 Aug 2022 14:54:11 GMT, Andy Goryachev wrote:
> Would these changes require a CSR? Or, since they are just corrections, the
> API did not really change? Otherwise, looks good. Thank you for cleaning up
> the docs!
Usually they don't since there are no spec changes.
-
On Fri, 19 Aug 2022 07:36:12 GMT, Florian Kirmaier
wrote:
>> This PR switches the Thread to the QuantumRenderer, in the case the Disposer
>> is called from another Thread - the printing Thread.
>> I'm open for better solutions on how to fix this Issue.
>> Initially i thought there is also a
> The issue is caused by TreeTableRow incorrectly selected when cell selection
> mode is enabled.
>
> Changes:
> - modified TreeTableRow.updateSelection()
Andy Goryachev has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the
On Fri, 19 Aug 2022 14:34:19 GMT, Kevin Rushforth wrote:
> Backport fix to substitute openjdk.java.net with openjdk.org. Most of the
> patch applied cleanly, but there were a few files modified in mainline that
> don't exist in jfx17u (so excluded from backport). Additionally, I had to
>
On Fri, 19 Aug 2022 09:02:55 GMT, Jeanette Winzenburg
wrote:
> hmm ... where are the tests ;)
good point. will do.
-
PR: https://git.openjdk.org/jfx/pull/876
On Fri, 19 Aug 2022 14:34:19 GMT, Kevin Rushforth wrote:
> Backport fix to substitute openjdk.java.net with openjdk.org. Most of the
> patch applied cleanly, but there were a few files modified in mainline that
> don't exist in jfx17u (so excluded from backport). Additionally, I had to
>
On Fri, 19 Aug 2022 14:34:19 GMT, Kevin Rushforth wrote:
> Backport fix to substitute openjdk.java.net with openjdk.org. Most of the
> patch applied cleanly, but there were a few files modified in mainline that
> don't exist in jfx17u (so excluded from backport). Additionally, I had to
>
On Fri, 19 Aug 2022 00:37:34 GMT, Nir Lisker wrote:
>> Fixes the mistakes in the JBS ticket and some additional minor corrections.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix typo
Would these changes require a CSR?
On Wed, 17 Aug 2022 02:21:30 GMT, Sai Pradeep Dandem wrote:
>> **Issue:**
>> When the `TableView` is set with built-in `CONSTRAINED_RESIZE_POLICY`, the
>> horizontal scroll bar keeps flickering when the `TableView` width is reduced.
>>
>> **Cause:**
>> The table columns widths are recalculated
Backport fix to substitute openjdk.java.net with openjdk.org. Most of the patch
applied cleanly, but there were a few files modified in mainline that don't
exist in jfx17u (so excluded from backport). Additionally, I had to manually
update the following:
CONTRIBUTING.md
README.md
On Fri, 19 Aug 2022 14:34:19 GMT, Kevin Rushforth wrote:
> Backport fix to substitute openjdk.java.net with openjdk.org. Most of the
> patch applied cleanly, but there were a few files modified in mainline that
> don't exist in jfx17u (so excluded from backport). Additionally, I had to
>
Clean backport.
-
Commit messages:
- 8288450: Update attribution in gstreamer.md file
Changes: https://git.openjdk.org/jfx17u/pull/79/files
Webrev: https://webrevs.openjdk.org/?repo=jfx17u=79=00
Issue: https://bugs.openjdk.org/browse/JDK-8288450
Stats: 6943 lines in 3 files
On Wed, 17 Aug 2022 02:21:30 GMT, Sai Pradeep Dandem wrote:
>> **Issue:**
>> When the `TableView` is set with built-in `CONSTRAINED_RESIZE_POLICY`, the
>> horizontal scroll bar keeps flickering when the `TableView` width is reduced.
>>
>> **Cause:**
>> The table columns widths are recalculated
On Fri, 19 Aug 2022 09:19:59 GMT, Florian Kirmaier
wrote:
> So it might be an option, to change this PR to only contain the null check.
If that is the route you want to go, then filing a new issue / PR is better. A
fix with a null check might be a good option as long as we understand why the
On Fri, 19 Aug 2022 07:48:18 GMT, Ambarish Rapte wrote:
> Looks like this is an existing issue, as we replace tabs with 4 spaces.
> We have several such existing instances of incorrect layout.
Perhaps it would be better to replace TABS with 8 spaces for libjpeg since it
looks like that is what
On Thu, 18 Aug 2022 22:22:36 GMT, Kevin Rushforth wrote:
> Use the system version of `ant` on macOS platforms rather than downloading it
> from apache.org.
>
> As noted in the bug report, we are seeing frequent GitHub Actions (GHA)
> failures on macOS due to a timeout while attempting to
On Fri, 19 Aug 2022 07:36:12 GMT, Florian Kirmaier
wrote:
>> This PR switches the Thread to the QuantumRenderer, in the case the Disposer
>> is called from another Thread - the printing Thread.
>> I'm open for better solutions on how to fix this Issue.
>> Initially i thought there is also a
On Thu, 18 Aug 2022 23:50:03 GMT, Nir Lisker wrote:
> ```
> fatal: ambiguous argument 'upstream/jfx19': unknown revision or path not in
> the working tree.
> ```
I should have said "presuming you have a remote configured with the name
`upstream`". Anyway, what you did was good.
-
On Fri, 19 Aug 2022 10:40:01 GMT, Florian Kirmaier
wrote:
>> Making the initial listener of the ListProperty weak fixes the problem.
>> The same is fixed for Set and Map.
>> Due to a smart implementation, this is done without any performance drawback.
>> (The trick is to have an object, which
> Making the initial listener of the ListProperty weak fixes the problem.
> The same is fixed for Set and Map.
> Due to a smart implementation, this is done without any performance drawback.
> (The trick is to have an object, which is both the WeakReference and the
> Changelistener)
> By implying
On Thu, 27 Jan 2022 14:50:16 GMT, Florian Kirmaier
wrote:
>> After thinking about this issue for some time, I've now got a solution.
>> I know put the scene in the state it is, before is was shown, when the
>> dirtyNodes are unset, the whole scene is basically considered dirty.
>> This has
On Tue, 26 Jul 2022 11:51:10 GMT, Florian Kirmaier
wrote:
>> It's "a bit" complicated.
>> In some situations, getRuns get's called because listeners on bounds are set.
>> This causes TextFlow to layout to compute the runs.
>> Afterward, the bounds of the parents get updated.
>> This triggers a
On Thu, 18 Aug 2022 16:24:11 GMT, Andy Goryachev wrote:
> Setting a null selection model in TableView and TreeTableView produce NPE on
> sorting (and probably in some other situations) because the check for null is
> missing in several places.
>
> Setting a null selection model is a valid
On Wed, 3 Aug 2022 15:22:13 GMT, Kevin Rushforth wrote:
>> I've worked in the feedback, thank you @kevinrushforth
>> Small note, this change is not used for a while and is therefore well tested.
>
> @FlorianKirmaier This PR is pending the following:
> 1. Merge upstream master into your PR
On Wed, 17 Aug 2022 20:44:52 GMT, Kevin Rushforth wrote:
> I left a couple comments on questionable-looking indentation.
Hi Kevin, Looks like this is an existing issue, as we replace tabs with 4
spaces.
We have several such existing instances of incorrect layout.
1.
35 matches
Mail list logo
