On Wed, 17 Aug 2022 08:26:48 GMT, Ambarish Rapte wrote:
> Accessibility is not implemented for JavaFX dialogs. This change is to
> implement the accessibility on windows platform.
> Without this fix : On Windows platform, content of Dialog are not read by
> Windows Narrator or JAWS.
> With
On Fri, 19 Aug 2022 00:37:34 GMT, Nir Lisker wrote:
>> Fixes the mistakes in the JBS ticket and some additional minor corrections.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix typo
A few comments inline.
> The issue is caused by TreeTableRow incorrectly selected when cell selection
> mode is enabled.
>
> Changes:
> - modified TreeTableRow.updateSelection()
Andy Goryachev has updated the pull request incrementally with two additional
commits since the last revision:
- 8292353: typo
-
> Setting a null selection model in TableView and TreeTableView produce NPE on
> sorting (and probably in some other situations) because the check for null is
> missing in several places.
>
> Setting a null selection model is a valid way to disable selection in a
> (tree)table.
>
> There is
> Setting a null selection model in TableView and TreeTableView produce NPE on
> sorting (and probably in some other situations) because the check for null is
> missing in several places.
>
> Setting a null selection model is a valid way to disable selection in a
> (tree)table.
>
> There is
On Tue, 16 Aug 2022 11:57:45 GMT, Ajit Ghaisas wrote:
>> This PR fixes an issue when there is a DialogPane that has no header and no
>> graphic is set, by adding the `graphic-container` styleclass only when there
>> is a non-null graphic applied, preventing the padding that otherwise the
>>
On Sat, 8 Jan 2022 00:17:36 GMT, Marius Hanl wrote:
> This PR fixes a bunch of NPEs when a null `SelectionModel` or `FocusModel` is
> set on a `ListView`.
>
> The following NPEs are fixed (all are also covered by exactly one test case):
> NPEs with null selection model:
> - Mouse click on a
On Mon, 22 Aug 2022 15:43:28 GMT, Jeanette Winzenburg
wrote:
>> There is also an unguarded access in CellBehaviorBase.selectRows(int,int) :
>> 312 and CellBehaviorBase.sompleSelect(MouseButton,int,boolean) : 274, which
>> are being fixed by #876
>>
>> I'd suggest to integrate #876 first,
On Tue, 2 Aug 2022 10:45:54 GMT, Jose Pereda wrote:
> This PR fixes an issue when there is a DialogPane that has no header and no
> graphic is set, by adding the `graphic-container` styleclass only when there
> is a non-null graphic applied, preventing the padding that otherwise the
> graphic
On Sat, 8 Jan 2022 00:17:36 GMT, Marius Hanl wrote:
> This PR fixes a bunch of NPEs when a null `SelectionModel` or `FocusModel` is
> set on a `ListView`.
>
> The following NPEs are fixed (all are also covered by exactly one test case):
> NPEs with null selection model:
> - Mouse click on a
On Mon, 22 Aug 2022 15:43:28 GMT, Jeanette Winzenburg
wrote:
>> There is also an unguarded access in CellBehaviorBase.selectRows(int,int) :
>> 312 and CellBehaviorBase.sompleSelect(MouseButton,int,boolean) : 274, which
>> are being fixed by #876
>>
>> I'd suggest to integrate #876 first,
On Mon, 22 Aug 2022 15:29:29 GMT, Andy Goryachev wrote:
> There is also an unguarded access in CellBehaviorBase.selectRows(int,int) :
> 312 and CellBehaviorBase.sompleSelect(MouseButton,int,boolean) : 274, which
> are being fixed by #876
>
> I'd suggest to integrate #876 first, followed by
On Sat, 8 Jan 2022 00:17:36 GMT, Marius Hanl wrote:
> This PR fixes a bunch of NPEs when a null `SelectionModel` or `FocusModel` is
> set on a `ListView`.
>
> The following NPEs are fixed (all are also covered by exactly one test case):
> NPEs with null selection model:
> - Mouse click on a
On Tue, 26 Jul 2022 11:51:10 GMT, Florian Kirmaier
wrote:
>> It's "a bit" complicated.
>> In some situations, getRuns get's called because listeners on bounds are set.
>> This causes TextFlow to layout to compute the runs.
>> Afterward, the bounds of the parents get updated.
>> This triggers a
> It's "a bit" complicated.
> In some situations, getRuns get's called because listeners on bounds are set.
> This causes TextFlow to layout to compute the runs.
> Afterward, the bounds of the parents get updated.
> This triggers a call to compute bounds - which cascades up to the children.
>
15 matches
Mail list logo
