On Wed, 31 Aug 2022 14:19:03 GMT, Douglas Held wrote:
> Fix two typos in the JavaDoc. The links for the vertical property link to the
> horizontal property.
>
> It's my first commit, so please comment if I haven't followed the commit
> protocol per expectations.
>
> Note, I no longer have a
On Thu, 1 Sep 2022 17:38:39 GMT, Nir Lisker wrote:
>> Edit: I missed some nuance, below is the correct version.
>>
>> There are three objects involved here: the parent observable, the new
>> observable and the conditional.
>>
>> What `when` should achieve is to make the new observable and
On Wed, 10 Aug 2022 06:56:50 GMT, Ajit Ghaisas wrote:
> A null check has been added to below SpinnerValueFactory classes in
> valueProperty() ChangeListeners-
> - `IntegerSpinnerValueFactory`
> - `LocalDateSpinnerValueFactory`
> - `LocalTimeSpinnerValueFactory`
> - `ListSpinnerValueFactory`
>
Fix two typos in the JavaDoc. The links for the vertical property link to the
horizontal property.
It's my first commit, so please comment if I haven't followed the commit
protocol per expectations.
Note, I no longer have a handle to the JBS title for record 9073896. The record
is not
On Wed, 31 Aug 2022 14:19:03 GMT, Douglas Held wrote:
> Note, I no longer have a handle to the JBS title for record 9073896.
That's because it is a temporary, internal ID. Once it is transferred to the
JDK project in JBS, it will be assigned a (different) permanent ID. I just did
that, so
On Wed, 10 Aug 2022 09:40:02 GMT, Ajit Ghaisas wrote:
>> A null check has been added to below SpinnerValueFactory classes in
>> valueProperty() ChangeListeners-
>> - `IntegerSpinnerValueFactory`
>> - `LocalDateSpinnerValueFactory`
>> - `LocalTimeSpinnerValueFactory`
>> -
On Wed, 24 Aug 2022 16:16:41 GMT, Andy Goryachev wrote:
> the problem, as i see it, is that dispose() of the previous skin is executed
> after the new skin is attached. literally nothing can be done to work around
> the issues caused by this design mistake, but to fix it outright - dispose()
On Thu, 1 Sep 2022 13:51:21 GMT, John Hendrikx wrote:
>> This PR adds a new (lazy*) property on `Node` which provides a boolean which
>> indicates whether or not the `Node` is currently part of a `Scene`, which in
>> turn is part of a currently showing `Window`.
>>
>> It also adds a new
On Thu, 1 Sep 2022 13:10:49 GMT, John Hendrikx wrote:
>> modules/javafx.base/src/main/java/javafx/beans/value/ObservableValue.java
>> line 266:
>>
>>> 264: * {@code condition} evaluates to {@code true}. This allows this
>>> {@code ObservableValue}
>>> 265: * and the conditional
On Thu, 1 Sep 2022 13:38:46 GMT, John Hendrikx wrote:
>> modules/javafx.base/src/main/java/javafx/beans/value/ObservableValue.java
>> line 274:
>>
>>> 272: *
>>> 273: * Returning {@code null} from the given condition is treated the
>>> same as
>>> 274: * returning {@code
On Thu, 1 Sep 2022 14:47:17 GMT, Kevin Rushforth wrote:
> This is an effectively clean backport. The only difference is that one of the
> lines removed by the patch (removed both in jfx mainline and here) had been
> modified in jfx mainline to update the copyright year (modified incorrectly,
On Thu, 1 Sep 2022 14:39:49 GMT, Kevin Rushforth wrote:
> Clean backport. CI build passed on all platforms.
This pull request has now been integrated.
Changeset: c6370fb3
Author:Kevin Rushforth
URL:
https://git.openjdk.org/jfx17u/commit/c6370fb3c15e8cdfc781c2e0e3cccb44091fc0d9
On Thu, 1 Sep 2022 14:47:17 GMT, Kevin Rushforth wrote:
> This is an effectively clean backport. The only difference is that one of the
> lines removed by the patch (removed both in jfx mainline and here) had been
> modified in jfx mainline to update the copyright year (modified incorrectly,
On Thu, 1 Sep 2022 14:47:17 GMT, Kevin Rushforth wrote:
> This is an effectively clean backport. The only difference is that one of the
> lines removed by the patch (removed both in jfx mainline and here) had been
> modified in jfx mainline to update the copyright year (modified incorrectly,
On Thu, 1 Sep 2022 11:23:44 GMT, Nir Lisker wrote:
>> Refactoring and renaming changes to some of the D3D pipeline files and a few
>> changes on the Java side. These are various "leftovers" from previous issues
>> that we didn't want to touch at the time in order to confine the scope of
>>
This is an effectively clean backport. The only difference is that one of the
lines removed by the patch (removed both in jfx mainline and here) had been
modified in jfx mainline to update the copyright year (modified incorrectly, as
it turns out, but that's no longer relevant since the line
On Thu, 1 Sep 2022 12:51:34 GMT, Kevin Rushforth wrote:
> The easiest way is to push an empty commit to your branch.
Thanks, @kevinrushforth . The GHA tests passed. Some additional test results
were updated in the PR description.
-
PR: https://git.openjdk.org/jfx/pull/888
Clean backport. CI build passed on all platforms.
-
Commit messages:
- 8292609: Cherry-pick WebKit 614.1 stabilization fixes
Changes: https://git.openjdk.org/jfx17u/pull/81/files
Webrev: https://webrevs.openjdk.org/?repo=jfx17u=81=00
Issue:
On Wed, 31 Aug 2022 16:52:12 GMT, Nir Lisker wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Rename showing property to shown as it is already used in subclasses
>
>
Please ignore the explanation below it is incorrect (I forgot that
conditional and new observable reference each other).
I've updated the comment on Github, not sure if these edits will show on
the mailinglist.
--John
On 01/09/2022 15:14, John Hendrikx wrote:
On Wed, 31 Aug 2022 17:04:31
> This PR adds a new (lazy*) property on `Node` which provides a boolean which
> indicates whether or not the `Node` is currently part of a `Scene`, which in
> turn is part of a currently showing `Window`.
>
> It also adds a new fluent binding method on `ObservableValue` dubbed `when`
> (open
On Wed, 31 Aug 2022 17:21:33 GMT, Nir Lisker wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Rename showing property to shown as it is already used in subclasses
>
>
On Thu, 1 Sep 2022 13:42:26 GMT, John Hendrikx wrote:
>> modules/javafx.base/src/main/java/javafx/beans/value/ObservableValue.java
>> line 302:
>>
>>> 300: * ObservableValue globalProperty = new
>>> SimpleStringProperty("A");
>>> 301: *
>>> 302: * // bind label's text to a
On Wed, 31 Aug 2022 17:19:37 GMT, Nir Lisker wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Rename showing property to shown as it is already used in subclasses
>
>
On Wed, 31 Aug 2022 17:04:31 GMT, Nir Lisker wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Rename showing property to shown as it is already used in subclasses
>
>
> LoongArch is a new RISC ISA. This issue proposes adding support for
> Linux/LoongArch64. Upstream WebKit for LoongArch64 support is not ready, but
> the OpenJFX part is simple and ready. When the LoongArch64 supported Webkit
> is updated to OpenJFX, it is supposed to work.
Ao Qi has updated
> LoongArch is a new RISC ISA. This issue proposes adding support for
> Linux/LoongArch64. Upstream WebKit for LoongArch64 support is not ready, but
> the OpenJFX part is simple and ready. When the LoongArch64 supported Webkit
> is updated to OpenJFX, it is supposed to work.
Ao Qi has updated
On Thu, 1 Sep 2022 12:19:23 GMT, Ao Qi wrote:
> LoongArch is a new RISC ISA. This issue proposes adding support for
> Linux/LoongArch64. Upstream WebKit for LoongArch64 support is not ready, but
> the OpenJFX part is simple and ready. When the LoongArch64 supported Webkit
> is updated to
On Wed, 31 Aug 2022 16:54:32 GMT, Nir Lisker wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Rename showing property to shown as it is already used in subclasses
>
>
On Thu, 1 Sep 2022 12:19:23 GMT, Ao Qi wrote:
> LoongArch is a new RISC ISA. This issue proposes adding support for
> Linux/LoongArch64. Upstream WebKit for LoongArch64 support is not ready, but
> the OpenJFX part is simple and ready. When the LoongArch64 supported Webkit
> is updated to
On Thu, 1 Sep 2022 12:19:23 GMT, Ao Qi wrote:
> LoongArch is a new RISC ISA. This issue proposes adding support for
> Linux/LoongArch64. Upstream WebKit for LoongArch64 support is not ready, but
> the OpenJFX part is simple and ready. When the LoongArch64 supported Webkit
> is updated to
On Wed, 31 Aug 2022 17:33:41 GMT, Nir Lisker wrote:
>> modules/javafx.base/src/main/java/javafx/beans/value/ObservableValue.java
>> line 311:
>>
>>> 309: * @since 20
>>> 310: */
>>> 311: default ObservableValue when(ObservableValue
>>> condition) {
>>
>> Discussion: name?
LoongArch is a new RISC ISA. This issue proposes adding support for
Linux/LoongArch64. Upstream WebKit for LoongArch64 support is not ready, but
the OpenJFX part is simple and ready. When the LoongArch64 supported Webkit is
updated to OpenJFX, it is supposed to work.
-
Commit
On Thu, 1 Sep 2022 05:35:09 GMT, Ambarish Rapte wrote:
>> I still don't understand. What is `VertexType`? I see a comment on `VsInput`
>> "// this is a .hlsl mirror of the vertex format, see VertexTypes.h". If the
>> gradle file has `"/DVertexType=VsInput"`, shouldn't it be fine with
>>
> Refactoring and renaming changes to some of the D3D pipeline files and a few
> changes on the Java side. These are various "leftovers" from previous issues
> that we didn't want to touch at the time in order to confine the scope of the
> changes. They will make future work easier.
>
> Since
On Mon, 22 Aug 2022 17:49:41 GMT, Andy Goryachev wrote:
> you are right! unless, of course, someone writes code to invoke these methods
> directly. For example, simpleSelect() is protected, so any Behavior that
> extends CellBehaviorBase might encounter an NPE.
No strong opinion here but I
36 matches
Mail list logo
