Re: RFR: 8087673: [TableView] TableView and TreeTableView menu button overlaps columns when using a constrained resize policy. [v3]

2022-09-04 Thread Ajit Ghaisas
On Tue, 30 Aug 2022 11:21:26 GMT, Jose Pereda wrote: >> The corner region is currently laid out with this assumption: >> >> // position the top-right rectangle (which sits above the scrollbar) >> >> However, the vertical scrollbar is not always visible. Therefore, when that >> is the c

Re: RFR: 8290040: Provide simplified deterministic way to manage listeners [v2]

2022-09-04 Thread John Hendrikx
On Wed, 31 Aug 2022 17:07:17 GMT, Nir Lisker wrote: >> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Rename showing property to shown as it is already used in subclasses > > modules/javafx.base/src/main/java/javafx/beans/

Re: RFR: 8290040: Provide simplified deterministic way to manage listeners [v3]

2022-09-04 Thread John Hendrikx
On Thu, 1 Sep 2022 17:51:20 GMT, Nir Lisker wrote: >> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update javadoc of "when" with better phrasing > > modules/javafx.base/src/main/java/javafx/beans/value/ObservableValue.ja

Re: RFR: 8290040: Provide simplified deterministic way to manage listeners [v4]

2022-09-04 Thread John Hendrikx
> This PR adds a new (lazy*) property on `Node` which provides a boolean which > indicates whether or not the `Node` is currently part of a `Scene`, which in > turn is part of a currently showing `Window`. > > It also adds a new fluent binding method on `ObservableValue` dubbed `when` > (open f