Re: RFR: 8290040: Provide simplified deterministic way to manage listeners [v4]

2022-09-21 Thread Nir Lisker
On Sun, 4 Sep 2022 19:49:42 GMT, John Hendrikx wrote: >> This PR adds a new (lazy*) property on `Node` which provides a boolean which >> indicates whether or not the `Node` is currently part of a `Scene`, which in >> turn is part of a currently showing `Window`. >> >> It also adds a new

Re: RFR: JDK-8289541 : Update ICU4C to 71.1 [v6]

2022-09-21 Thread Johan Vos
On Wed, 21 Sep 2022 16:36:48 GMT, Kevin Rushforth wrote: > @johanvos or @tiainen can you do a test build? building + testing - PR: https://git.openjdk.org/jfx/pull/893

Re: RFR: JDK-8289541 : Update ICU4C to 71.1 [v6]

2022-09-21 Thread Kevin Rushforth
On Wed, 21 Sep 2022 16:32:09 GMT, Hima Bindu Meda wrote: >> Updated icu to v71.1. >> Verified build and sanity testing on windows,Mac and Linux. >> Removed icu directory from Source/WTF, as the functionality is already >> provided by Source/ThirdParty/icu > > Hima Bindu Meda has updated the

Re: RFR: JDK-8289541 : Update ICU4C to 71.1 [v5]

2022-09-21 Thread Hima Bindu Meda
On Wed, 21 Sep 2022 13:17:34 GMT, Kevin Rushforth wrote: >> Hima Bindu Meda has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update icu_web.md > > modules/javafx.web/src/main/legal/icu_web.md line 446: > >> 444: suitability of this

Re: RFR: JDK-8289541 : Update ICU4C to 71.1 [v6]

2022-09-21 Thread Hima Bindu Meda
> Updated icu to v71.1. > Verified build and sanity testing on windows,Mac and Linux. > Removed icu directory from Source/WTF, as the functionality is already > provided by Source/ThirdParty/icu Hima Bindu Meda has updated the pull request incrementally with one additional commit since the last

Re: RFR: 8292353: TableRow vs. TreeTableRow: inconsistent visuals in cell selection mode [v11]

2022-09-21 Thread Andy Goryachev
On Wed, 21 Sep 2022 06:15:06 GMT, Ajit Ghaisas wrote: >> I don't understand. It fails for me >> >> >> TreeTableRowTest > test_TreeTableView_jdk_8292353_select_all_but_one FAILED >> org.opentest4j.AssertionFailedError: expected: but was: >> at >>

Re: RFR: JDK-8269921 Text in Textflow and listeners on bounds can cause endless loop/crash and other performance issues [v3]

2022-09-21 Thread Michael Strauß
On Fri, 5 Aug 2022 07:34:43 GMT, Marius Hanl wrote: >> Florian Kirmaier has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >>

Re: RFR: JDK-8289541 : Update ICU4C to 71.1 [v5]

2022-09-21 Thread Kevin Rushforth
On Wed, 21 Sep 2022 07:53:42 GMT, Hima Bindu Meda wrote: >> Updated icu to v71.1. >> Verified build and sanity testing on windows,Mac and Linux. >> Removed icu directory from Source/WTF, as the functionality is already >> provided by Source/ThirdParty/icu > > Hima Bindu Meda has updated the

Re: RFR: JDK-8269921 Text in Textflow and listeners on bounds can cause endless loop/crash and other performance issues [v4]

2022-09-21 Thread Florian Kirmaier
On Mon, 22 Aug 2022 09:46:24 GMT, Florian Kirmaier wrote: >> It's "a bit" complicated. >> In some situations, getRuns get's called because listeners on bounds are set. >> This causes TextFlow to layout to compute the runs. >> Afterward, the bounds of the parents get updated. >> This triggers a

Re: Provide Quit handler for system menu bar

2022-09-21 Thread Florian Kirmaier
Yes, a custom "about menu" handling would be very similar and could be implemented at the same time. It's worth mentioning, that we cannot use the methods java.awt.Desktop setAboutHandler and setQuitHandler methods, because they only work, if the menu is from Swing. They don't work when the menu

Re: RFR: 8254676: Alert disables Tab selection when TabDragPolicy REORDER is used

2022-09-21 Thread Johan Vos
On Mon, 19 Sep 2022 11:43:41 GMT, Ambarish Rapte wrote: > The fix looks good to me. Testing looks good. But I am not sure why I had > included this call at the time of implementation. Requesting @kevinrushforth > to take a look. I was wondering about the original reason to include these

Re: RFR: JDK-8289541 : Update ICU4C to 71.1 [v5]

2022-09-21 Thread Hima Bindu Meda
> Updated icu to v71.1. > Verified build and sanity testing on windows,Mac and Linux. > Removed icu directory from Source/WTF, as the functionality is already > provided by Source/ThirdParty/icu Hima Bindu Meda has updated the pull request incrementally with one additional commit since the last

Re: RFR: 8292353: TableRow vs. TreeTableRow: inconsistent visuals in cell selection mode [v12]

2022-09-21 Thread Ajit Ghaisas
On Tue, 20 Sep 2022 19:06:19 GMT, Andy Goryachev wrote: >> The issue is caused by TreeTableRow incorrectly selected when cell selection >> mode is enabled. >> >> Changes: >> - modified TreeTableRow.updateSelection() > > Andy Goryachev has updated the pull request incrementally with one

Re: RFR: 8292353: TableRow vs. TreeTableRow: inconsistent visuals in cell selection mode [v11]

2022-09-21 Thread Ajit Ghaisas
On Tue, 20 Sep 2022 18:59:40 GMT, Andy Goryachev wrote: >> modules/javafx.controls/src/test/java/test/javafx/scene/control/TreeTableRowTest.java >> line 840: >> >>> 838: /** TreeTableView with cell selection enabled should not select >>> TreeTableRows */ >>> 839: @Test >>> 840: