On Mon, 26 Sep 2022 15:16:34 GMT, Andy Goryachev wrote:
>> Alexander Matveev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8293971: Loading new Media from resources can sometimes fail when loading
>> from FXML [v2]
>
>
On Sat, 24 Sep 2022 03:07:00 GMT, Alexander Matveev
wrote:
> There was two problems:
> - uri.getPath() was returning null for jar URI, since it is not a standard
> URI and thus we did not detect file type based on extension.
> - Our signature detection for MP3 had a bug and did not detect
> There was two problems:
> - uri.getPath() was returning null for jar URI, since it is not a standard
> URI and thus we did not detect file type based on extension.
> - Our signature detection for MP3 had a bug and did not detect MP3
> correctly. See comments in code.
>
> Fixed by adding
On Thu, 22 Sep 2022 11:04:46 GMT, John Hendrikx wrote:
>> This PR adds a new (lazy*) property on `Node` which provides a boolean which
>> indicates whether or not the `Node` is currently part of a `Scene`, which in
>> turn is part of a currently showing `Window`.
>>
>> It also adds a new
On Mon, 26 Sep 2022 22:57:37 GMT, Alexander Matveev
wrote:
>> modules/javafx.media/src/main/java/com/sun/media/jfxmediaimpl/MediaUtils.java
>> line 154:
>>
>>> 152: } else if ((buf[0] & 0xff) == 0xff && (buf[1] & 0xe0) == 0xe0
>>> && // sync
>>> 153: (buf[1] & 0x18)
On Mon, 26 Sep 2022 15:14:46 GMT, Andy Goryachev wrote:
>> There was two problems:
>> - uri.getPath() was returning null for jar URI, since it is not a standard
>> URI and thus we did not detect file type based on extension.
>> - Our signature detection for MP3 had a bug and did not detect
On Sat, 24 Sep 2022 03:07:00 GMT, Alexander Matveev
wrote:
> There was two problems:
> - uri.getPath() was returning null for jar URI, since it is not a standard
> URI and thus we did not detect file type based on extension.
> - Our signature detection for MP3 had a bug and did not detect
