RFR: 8287822: [macos] Remove support of duplicated formats from macOS

2022-10-10 Thread Alexander Matveev
- Added support for JAR and JRT protocol to AVFoundation platform. - Removed H.264/MP3 and AAC support from GStreamer platform, which was primary used to playback these formats for JAR and JRT protocols. - Added ability to FXMediaPlayer sample to generate playlist for JAR and JRT protocols for

Re: RFR: 8260528: Clean glass-gtk sizing and positioning code [v25]

2022-10-10 Thread Thiago Milczarek Sayao
On Fri, 30 Sep 2022 06:49:40 GMT, Johan Vos wrote: >> Testing: >> >> **master** >> ![master](https://user-images.githubusercontent.com/30704286/111889893-6e793f80-89c3-11eb-8f38-640e8123794c.png) >> >> **tsayao:glass_gtk_new_position_and_size** >> ![branch](https://user-images.githubusercontent

Re: RFR: 8294589: MenuBarSkin: memory leak when changing skin [v2]

2022-10-10 Thread Andy Goryachev
> Fixed memory leak by using weak listeners and making sure to undo everything > that has been done to MenuBar/Skin in dispose(). Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision: 8294589: unnecessary null checks - Chan

Re: RFR: 8191995: Regression: DatePicker must commit on focusLost

2022-10-10 Thread Kevin Rushforth
Thanks for reporting this. -- Kevin On 10/10/2022 10:15 AM, Dirk Lemmermann wrote: Just submitted a bug report related to this issue. The DatePicker could now commit back to the old / previous value when the user selection of a new date via the dropdown also triggers the closing of the dialo

Re: RFR: 8290844: Add Skin.install() method [v12]

2022-10-10 Thread Andy Goryachev
> - added Skin.install() > - javadoc changes for Skinnable.setSkin(Skin) Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision: 8290844: review comments - Changes: - all: https://git.openjdk.org/jfx/pull/845/files - new:

Re: RFR: 8290844: Add Skin.install() method [v11]

2022-10-10 Thread Andy Goryachev
On Fri, 7 Oct 2022 22:51:07 GMT, Kevin Rushforth wrote: >> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 24 additional >> commi

Re: RFR: 8191995: Regression: DatePicker must commit on focusLost

2022-10-10 Thread Dirk Lemmermann
Just submitted a bug report related to this issue. The DatePicker could now commit back to the old / previous value when the user selection of a new date via the dropdown also triggers the closing of the dialog that is showing the date picker. In that case the newly added commitValue() method wi

TextField blurry inside AnchorPane - Is it a bug?

2022-10-10 Thread Thiago Milczarek SayĆ£o
Hi, This FXML below (just open on SceneBuilder) causes the TextField to be blurry. I'm not sure if it's expected or a bug. Possibly the same as: https://bugs.openjdk.org/browse/JDK-8089499 http://javafx.com/fxml/1"; xmlns="http://javafx.com/javafx/16";>