On Tue, 18 Oct 2022 22:15:35 GMT, Douglas Held wrote:
>> The JavaDoc for equals had a copy/paste error. I normalized the text based
>> on the JavaDoc for method java.awt.Point#equals. ~~I also changed formatting
>> in the method signatures of equals(), hashCode() and toString().~~
>>
>> For go
On Tue, 18 Oct 2022 11:32:04 GMT, Nir Lisker wrote:
>> Agreed, mentioning equality criteria sounds good to me too. How does this
>> look ?
>>
>>
>> /**
>> * Indicates whether some other object is "equal to" this one.
>> * Two instances of Point3D are equal if the return values of
On Thu, 13 Oct 2022 14:16:23 GMT, Nir Lisker wrote:
>> Douglas Held has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update Point3D.java
>>
>> Per review
>
> Changes requested by nlisker (Reviewer).
Tagged @nlisker to validate the c
> The JavaDoc for equals had a copy/paste error. I normalized the text based on
> the JavaDoc for method java.awt.Point#equals. ~~I also changed formatting in
> the method signatures of equals(), hashCode() and toString().~~
>
> For good measure, some kind of copy/paste detection should probably
On Tue, 18 Oct 2022 17:47:38 GMT, Michael Strauß wrote:
>> I'd respectfully disagree: in a large application, there might be hundreds
>> (a thousand?) Nodes, and only a handful (10-20?) Nodes with this property
>> (2%), so it's a waste of RAM. One may think it's only 8Kb on a 64 bit
>> machin
On Tue, 18 Oct 2022 18:06:49 GMT, Nir Lisker wrote:
> `getProperties()` isn't the place for this.
can you explain why?
-
PR: https://git.openjdk.org/jfx/pull/830
On Tue, 18 Oct 2022 17:47:38 GMT, Michael Strauß wrote:
>> I'd respectfully disagree: in a large application, there might be hundreds
>> (a thousand?) Nodes, and only a handful (10-20?) Nodes with this property
>> (2%), so it's a waste of RAM. One may think it's only 8Kb on a 64 bit
>> machin
On Tue, 18 Oct 2022 16:03:39 GMT, Andy Goryachev wrote:
> I'd respectfully disagree: in a large application, there might be hundreds (a
> thousand?) Nodes, and only a handful (10-20?) Nodes with this property (2%),
> so it's a waste of RAM. One may think it's only 8Kb on a 64 bit machine, but
On Tue, 18 Oct 2022 12:54:22 GMT, Kevin Rushforth wrote:
>> Thanks, I understand, what I find odd is that this would be the first
>> property in `Node` to be stored this way. If this was so important, then
>> why isn't this done for other properties? There seem to be sufficient
>> candidates
On Mon, 17 Oct 2022 09:36:55 GMT, Ambarish Rapte wrote:
> Update Copyright year in these 3 doc files to 2023.
This pull request has now been integrated.
Changeset: f448e9ad
Author:Ambarish Rapte
URL:
https://git.openjdk.org/jfx/commit/f448e9ad589caa01f24c345d1db37c933c8e0dc8
Stats:
On Thu, 1 Sep 2022 11:23:44 GMT, Nir Lisker wrote:
>> Refactoring and renaming changes to some of the D3D pipeline files and a few
>> changes on the Java side. These are various "leftovers" from previous issues
>> that we didn't want to touch at the time in order to confine the scope of
>> the
On Mon, 27 Apr 2020 11:43:28 GMT, John Hendrikx wrote:
> This fixes a bug where the first call to unbind would clear the internal
> invalidation listener used, resulting in subsequent unbind calls to be
> no-ops, unless bind was called again first.
>
> I had to rewrite the parameterized test s
On Tue, 18 Oct 2022 05:40:59 GMT, John Hendrikx wrote:
>> private static final Object KEY = new Object();
>>
>> public final ReadOnlyBooleanProperty shownProperty() {
>> Object x = getProperties().get(KEY);
>> if (x instanceof ReadOnlyBooleanProperty p) {
>> return p;
>> }
>> ReadOnl
On Tue, 18 Oct 2022 04:47:38 GMT, Ambarish Rapte wrote:
>> I think that we should explain what makes 2 objects equal. Even if we don't
>> explicitly name the methods used for comparison, we could say "2 points are
>> equals if their coordinates are equal".
>>
>> By the way, I have https://bugs
14 matches
Mail list logo
