On Tue, 11 May 2021 01:17:32 GMT, John Neffenger wrote:
>> The Windows build calls a series of batch files to get the Visual Studio
>> paths and environment variables. The batch files are a black box: any
>> messages they print are discarded. If anything goes wrong, the only signs
>> are a vag
> This cleans size and positioning code, reducing special cases, code
> complexity and size.
>
> Changes:
>
> - cached extents: 28, 1, 1, 1 are old defaults - modern gnome uses different
> sizes. It does not assume any size because it varies - it does cache because
> it's unlikely to vary on t
> This cleans size and positioning code, reducing special cases, code
> complexity and size.
>
> Changes:
>
> - cached extents: 28, 1, 1, 1 are old defaults - modern gnome uses different
> sizes. It does not assume any size because it varies - it does cache because
> it's unlikely to vary on t
On Mon, 31 Oct 2022 21:30:51 GMT, Phil Race wrote:
> If floating point error caused a small negative value in the conversions
> needed from ISO to US measurements, then this will cause the IAE reported.
> The code doing the rounding should not have used Math.abs()
Looks good.
-
M
On Tue, 25 Oct 2022 05:07:05 GMT, Alexander Matveev
wrote:
> - Added support for libavcodec 59.
> - libavcodec 59 removed several deprecated APIs and avplugin code was
> updated to use replacement APIs instead.
> - No changes to avplugin when used with 58 or below.
> - Note: Support for liba
On Wed, 2 Nov 2022 19:10:49 GMT, Andy Goryachev wrote:
>>> And yes, I did not see Dimension2D - we probably should remove confusion
>>> and use Point2D (why does it have more overhead?)
>>
>> Point2D provides much more functionality -- but has 2 fields only. So it
>> should not be an overhead
On Fri, 28 Oct 2022 23:42:30 GMT, Kevin Rushforth wrote:
>> Johan Vos has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> address reviewer comments
>> Fix detection on screen, based on awtScale factors
>
> modules/javafx.swing/src/main/jav
> The root problem is actually broader than stated in the JBS issue. This PR
> now translates screencoordinates from absolute coordinates into coordinates
> that take the platformScale into account.
> The whole process is complicated by the fact that throughout our code, we use
> e.g. `x` and `
On Wed, 2 Nov 2022 18:51:56 GMT, Johan Vos wrote:
>> We need the int values, as they are used to invoke `mouseEvent`,
>> `scrollEvent` and `menuEvent` on
>> `com.sun.javafx.embed.EmbeddedSceneInterface` .
>> For some reason, `scrollEvent` takes doubles, but `mouseEvent` and
>> `menuEvent` tak
On Fri, 28 Oct 2022 23:29:36 GMT, Kevin Rushforth wrote:
>> Depending on the desired result, we use `Math.floor`, `Math.ceil`, or
>> `Math.round` -- it's important to pick the right one.
>>
>> But yes, using one of those is (almost always) better than just casting to
>> `(int)` if the value mi
On Wed, 2 Nov 2022 18:50:44 GMT, Johan Vos wrote:
>> I think in this case, `Math.floor()` is what you want. I wonder, though,
>> whether it needs to be converted to an `int` at all? It looks like
>> everywhere it is used, it can be kept as a double.
>>
>> Btw, I almost wrote a comment asking a
On Wed, 26 Oct 2022 22:38:15 GMT, Kevin Rushforth wrote:
> This PR replaces all occurrences of `State` with `Worker.State` in
> `javafx.concurrent.Task`.
>
> The `javafx.concurrent.Task` class implements `javafx.concurrent.Worker` and
> extends `java.util.concurrent.FutureTask`, which in turn
Reproduction code was not provided, I wasn't able to reproduce the
circumstances in which the issue occurs. On our side it seems like
`WindowStage.getPlatformWindow()` will not return null, however it is also
difficult to reject the possibility that some custom user code might trigger an
edge-c
On Tue, 1 Nov 2022 12:33:13 GMT, Marius Hanl wrote:
> I would like to give this PR a bump. I still think this is a nice and safe
> improvement.
Thanks, Marius. I appreciate the time you gave for a thorough review.
Nonetheless, it may have served its purpose. Searching for WINSDK_DIR on Google
On Wed, 2 Nov 2022 15:01:59 GMT, Michael Strauß wrote:
>> There is not really an alternative for this in junit4. I can create a new
>> test class instead.
>
> There's no need to do that. `AnchorPaneTest` works just as well if you simply
> use the JUnit5 imports exclusively.
good point, that wi
On Wed, 2 Nov 2022 14:48:44 GMT, Marius Hanl wrote:
>> modules/javafx.graphics/src/test/java/test/javafx/scene/layout/AnchorPaneTest.java
>> line 35:
>>
>>> 33: import javafx.stage.Stage;
>>> 34: import org.junit.jupiter.params.ParameterizedTest;
>>> 35: import org.junit.jupiter.params.provider
On Tue, 25 Oct 2022 21:31:01 GMT, Alexander Matveev
wrote:
>> - Added support for libavcodec 59.
>> - libavcodec 59 removed several deprecated APIs and avplugin code was
>> updated to use replacement APIs instead.
>> - No changes to avplugin when used with 58 or below.
>> - Note: Support for
On Fri, 28 Oct 2022 11:49:05 GMT, Kevin Rushforth wrote:
> > Works fine, but fails to build on win32.
>
> That is surprising since the libav changes are limited to Linux-specific
> code. Have you confirmed that the win32 build passes without this fix and
> fails with this fix? How does it fail
On Wed, 2 Nov 2022 14:07:23 GMT, Ambarish Rapte wrote:
>> Marius Hanl has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8295078: Adjusted Copyright year
>
> modules/javafx.graphics/src/test/java/test/javafx/scene/layout/AnchorPaneTest.java
On a topic unrelated to Conveyor, I saw the JavaFX roadmap document
presented at JavaOne and the mention of a Metal pipeline.
It prompted a thought I've never got around to exploring - does it make
sense to switch JavaFX to using Google's ANGLE library i.e. to decommission
all but the GL backend a
Hello,
I hope this is of interest to the OpenJFX community. Conveyor is a new
packaging tool that launched a few months ago. It's similar to jpackage,
except with some useful additional features:
- Handles online updates.
- You can build for every OS from your own choice of OS:
- Cros
On Thu, 13 Oct 2022 01:41:11 GMT, Marius Hanl wrote:
>> The problem here is, that the `AnchorPane` does not use its snapped insets.
>> Therefore, the fix is to replace all `getInsets().getXXX` calls with their
>> corresponding `snappedXXXInset()` methods.
>>
>> Note: The reason the `AnchorPane`
On Fri, 28 Oct 2022 19:41:35 GMT, Kevin Rushforth wrote:
>> This PR replaces all occurrences of `State` with `Worker.State` in
>> `javafx.concurrent.Task`.
>>
>> The `javafx.concurrent.Task` class implements `javafx.concurrent.Worker` and
>> extends `java.util.concurrent.FutureTask`, which in
23 matches
Mail list logo
