> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be autoboxed)
> - Remove unnecessary semi-colons (at end of class d
On Wed, 26 Oct 2022 07:56:52 GMT, John Hendrikx wrote:
>> This PR adds a new (lazy*) property on `Node` which provides a boolean which
>> indicates whether or not the `Node` is currently part of a `Scene`, which in
>> turn is part of a currently showing `Window`.
>>
>> It also adds a new fluen
On Fri, 25 Nov 2022 15:04:38 GMT, Lukasz Kostyra wrote:
> After implementing CR fixes it turned out that these tests started to fail at
> random. Upon more investigation it turned out that the order in which JUnit
> calls test methods matters a lot.
Thank you for getting to the bottom of this.
> The change moves Locale setting in the test to `@BeforeClass` and
> `@AfterClass` calls. `@BeforeClass` method call stores current default VM
> locale and applies Locale.US, while `@AfterClass` method restores old VM
> locale after all tests are completed.
>
> I tested it both on Mac and Wind
> The change moves Locale setting in the test to `@BeforeClass` and
> `@AfterClass` calls. `@BeforeClass` method call stores current default VM
> locale and applies Locale.US, while `@AfterClass` method restores old VM
> locale after all tests are completed.
>
> I tested it both on Mac and Wind
On Mon, 28 Nov 2022 14:56:49 GMT, Lukasz Kostyra wrote:
>> The change moves Locale setting in the test to `@BeforeClass` and
>> `@AfterClass` calls. `@BeforeClass` method call stores current default VM
>> locale and applies Locale.US, while `@AfterClass` method restores old VM
>> locale after
On Mon, 28 Nov 2022 14:44:17 GMT, Lukasz Kostyra wrote:
>> The change moves Locale setting in the test to `@BeforeClass` and
>> `@AfterClass` calls. `@BeforeClass` method call stores current default VM
>> locale and applies Locale.US, while `@AfterClass` method restores old VM
>> locale after
On Mon, 28 Nov 2022 14:47:16 GMT, Kevin Rushforth wrote:
>> Lukasz Kostyra has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains four commits:
>>
>> - Merge branch 'master' of https://git.openjdk.org/jfx into
>> JDK-8265828-locale
>>
On Mon, 28 Nov 2022 14:56:49 GMT, Lukasz Kostyra wrote:
>> The change moves Locale setting in the test to `@BeforeClass` and
>> `@AfterClass` calls. `@BeforeClass` method call stores current default VM
>> locale and applies Locale.US, while `@AfterClass` method restores old VM
>> locale after
On Fri, 7 Oct 2022 20:50:55 GMT, Andy Goryachev wrote:
> Introduction
>
> There is a number of places where various listeners (strong as well as weak)
> are added, to be later disconnected in one go. For example, Skin
> implementations use dispose() method to clean up the listeners installed i
On Tue, 22 Nov 2022 19:10:27 GMT, Kevin Rushforth wrote:
>> modules/javafx.fxml/src/main/java/javafx/fxml/FXMLLoader.java line 1446:
>>
>>> 1444: }
>>> 1445: }
>>> 1446:
>>
>> this suggests a specific pattern, even though there is probably no
>> development expected in thi
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be autoboxed)
> - Remove unnecessary semi-colons (at end of class d
Fixes memory leaks as determined by SkinMemoryLeakTest (remove line 171) and a
leak tester
https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/apps/LeakTest.java
Make sure to configure the current test in LeakTest:
protected final Type WE_ARE_TESTING = Type.PAGINATION;
Found an
On Thu, 20 Oct 2022 20:48:07 GMT, Andy Goryachev wrote:
> Fixes memory leaks as determined by SkinMemoryLeakTest (remove line 171) and
> a leak tester
> https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/apps/LeakTest.java
>
> Make sure to configure the current test in LeakTe
On Thu, 20 Oct 2022 20:48:07 GMT, Andy Goryachev wrote:
> Fixes memory leaks as determined by SkinMemoryLeakTest (remove line 171) and
> a leak tester
> https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/apps/LeakTest.java
>
> Make sure to configure the current test in LeakTe
On Wed, 23 Nov 2022 00:13:07 GMT, Kevin Rushforth wrote:
>> Fixes memory leaks as determined by SkinMemoryLeakTest (remove line 171) and
>> a leak tester
>> https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/apps/LeakTest.java
>>
>> Make sure to configure the current test in
On Fri, 28 Oct 2022 20:08:33 GMT, Andy Goryachev wrote:
>> Fixes memory leaks as determined by SkinMemoryLeakTest (remove line 171) and
>> a leak tester
>> https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/apps/LeakTest.java
>>
>> Make sure to configure the current test in L
On Thu, 3 Nov 2022 18:46:36 GMT, Kevin Rushforth wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/PaginationSkin.java
>> line 917:
>>
>>> 915: });
>>> 916:
>>> 917:
>>> ListenerHelper.get(PaginationSkin.this).addChangeListener(getSkinnable().cu
as determined by SkinMemoryLeakTest (remove line 174) and a leak tester
https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/apps/LeakTest.java
caused by:
- adding and not removing listeners
- adding and not removing event handlers/filters
NOTE:
this fix requires JDK-8295242 scr
as determined by SkinMemoryLeakTest (remove line 164) and a leak tester
https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/apps/LeakTest.java
Make sure to configure the current test in LeakTest:
protected final Type WE_ARE_TESTING = Type.ACCORDION;
caused by:
- adding and not
> Fixed memory leak by using weak listeners and making sure to undo everything
> that has been done to MenuBar/Skin in dispose().
>
> This PR depends on a new internal class ListenerHelper, a replacement for
> LambdaMultiplePropertyChangeListenerHandler.
> See https://github.com/openjdk/jfx/pull
Fixed memory leak by removing all the listeners in dispose();
This PR depends on a new internal class ListenerHelper, a replacement for
LambdaMultiplePropertyChangeListenerHandler.
See https://github.com/openjdk/jfx/pull/908
-
Commit messages:
- Merge remote-tracking branch 'origin
as determined by SkinMemoryLeakTest (remove line 166) and a leak tester
https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/apps/LeakTest.java
Affected skins:
- ColorPicker
- DatePicker
- ComboBox
caused by:
- out-of-order modification of the control property (skin.install)
- ad
as determined by SkinMemoryLeakTest (remove line 170) and a leak tester
https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/apps/LeakTest.java
Also applies to SplitMenuButton, since they share the same base class
MenuButtonSkinBase.
Make sure to configure the current test in Le
On Fri, 21 Oct 2022 19:01:54 GMT, Andy Goryachev wrote:
> as determined by SkinMemoryLeakTest (remove line 174) and a leak tester
> https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/apps/LeakTest.java
>
> caused by:
> - adding and not removing listeners
> - adding and not re
Fixed memory leak when changing skin in ScrollBarSkin (was adding an event
handler without removing it in dispose()).
This change depends on ListenerHelper PR
https://github.com/openjdk/jfx/pull/908
-
Commit messages:
- 8295242: cleanup
- Merge remote-tracking branch 'origin/maste
as determined by SkinMemoryLeakTest (remove line 165) and a leak tester
https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/apps/LeakTest.java
Make sure to configure the current test in LeakTest:
protected final Type WE_ARE_TESTING = Type.BUTTON_BAR;
caused by:
- adding and not
Fixed SpinnerSkin initialization using new Skin.install(). Also in this PR -
fixing memory leaks in SpinnerSkin by properly removing all listeners and event
filters added in the constructor, as well as any child Nodes.
NOTE: the fix requires both ListenerHelper
[JDK-8294809](https://bugs.openj
as determined by SkinMemoryLeakTest (remove line 179) and a leak tester
https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/apps/LeakTest.java
caused by:
- adding and not removing listeners
- adding and not removing event handlers/filters
NOTE:
this fix requires [JDK-8294809](ht
> Fixed memory leak by using weak listeners and making sure to undo everything
> that has been done to MenuBar/Skin in dispose().
>
> This PR depends on a new internal class ListenerHelper, a replacement for
> LambdaMultiplePropertyChangeListenerHandler.
> See https://github.com/openjdk/jfx/pull
On Wed, 23 Nov 2022 22:02:08 GMT, Kevin Rushforth wrote:
> 1. The divider being dragged doesn't track the cursor. All policies other
> than CONSTRAINED_RESIZE_POLICY_ALL_COLUMNS should be able to track (the Swing
> implementation does).
Could you describe the exact scenario please? It does tr
On Fri, 21 Oct 2022 19:01:54 GMT, Andy Goryachev wrote:
> as determined by SkinMemoryLeakTest (remove line 174) and a leak tester
> https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/apps/LeakTest.java
>
> caused by:
> - adding and not removing listeners
> - adding and not re
> The current CONSTRAINED_RESIZE_POLICY has a number of issues as explained in
> [JDK-8292810](https://bugs.openjdk.org/browse/JDK-8292810).
>
> We propose to address all these issues by replacing the old column resize
> algorithm with a different one, which not only honors all the constraints
On Wed, 12 Oct 2022 23:18:46 GMT, Andy Goryachev wrote:
> Fixed memory leak when changing skin in ScrollBarSkin (was adding an event
> handler without removing it in dispose()).
>
> This change depends on ListenerHelper PR
> https://github.com/openjdk/jfx/pull/908
This pull request has been cl
On Wed, 12 Oct 2022 23:18:46 GMT, Andy Goryachev wrote:
> Fixed memory leak when changing skin in ScrollBarSkin (was adding an event
> handler without removing it in dispose()).
>
> This change depends on ListenerHelper PR
> https://github.com/openjdk/jfx/pull/908
changes will be reviewed as a
> Note: I ran into a `javac` compiler bug while replacing types with diamond
> operators (ecj has no issues). I had two options, add a
> `SuppressWarnings("unused")` or to use a lambda instead of a method reference
> to make `javac` happy. I choose the later and added a comment so it can be
>
On Wed, 23 Nov 2022 23:38:59 GMT, John Hendrikx wrote:
>> Yes, but this is now getting to be a bit out of scope for this PR. Even
>> adding the `assertTrue` requires running all the tests (which thankfully,
>> GHA will do).
>>
>> Perhaps a better approach is to not make any more changes here,
> Note: I ran into a `javac` compiler bug while replacing types with diamond
> operators (ecj has no issues). I had two options, add a
> `SuppressWarnings("unused")` or to use a lambda instead of a method reference
> to make `javac` happy. I choose the later and added a comment so it can be
>
On Mon, 28 Nov 2022 20:33:07 GMT, Andy Goryachev wrote:
> > 1. The divider being dragged doesn't track the cursor. All policies other
> > than CONSTRAINED_RESIZE_POLICY_ALL_COLUMNS should be able to track (the
> > Swing implementation does).
>
> Could you describe the exact scenario please? It
On Mon, 28 Nov 2022 21:11:33 GMT, John Hendrikx wrote:
>> Note: I ran into a `javac` compiler bug while replacing types with diamond
>> operators (ecj has no issues). I had two options, add a
>> `SuppressWarnings("unused")` or to use a lambda instead of a method
>> reference to make `javac` h
> Note: I ran into a `javac` compiler bug while replacing types with diamond
> operators (ecj has no issues). I had two options, add a
> `SuppressWarnings("unused")` or to use a lambda instead of a method reference
> to make `javac` happy. I choose the later and added a comment so it can be
>
41 matches
Mail list logo
