I just noticed that Dialogs set to be resizable don’t have any constraints on
min/max size. So no min/max size properties on Dialog, nor does it limit
resizing to within the constraints of the DialogPane.
Am I missing something, or shall I file an enhancement request?
Scott
I am new here, but I have contributed to other open source projects before.
I have signed the contributor agreement and read through the
contributor info provided on the GitHub repository.
The GitHub page says to discuss new features here, so here is my proposal.
Summary
---
I would like to
> Fixed memory leak by using weak listeners and making sure to undo everything
> that has been done to MenuBar/Skin in dispose().
>
> This PR depends on a new internal class ListenerHelper, a replacement for
> LambdaMultiplePropertyChangeListenerHandler.
> See
On Wed, 30 Nov 2022 21:24:02 GMT, John Hendrikx wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8294589: cleanup
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/MenuBarSkin.java
> line 374:
On Fri, 28 Oct 2022 13:54:40 GMT, eduardsdv wrote:
>> This fixes a race condition between application and 'Print Job Thread'
>> threads when printing.
>>
>> The race condition occurs when application thread calls `endJob()`, which in
>> effect sets the `jobDone` flag to true,
>> and when the
On Wed, 30 Nov 2022 21:08:15 GMT, John Hendrikx wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8294589: cleanup
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/MenuBarSkin.java
> line 293:
On Wed, 30 Nov 2022 20:47:33 GMT, John Hendrikx wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8294589: cleanup
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/MenuBarSkin.java
> line 436:
On Wed, 30 Nov 2022 19:08:31 GMT, John Hendrikx wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8294589: cleanup
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/MenuBarSkin.java
> line 286:
> The current CONSTRAINED_RESIZE_POLICY has a number of issues as explained in
> [JDK-8292810](https://bugs.openjdk.org/browse/JDK-8292810).
>
> We propose to address all these issues by replacing the old column resize
> algorithm with a different one, which not only honors all the constraints
On Tue, 22 Nov 2022 01:40:02 GMT, Thiago Milczarek Sayao
wrote:
>> This cleans size and positioning code, reducing special cases, code
>> complexity and size.
>>
>> Changes:
>>
>> - cached extents: 28, 1, 1, 1 are old defaults - modern gnome uses different
>> sizes. It does not assume any
> The current CONSTRAINED_RESIZE_POLICY has a number of issues as explained in
> [JDK-8292810](https://bugs.openjdk.org/browse/JDK-8292810).
>
> We propose to address all these issues by replacing the old column resize
> algorithm with a different one, which not only honors all the constraints
On Tue, 22 Nov 2022 01:40:02 GMT, Thiago Milczarek Sayao
wrote:
>> This cleans size and positioning code, reducing special cases, code
>> complexity and size.
>>
>> Changes:
>>
>> - cached extents: 28, 1, 1, 1 are old defaults - modern gnome uses different
>> sizes. It does not assume any
> The current CONSTRAINED_RESIZE_POLICY has a number of issues as explained in
> [JDK-8292810](https://bugs.openjdk.org/browse/JDK-8292810).
>
> We propose to address all these issues by replacing the old column resize
> algorithm with a different one, which not only honors all the constraints
On Wed, 30 Nov 2022 18:43:42 GMT, Andy Goryachev wrote:
>> Fixed memory leak by using weak listeners and making sure to undo everything
>> that has been done to MenuBar/Skin in dispose().
>>
>> This PR depends on a new internal class ListenerHelper, a replacement for
>>
On Wed, 30 Nov 2022 17:00:55 GMT, Andy Goryachev wrote:
>> as determined by SkinMemoryLeakTest (remove line 170) and a leak tester
>> https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/apps/LeakTest.java
>>
>> Also applies to SplitMenuButton, since they share the same base
> The current CONSTRAINED_RESIZE_POLICY has a number of issues as explained in
> [JDK-8292810](https://bugs.openjdk.org/browse/JDK-8292810).
>
> We propose to address all these issues by replacing the old column resize
> algorithm with a different one, which not only honors all the constraints
> The current CONSTRAINED_RESIZE_POLICY has a number of issues as explained in
> [JDK-8292810](https://bugs.openjdk.org/browse/JDK-8292810).
>
> We propose to address all these issues by replacing the old column resize
> algorithm with a different one, which not only honors all the constraints
On Mon, 7 Nov 2022 12:03:38 GMT, Dean Wookey wrote:
>> When menu buttons are added and removed from the scene, an accelerator
>> change listener is added to each menu item in the menu. There is nothing
>> stopping the same change listener being added multiple times.
>>
>> MenuButtonSkinBase
On Wed, 30 Nov 2022 19:32:37 GMT, Kevin Rushforth wrote:
> Doing this makes it harder for reviewers to see what is actually being
> changed.
This is true, but it will the actual review process (especially, testing) move
faster. Or, we can wait for #919 to get integrated first.
-
On Wed, 30 Nov 2022 19:10:20 GMT, Andy Goryachev wrote:
> base on top of https://github.com/openjdk/jfx/pull/919
Doing this makes it harder for reviewers to see what is actually being changed.
Unless / until we enable the Skara support for dependent PRs (which the `jdk`
repo enables, but so
> Setting a null selection model in TableView and TreeTableView produce NPE on
> sorting (and probably in some other situations) because the check for null is
> missing in several places.
>
> Setting a null selection model is a valid way to disable selection in a
> (tree)table.
>
> There is
On Tue, 8 Nov 2022 10:11:40 GMT, Dean Wookey wrote:
>> Reviewers: @arapte @andy-goryachev-oracle
>
> @kevinrushforth, @arapte I clicked the request review on andy and it removed
> arapte for some reason. I guess that button shouldn't be clicked. Oops.
@DeanWookey :
Would it be possible to
On Mon, 7 Nov 2022 12:03:38 GMT, Dean Wookey wrote:
>> When menu buttons are added and removed from the scene, an accelerator
>> change listener is added to each menu item in the menu. There is nothing
>> stopping the same change listener being added multiple times.
>>
>> MenuButtonSkinBase
On Thu, 13 Oct 2022 04:25:19 GMT, Alexander Matveev
wrote:
>> - Added support for JAR and JRT protocol to AVFoundation platform.
>> - Removed H.264/MP3 and AAC support from GStreamer platform, which was
>> primary used to playback these formats for JAR and JRT protocols.
>> - Added ability
> Fixed memory leak by using weak listeners and making sure to undo everything
> that has been done to MenuBar/Skin in dispose().
>
> This PR depends on a new internal class ListenerHelper, a replacement for
> LambdaMultiplePropertyChangeListenerHandler.
> See
On Wed, 30 Nov 2022 18:36:13 GMT, Andy Goryachev wrote:
>> Fixed memory leak by using weak listeners and making sure to undo everything
>> that has been done to MenuBar/Skin in dispose().
>>
>> This PR depends on a new internal class ListenerHelper, a replacement for
>>
> Fixed memory leak by using weak listeners and making sure to undo everything
> that has been done to MenuBar/Skin in dispose().
>
> This PR depends on a new internal class ListenerHelper, a replacement for
> LambdaMultiplePropertyChangeListenerHandler.
> See
> Fixed memory leak by using weak listeners and making sure to undo everything
> that has been done to MenuBar/Skin in dispose().
>
> This PR depends on a new internal class ListenerHelper, a replacement for
> LambdaMultiplePropertyChangeListenerHandler.
> See
> as determined by SkinMemoryLeakTest (remove line 179) and a leak tester
> https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/apps/LeakTest.java
>
> caused by:
> - adding and not removing listeners
> - adding and not removing event handlers/filters
>
> NOTE:
> this fix
> Fixed SpinnerSkin initialization using new Skin.install(). Also in this PR -
> fixing memory leaks in SpinnerSkin by properly removing all listeners and
> event filters added in the constructor, as well as any child Nodes.
>
> NOTE: the fix requires both ListenerHelper
>
> as determined by SkinMemoryLeakTest (remove line 165) and a leak tester
> https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/apps/LeakTest.java
>
> Make sure to configure the current test in LeakTest:
> protected final Type WE_ARE_TESTING = Type.BUTTON_BAR;
>
>
> caused by:
> Fixed memory leak by removing all the listeners in dispose();
>
> This PR depends on a new internal class ListenerHelper, a replacement for
> LambdaMultiplePropertyChangeListenerHandler.
> See https://github.com/openjdk/jfx/pull/908
Andy Goryachev has updated the pull request with a new
> The current CONSTRAINED_RESIZE_POLICY has a number of issues as explained in
> [JDK-8292810](https://bugs.openjdk.org/browse/JDK-8292810).
>
> We propose to address all these issues by replacing the old column resize
> algorithm with a different one, which not only honors all the constraints
> as determined by SkinMemoryLeakTest (remove line 170) and a leak tester
> https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/apps/LeakTest.java
>
> Also applies to SplitMenuButton, since they share the same base class
> MenuButtonSkinBase.
>
> Make sure to configure the
> as determined by SkinMemoryLeakTest (remove line 166) and a leak tester
> https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/apps/LeakTest.java
>
> Affected skins:
> - ColorPicker
> - DatePicker
> - ComboBox
>
> caused by:
> - out-of-order modification of the control
> as determined by SkinMemoryLeakTest (remove line 164) and a leak tester
> https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/apps/LeakTest.java
>
> Make sure to configure the current test in LeakTest:
> protected final Type WE_ARE_TESTING = Type.ACCORDION;
>
>
> caused by:
On Thu, 20 Oct 2022 20:48:07 GMT, Andy Goryachev wrote:
> Fixes memory leaks as determined by SkinMemoryLeakTest (remove line 171) and
> a leak tester
> https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/apps/LeakTest.java
>
> Make sure to configure the current test in
On Tue, 22 Nov 2022 21:28:44 GMT, Kevin Rushforth wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix indentation
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/UploadingPainter.java
> line
On Mon, 28 Nov 2022 13:39:05 GMT, John Hendrikx wrote:
>> - Remove unsupported/unnecessary SuppressWarning annotations
>> - Remove reduntant type specifications (use diamond operator)
>> - Remove unused or duplicate imports
>> - Remove unnecessary casts (type is already correct type or can be
On Wed, 30 Nov 2022 03:19:54 GMT, Nir Lisker wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/WindowStage.java
>> line 418:
>>
>>> 416: scaleFactor = 1.0 / scaleDivider;
>>> 417: adjw = (int)Math.round(iw / scaleDivider);
>>>
On Tue, 22 Nov 2022 12:08:44 GMT, John Hendrikx wrote:
> Note: I ran into a `javac` compiler bug while replacing types with diamond
> operators (ecj has no issues). I had two options, add a
> `SuppressWarnings("unused")` or to use a lambda instead of a method reference
> to make `javac`
On Thu, 20 Oct 2022 20:48:07 GMT, Andy Goryachev wrote:
> Fixes memory leaks as determined by SkinMemoryLeakTest (remove line 171) and
> a leak tester
> https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/apps/LeakTest.java
>
> Make sure to configure the current test in
On Tue, 22 Nov 2022 11:13:40 GMT, John Hendrikx wrote:
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be
43 matches
Mail list logo
