> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be autoboxed)
> - Remove unnecessary semi-colons (at end of class
On Tue, 29 Nov 2022 16:01:58 GMT, Kevin Rushforth wrote:
>> `4L * physicalWidth * physicalHeight;` does not require an explicit cast, so
>> I think it's the clearest.
>
> That variant is fine with me.
Updated with this variant.
-
PR: https://git.openjdk.org/jfx/pull/960
On Tue, 29 Nov 2022 16:50:00 GMT, Kevin Rushforth wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix indentation
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/RotateGestureRecognizer.java
>
On Sat, 26 Nov 2022 18:19:00 GMT, Nir Lisker wrote:
>> John Hendrikx has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Revert changes to gesture recognizers to be addressed in follow up bug
>> - Fix incorrect cast removals
>
>
On Tue, 29 Nov 2022 16:49:30 GMT, Kevin Rushforth wrote:
>> +1 for reverting the changes and disabling the warning
>
>> Specifically about this code, `rotationStartTime` probably should not have
>> been a `double` depending on what is stored in it (checking: its source is
>>
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be autoboxed)
> - Remove unnecessary semi-colons (at end of class
On Fri, 2 Dec 2022 15:52:59 GMT, Johan Vos wrote:
> I personally would like to have an approach similar to OpenJDK, which is more
> Makefile based and deals with module/platform/architecture specific things in
> a cleaner way.
Me too! I thought I was alone in wanting to move to Makefiles. The
On Fri, 2 Dec 2022 09:56:42 GMT, John Hendrikx wrote:
>> This PR adds a new (lazy*) property on `Node` which provides a boolean which
>> indicates whether or not the `Node` is currently part of a `Scene`, which in
>> turn is part of a currently showing `Window`.
>>
>> It also adds a new
