On Fri, 9 Dec 2022 06:49:55 GMT, Karthik P K wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/DatePickerSkin.java
>> line 145:
>>
>>> 143: show();
>>> 144: } else {
>>> 145: updateDisplayNode();
>>
>> Can the call to `updateD
On Thu, 8 Dec 2022 10:34:34 GMT, Karthik P K wrote:
>> Cause: When slider is dragged for first time after tooltip appears,
>> setOnMousePressed event was not invoked, hence dragStart was null in the
>> subsequently invoked event handler (setOnMouseDragged).
>>
>> Fix: Initialized dragStart in
On Fri, 9 Dec 2022 06:53:46 GMT, Karthik P K wrote:
>> Cause: On hiding the DatePicker dropdown, value selected was not getting
>> updated to the text editor. Hence old value from the text editor was getting
>> committed to DatePicker on focus loss. This issue was seen only when
>> DatePicker
On Thu, 17 Nov 2022 06:16:34 GMT, Hima Bindu Meda wrote:
> Updated sqlite to v3.39.4
> Verified build on windows, linux and mac.
> Sanity testing looks fine.
This pull request has now been integrated.
Changeset: 9f6ec88b
Author:Hima Bindu Meda
Committer: Kevin Rushforth
URL:
https:
On Fri, 9 Dec 2022 06:53:46 GMT, Karthik P K wrote:
>> Cause: On hiding the DatePicker dropdown, value selected was not getting
>> updated to the text editor. Hence old value from the text editor was getting
>> committed to DatePicker on focus loss. This issue was seen only when
>> DatePicker
On Fri, 9 Dec 2022 06:53:46 GMT, Karthik P K wrote:
>> Cause: On hiding the DatePicker dropdown, value selected was not getting
>> updated to the text editor. Hence old value from the text editor was getting
>> committed to DatePicker on focus loss. This issue was seen only when
>> DatePicker
On Thu, 8 Dec 2022 10:34:34 GMT, Karthik P K wrote:
>> Cause: When slider is dragged for first time after tooltip appears,
>> setOnMousePressed event was not invoked, hence dragStart was null in the
>> subsequently invoked event handler (setOnMouseDragged).
>>
>> Fix: Initialized dragStart in
On Thu, 8 Dec 2022 19:20:30 GMT, Thiago Milczarek Sayao
wrote:
>> This cleans size and positioning code, reducing special cases, code
>> complexity and size.
>>
>> Changes:
>>
>> - cached extents: 28, 1, 1, 1 are old defaults - modern gnome uses different
>> sizes. It does not assume any siz
On Thu, 8 Dec 2022 14:21:45 GMT, John Hendrikx wrote:
>> - Added generics (to package private or internal classes only)
>> - Minor clean-ups of code I touched (naming)
>> - Fixed incorrect use of generics
>> - Fixed raw type warnings
>>
>> Note: some raw types have leaked into public API. These
On Fri, 9 Dec 2022 17:47:33 GMT, Nir Lisker wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert renames in Disposer
>
> modules/javafx.base/src/main/java/javafx/beans/property/ReadOnlyListProperty.java
> line
On Fri, 9 Dec 2022 18:35:28 GMT, John Hendrikx wrote:
>> modules/javafx.base/src/main/java/javafx/beans/property/ReadOnlyListProperty.java
>> line 119:
>>
>>> 117:
>>> 118: @SuppressWarnings("unchecked")
>>> 119: final List list = (List)obj; // safe cast as elements
>>> are o
On Fri, 9 Dec 2022 18:35:57 GMT, John Hendrikx wrote:
>> It's safe as you're never actually using the type `E`, but I suppose the 2nd
>> list can also be `List` as only `equals` is called on it. The 2nd
>> `ListIterator` would then also be `ListIterator`.
>>
>> Casting to a specific generic t
On Thu, 8 Dec 2022 19:20:30 GMT, Thiago Milczarek Sayao
wrote:
>> This cleans size and positioning code, reducing special cases, code
>> complexity and size.
>>
>> Changes:
>>
>> - cached extents: 28, 1, 1, 1 are old defaults - modern gnome uses different
>> sizes. It does not assume any siz
On Tue, 6 Dec 2022 16:41:05 GMT, Andy Goryachev wrote:
>> The current CONSTRAINED_RESIZE_POLICY has a number of issues as explained in
>> [JDK-8292810](https://bugs.openjdk.org/browse/JDK-8292810).
>>
>> We propose to address all these issues by replacing the old column resize
>> algorithm wit
On Fri, 9 Dec 2022 18:06:21 GMT, Nir Lisker wrote:
> I see that you moved the generic type declarations from the inner classes to
> the outer ones. I wasn't getting any raw type warnings on these. What
> requires these?
I checked, it's not strictly required. I tried to make all of these class
On Fri, 9 Dec 2022 18:40:09 GMT, Nir Lisker wrote:
>> It also removes the need for the `SuppressWarnings` here.
>
> I suggest the following method:
>
>
> @Override
> public boolean equals(Object obj) {
> if (this == obj) {
> return true;
> }
> if (!(o
On Fri, 9 Dec 2022 20:11:24 GMT, John Hendrikx wrote:
>> I suggest the following method:
>>
>>
>> @Override
>> public boolean equals(Object obj) {
>> if (this == obj) {
>> return true;
>> }
>> if (!(obj instanceof List otherList)) {
>> ret
> The current CONSTRAINED_RESIZE_POLICY has a number of issues as explained in
> [JDK-8292810](https://bugs.openjdk.org/browse/JDK-8292810).
>
> We propose to address all these issues by replacing the old column resize
> algorithm with a different one, which not only honors all the constraints
On Fri, 9 Dec 2022 21:03:16 GMT, Andy Goryachev wrote:
>> The current CONSTRAINED_RESIZE_POLICY has a number of issues as explained in
>> [JDK-8292810](https://bugs.openjdk.org/browse/JDK-8292810).
>>
>> We propose to address all these issues by replacing the old column resize
>> algorithm wit
On Fri, 9 Dec 2022 21:17:18 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 73 commits:
>>
>> - 8293119: review comments
>> - Merge remote-tracking branch 'origin/master' into 829311
On Fri, 9 Dec 2022 21:25:55 GMT, Andy Goryachev wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/TableView.java
>> line 452:
>>
>>> 450: /**
>>> 451: * A resize policy that adjusts columns, starting with the next
>>> one, in order to fit the table width.
>>> 452:
On Fri, 9 Dec 2022 21:33:08 GMT, Kevin Rushforth wrote:
>> I liked it with `` : - )
>
> It should at least be consistent with the rest of them.
>
> The formatting (with or without the ``) is something we could ask others
> to weigh in on, too. I don't care too much, one way or the other.
consi
On Thu, 8 Dec 2022 10:34:34 GMT, Karthik P K wrote:
>> Cause: When slider is dragged for first time after tooltip appears,
>> setOnMousePressed event was not invoked, hence dragStart was null in the
>> subsequently invoked event handler (setOnMouseDragged).
>>
>> Fix: Initialized dragStart in
On Fri, 9 Dec 2022 21:23:21 GMT, Kevin Rushforth wrote:
> The docs look good. Go ahead and update the CSR and move it to Proposed.
JDK-8294398 updated, please take a look.
-
PR: https://git.openjdk.org/jfx/pull/897
On Thu, 8 Dec 2022 19:20:30 GMT, Thiago Milczarek Sayao
wrote:
>> This cleans size and positioning code, reducing special cases, code
>> complexity and size.
>>
>> Changes:
>>
>> - cached extents: 28, 1, 1, 1 are old defaults - modern gnome uses different
>> sizes. It does not assume any siz
25 matches
Mail list logo
