On Sun, 11 Dec 2022 21:47:50 GMT, Thiago Milczarek Sayao
wrote:
> I fixed the `setIconified` before `show` and also tested maximized and
> fullscreen.
Excellent. I also verified that, in connection with my proposed fix to
`IconifyTest`, it also fixes the two cases that were broken in Ubuntu
On Sun, 11 Dec 2022 14:30:22 GMT, John Hendrikx wrote:
>> - Added generics (to package private or internal classes only)
>> - Minor clean-ups of code I touched (naming)
>> - Fixed incorrect use of generics
>> - Fixed raw type warnings
>>
>> Note: some raw types have leaked into public API.
On Tue, 13 Dec 2022 22:14:29 GMT, Andy Goryachev wrote:
>> The current CONSTRAINED_RESIZE_POLICY has a number of issues as explained in
>> [JDK-8292810](https://bugs.openjdk.org/browse/JDK-8292810).
>>
>> We propose to address all these issues by replacing the old column resize
>> algorithm
> The current CONSTRAINED_RESIZE_POLICY has a number of issues as explained in
> [JDK-8292810](https://bugs.openjdk.org/browse/JDK-8292810).
>
> We propose to address all these issues by replacing the old column resize
> algorithm with a different one, which not only honors all the constraints
On Tue, 13 Dec 2022 08:41:55 GMT, John Hendrikx wrote:
>> But is it correct? The previous code computed a deltaTime in seconds as
>> `((currentNanos - startNanos) / 1e9)`, and then divided the
>> `scrollMagnitude` by that. I think that the equivalent to the old code is:
>>
>>
>>
On Mon, 12 Dec 2022 22:42:16 GMT, John Hendrikx wrote:
>> This PR adds a new (lazy*) property on `Node` which provides a boolean which
>> indicates whether or not the `Node` is currently part of a `Scene`, which in
>> turn is part of a currently showing `Window`.
>>
>> It also adds a new
inline
On 12/13/2022 12:55 AM, John Hendrikx wrote:
Hi all,
I was wondering, is there a reason for the current test setup in the
JavaFX code base?
Currently, tests are all stored under src/test/java under a special
package name prefixed with "test". This is an (IMHO) unusual practice
as
Hi all,
I was wondering, is there a reason for the current test setup in the
JavaFX code base?
Currently, tests are all stored under src/test/java under a special
package name prefixed with "test". This is an (IMHO) unusual practice as
normally tests mirror the same packages as their main
On Mon, 12 Dec 2022 23:02:06 GMT, Kevin Rushforth wrote:
>> I just needed you to confirm that this is indeed correct.
>>
>> Perhaps a default method `double nanosToSeconds(long)` in
>> `GestureRecognizer` would be clearer?
>
> But is it correct? The previous code computed a deltaTime in
