Re: BaselineOffset of StackPane is inconsistent

2023-01-26 Thread Scott Palmer
I determined this is caused by the StackPane's child node's layoutY value sometimes being 0.0 and sometimes being 7.5. Which is strange, since layout should always be complete on the TreeCells by the time they are painted. Which got me thinking.. sure maybe on one pass it wasn't initialized or

StageStyle.TOOLKIT_DECORATED

2023-01-26 Thread Thiago Milczarek Sayão
I have begun to implement a StageStyle variation called TOOLKIT_DECORATED (better naming welcome). It would be JavaFX's version of: https://docs.gtk.org/gtk4/class.HeaderBar.html The goal is to allow a Toolkit decorated window that accepts controls inside the decoration such as a "hamburger

Re: Q: missing APIs needed for implementation of a rich text control

2023-01-26 Thread Philip Race
Many of the items below (meaning excluding the caret features and app control of line spacing) are on my list of things to work on. phil On 1/26/23 12:33 PM, Scott Palmer wrote: [dupe of private message, now including the mailing list] I've been using RichTextFX to make my own code

Re: Q: missing APIs needed for implementation of a rich text control

2023-01-26 Thread Scott Palmer
[dupe of private message, now including the mailing list] I've been using RichTextFX to make my own code editor/IDE. I see that you have asked that project specifically on GitHub, excellent. One thing that I wanted to do was to use a font like Fira Code that combines characters such as != or >=

Re: RFR: 8290765: Remove parent disabled/treeVisible listeners [v2]

2023-01-26 Thread Michael Strauß
On Thu, 25 Aug 2022 22:18:44 GMT, Michael Strauß wrote: >> `Node` adds InvalidationListeners to its parent's `disabled` and >> `treeVisible` properties and calls its own `updateDisabled()` and >> `updateTreeVisible(boolean)` methods when the property values change. >> >> These listeners are

Re: RFR: 8290765: Remove parent disabled/treeVisible listeners [v3]

2023-01-26 Thread Michael Strauß
> `Node` adds InvalidationListeners to its parent's `disabled` and > `treeVisible` properties and calls its own `updateDisabled()` and > `updateTreeVisible(boolean)` methods when the property values change. > > These listeners are not required, since `Node` can easily call the >

Re: [jfx20] RFR: 8300013: Node.focusWithin doesn't account for nested focused nodes

2023-01-26 Thread Michael Strauß
On Thu, 12 Jan 2023 12:38:51 GMT, Kevin Rushforth wrote: >> I think this should go into JavaFX 20. > >> I think this should go into JavaFX 20. > > I agree. In the (very likely) case it doesn't get reviewed before the fork, > I'll ask you to retarget it to the `jfx20` branch. @kevinrushforth

Re: RFR: 8269907 memory leak - Dirty Nodes / Parent removed [v7]

2023-01-26 Thread Michael Strauß
On Thu, 26 Jan 2023 09:54:25 GMT, Florian Kirmaier wrote: >> After thinking about this issue for some time, I've now got a solution. >> I know put the scene in the state it is, before is was shown, when the >> dirtyNodes are unset, the whole scene is basically considered dirty. >> This has

Re: RFR: 8277848 Binding and Unbinding to List leads to memory leak [v9]

2023-01-26 Thread Michael Strauß
On Thu, 26 Jan 2023 08:54:44 GMT, Florian Kirmaier wrote: >> Making the initial listener of the ListProperty weak fixes the problem. >> The same is fixed for Set and Map. >> Due to a smart implementation, this is done without any performance drawback. >> (The trick is to have an object, which

Re: RFR: 8277848 Binding and Unbinding to List leads to memory leak [v9]

2023-01-26 Thread Andy Goryachev
On Thu, 26 Jan 2023 08:54:44 GMT, Florian Kirmaier wrote: >> Making the initial listener of the ListProperty weak fixes the problem. >> The same is fixed for Set and Map. >> Due to a smart implementation, this is done without any performance drawback. >> (The trick is to have an object, which

[jfx11u] RFR: 8301010: Change JavaFX release version to 11.0.19 in jfx11u

2023-01-26 Thread Johan Vos
Bump release version to 11.0.19 in build.properties and .jcheck/conf Fix for JDK-8301010 - Commit messages: - Increase release version for JavaFX 11.0.19 Changes: https://git.openjdk.org/jfx11u/pull/125/files Webrev: https://webrevs.openjdk.org/?repo=jfx11u=125=00 Issue:

[jfx17u] RFR: 8301011: Change JavaFX release version to 17.0.7 in jfx17u

2023-01-26 Thread Johan Vos
increase release version in build.properties and jcheck configuration Fix for JDK-8301011 - Commit messages: - Bump release version to 17.0.7 Changes: https://git.openjdk.org/jfx17u/pull/104/files Webrev: https://webrevs.openjdk.org/?repo=jfx17u=104=00 Issue:

Re: RFR: 8269907 memory leak - Dirty Nodes / Parent removed [v7]

2023-01-26 Thread Florian Kirmaier
On Thu, 26 Jan 2023 09:54:25 GMT, Florian Kirmaier wrote: >> After thinking about this issue for some time, I've now got a solution. >> I know put the scene in the state it is, before is was shown, when the >> dirtyNodes are unset, the whole scene is basically considered dirty. >> This has

Re: RFR: 8269907 memory leak - Dirty Nodes / Parent removed [v7]

2023-01-26 Thread Florian Kirmaier
> After thinking about this issue for some time, I've now got a solution. > I know put the scene in the state it is, before is was shown, when the > dirtyNodes are unset, the whole scene is basically considered dirty. > This has the drawback of rerendering, whenever a window is "reshown", but it

Re: RFR: 8277848 Binding and Unbinding to List leads to memory leak [v8]

2023-01-26 Thread Florian Kirmaier
On Sun, 22 Jan 2023 01:28:46 GMT, Michael Strauß wrote: >> Florian Kirmaier has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains eight commits: >> >> - Merge remote-tracking branch 'origjfx/master' into >>

Re: RFR: 8277848 Binding and Unbinding to List leads to memory leak [v9]

2023-01-26 Thread Florian Kirmaier
> Making the initial listener of the ListProperty weak fixes the problem. > The same is fixed for Set and Map. > Due to a smart implementation, this is done without any performance drawback. > (The trick is to have an object, which is both the WeakReference and the > Changelistener) > By implying