On Tue, 31 Jan 2023 14:40:00 GMT, Karthik P K wrote:
> In `selectIndices` method, zero length array is not considered while ignoring
> row number given as parameter.
>
> Updated the code to consider both null and zero length array in the condition
> before ignoring the row value given as
> In `selectIndices` method, zero length array is not considered while ignoring
> row number given as parameter.
>
> Updated the code to consider both null and zero length array in the condition
> before ignoring the row value given as parameter.
>
> Added unit test to validate the fix
> Update JavaFX WebKit to GTK WebKit 2.38 (615.1).
>
> Verified the updated version build, sanity tests and stability.
> This does not cause any issues except one unit test failure.
> Also, there are some artifacts observed while playing youtube
>
> The above issues are recorded and ignored
On Tue, Jan 31, 2023 at 6:14 PM Pedro Duque Vieira
wrote:
> Thinking of existing themes migrating to this StyleTheme API (90% are
> implemented as author stylesheets), some visual glitches may start appearing
> for users of those themes once they start using the migrated versions (since
> they
My previous message seems to have perhaps gotten lost in the
various messages exchanged in this mailing list.. (just doing this small
comment so that my previous message doesn't get lost..)
It's getting very late here where I live, I will be back later tomorrow (a
few hours from now).
Thanks
On
On Tue, 31 Jan 2023 23:07:12 GMT, Andy Goryachev wrote:
> I think that, by default, the FX frame decorations should pick up the
> platform theme (dark, light, accent color, etc.). It should be possible to
> override this behavior somehow - possibly by setting the base/accent color -
> but
On Tue, Jan 31, 2023 at 6:15 PM Andy Goryachev wrote:
> On Tue, 31 Jan 2023 23:04:50 GMT, Scott Palmer
> wrote:
>
> > Is it necessary for any application to know about "auto"?
>
> I actually don't know how the "auto" behaves. From the description it
> seems the colors might actually change
On Sun, 29 Jan 2023 17:10:26 GMT, Michael Strauß wrote:
>> Platform preferences are the preferred UI settings of the operating system.
>> For example, on Windows this includes the color values identified by the
>> `Windows.UI.ViewManagement.UIColorType` enumeration; on macOS this includes
>>
On Tue, 31 Jan 2023 23:04:50 GMT, Scott Palmer wrote:
> Is it necessary for any application to know about "auto"?
I actually don't know how the "auto" behaves. From the description it seems
the colors might actually change gradually throughout the day, thus making an
enum useless and
On Sun, 29 Jan 2023 17:10:26 GMT, Michael Strauß wrote:
>> Platform preferences are the preferred UI settings of the operating system.
>> For example, on Windows this includes the color values identified by the
>> `Windows.UI.ViewManagement.UIColorType` enumeration; on macOS this includes
>>
On Tue, 31 Jan 2023 20:18:05 GMT, Michael Strauß wrote:
> the reason for the Appearance enumeration and the Preferences.appearance
> property is to support dark window frames.
I think that, by default, the FX frame decorations should pick up the platform
theme (dark, light, accent color,
On Tue, 31 Jan 2023 20:03:19 GMT, Nir Lisker wrote:
> TreeTableView has the same problem.
good point! could we apply a similar change to TreeTableView:3012?
-
PR: https://git.openjdk.org/jfx/pull/1018
On Tue, 31 Jan 2023 20:00:00 GMT, Andy Goryachev wrote:
> In the context of adding theme support in javafx, I think this PR is a step
> in the right direction. I also like a small set of platform-independent
> properties like fg and bg colors. I wonder if the same approach can be
> extended
On Tue, 31 Jan 2023 14:40:00 GMT, Karthik P K wrote:
> In `selectIndices` method, zero length array is not considered while ignoring
> row number given as parameter.
>
> Updated the code to consider both null and zero length array in the condition
> before ignoring the row value given as
On Sun, 29 Jan 2023 17:10:26 GMT, Michael Strauß wrote:
>> Platform preferences are the preferred UI settings of the operating system.
>> For example, on Windows this includes the color values identified by the
>> `Windows.UI.ViewManagement.UIColorType` enumeration; on macOS this includes
>>
I've created a Gist with the updated proposal, this seems easier than
sending around large amounts of text for every change:
https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548
On Tue, 31 Jan 2023 18:48:41 GMT, Kevin Rushforth wrote:
> Can you provide an evaluation of the bug and a description of the fix?
Done.
-
PR: https://git.openjdk.org/jfx/pull/1016
On Tue, 31 Jan 2023 19:40:06 GMT, John Hendrikx wrote:
>> I had the same thought here.
>> The signature is indeed weird, but since it is perfectly legal to invoke it
>> with selectIndices(0, null), I think this change is absolutely correct.
>
> Well it's legal Java code, but that doesn't mean
On Tue, 31 Jan 2023 19:36:12 GMT, Andy Goryachev wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/TableView.java
>> line 2645:
>>
>>> 2643:
>>> 2644: @Override public void selectIndices(int row, int... rows) {
>>> 2645: if (rows == null || rows.length
On Tue, 31 Jan 2023 19:31:46 GMT, John Hendrikx wrote:
>> In `selectIndices` method, zero length array is not considered while
>> ignoring row number given as parameter.
>>
>> Updated the code to consider both null and zero length array in the
>> condition before ignoring the row value given
On Tue, 31 Jan 2023 14:40:00 GMT, Karthik P K wrote:
> In `selectIndices` method, zero length array is not considered while ignoring
> row number given as parameter.
>
> Updated the code to consider both null and zero length array in the condition
> before ignoring the row value given as
> On Windows platforms with more than one screen, a PopupWindow created for a
> Stage that straddles two windows will be drawn with an incorrect position and
> screen scale if the majority of the Stage is on one screen, and the popup is
> positioned on the other screen. In this case, the Stage
On Mon, 30 Jan 2023 15:11:20 GMT, Hima Bindu Meda wrote:
>> Update JavaFX WebKit to GTK WebKit 2.38 (615.1).
>>
>> Verified the updated version build, sanity tests and stability.
>> This does not cause any issues except one unit test failure.
>> Also, there are some artifacts observed while
On Mon, 30 Jan 2023 21:56:45 GMT, Alexander Zuev wrote:
> Change the underlying class XYChart to take into account labels for axes.
> Make label patterns and default axes labels localized.
Can you provide an evaluation of the bug and a description of the fix?
-
PR:
On Sun, 29 Jan 2023 17:10:26 GMT, Michael Strauß wrote:
>> Platform preferences are the preferred UI settings of the operating system.
>> For example, on Windows this includes the color values identified by the
>> `Windows.UI.ViewManagement.UIColorType` enumeration; on macOS this includes
>>
On Mon, 23 Jan 2023 23:55:51 GMT, Thiago Milczarek Sayao
wrote:
> This PR does:
>
> - Remove specific Idea files and let it be imported from gradle;
> - Adds checkstyle (to use with checkstyle plugin - it will let you know style
> mistakes);
> - Configures auto-format to sun style (with the
On Mon, 30 Jan 2023 12:21:38 GMT, Karthik P K wrote:
> While checking for duplicate series addition to the line chart, `setToRemove`
> value was not considered before throwing exception. Hence code to handling
> the case of adding the removed series was never run.
>
> Added condition to check
On Tue, 31 Jan 2023 16:47:01 GMT, Michael Strauß wrote:
>> This PR simply applies the patch from
>> [JDK-8218914](https://bugs.openjdk.org/browse/JDK-8218914) that solved the
>> same issue for the JDK.
>>
>> I've tested it on Windows 11 (Version 22H2 Build 22621.1105).
>>
>> I have the
On Tue, 31 Jan 2023 17:08:40 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 8325:
>>
>>> 8323: } else if (count == 0) {
>>> 8324: set(false);
>>> 8325: }
>>
>> Is it worth adding a check for `count < 0`
Hi Michael,
Truly sorry for the late reply but haven't had time to reply sooner,
unfortunately..
2 -
> > I've been building javafx themes for years now. Started creating JMetro
> in JavaFX version 2. During this time I've been following how other themes
> are being built and I can say that
On Tue, 31 Jan 2023 16:42:32 GMT, Kevin Rushforth wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> refactoring
>
> modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 8325:
>
>> 8323: }
On Thu, 12 Jan 2023 03:08:30 GMT, Michael Strauß wrote:
> When a scene graph contains multiple nested focused nodes (this can happen
> with `TableView` and other controls), the `focusWithin` bits that are cleared
> when a focused node is de-focused must only be cleared when there is no other
On Tue, 31 Jan 2023 14:40:00 GMT, Karthik P K wrote:
> In `selectIndices` method, zero length array is not considered while ignoring
> row number given as parameter.
>
> Updated the code to consider both null and zero length array in the condition
> before ignoring the row value given as
On Fri, 13 Jan 2023 04:04:54 GMT, Michael Strauß wrote:
>> When a scene graph contains multiple nested focused nodes (this can happen
>> with `TableView` and other controls), the `focusWithin` bits that are
>> cleared when a focused node is de-focused must only be cleared when there is
>> no
On Tue, 31 Jan 2023 10:30:22 GMT, Jose Pereda wrote:
> This PR simply applies the patch from
> [JDK-8218914](https://bugs.openjdk.org/browse/JDK-8218914) that solved the
> same issue for the JDK.
>
> I've tested it on Windows 11 (Version 22H2 Build 22621.1105).
>
> I have the Roboto font
On Tue, 31 Jan 2023 14:40:00 GMT, Karthik P K wrote:
> In `selectIndices` method, zero length array is not considered while ignoring
> row number given as parameter.
>
> Updated the code to consider both null and zero length array in the condition
> before ignoring the row value given as
Since you are venturing into this space …. would love to be able to create
blurred backgrounds in windows. Apple has some apps where the sidebar is
semi-transparent with a strong blur effect.
> On 31 Jan 2023, at 15:15, Thiago Milczarek Sayão
> wrote:
>
> Hi,
>
> I'm doing some experiments
On Thu, 26 Jan 2023 15:31:52 GMT, Johan Vos wrote:
> Bump release version to 11.0.19 in build.properties and .jcheck/conf
> Fix for JDK-8301010
This pull request has now been integrated.
Changeset: 6a31ceba
Author:Johan Vos
URL:
On Thu, 26 Jan 2023 15:25:32 GMT, Johan Vos wrote:
> increase release version in build.properties and jcheck configuration
> Fix for JDK-8301011
This pull request has now been integrated.
Changeset: 27fac395
Author:Johan Vos
URL:
In `selectIndices` method, zero length array is not considered while ignoring
row number given as parameter.
Updated the code to consider both null and zero length array in the condition
before ignoring the row value given as parameter.
Added unit test to validate the fix
-
Hi,
I'm doing some experiments with toolkit decorations (instead of platform
decorations).
The goal is to allow for modern-looking apps, with "hamburger buttons" or
tabs (like firefox or chrome) on the decoration space.
It is coming into shape (nowhere near finished). It's CSS styleable.
On Mon, 9 Jan 2023 13:29:27 GMT, Ao Qi wrote:
> Clean backport. Verified on (after #102):
> - Linux/LoongArch64 (`USE_SYSTEM_MALLOC` is `on`, the platform triggering
> this problem)
> - Linux/x64 (`USE_SYSTEM_MALLOC` is `off`)
> - Linux/aarch64 (`USE_SYSTEM_MALLOC` is `off`)
This needs to wait
Clean backport. Verified on (after #102):
- Linux/LoongArch64 (`USE_SYSTEM_MALLOC` is `on`, the platform triggering this
problem)
- Linux/x64 (`USE_SYSTEM_MALLOC` is `off`)
- Linux/aarch64 (`USE_SYSTEM_MALLOC` is `off`)
-
Commit messages:
- 8293375: add_definitions
On Mon, 9 Jan 2023 13:29:27 GMT, Ao Qi wrote:
> Clean backport. Verified on (after #102):
> - Linux/LoongArch64 (`USE_SYSTEM_MALLOC` is `on`, the platform triggering
> this problem)
> - Linux/x64 (`USE_SYSTEM_MALLOC` is `off`)
> - Linux/aarch64 (`USE_SYSTEM_MALLOC` is `off`)
RFC and RFR.
On Thu, 26 Jan 2023 15:31:52 GMT, Johan Vos wrote:
> Bump release version to 11.0.19 in build.properties and .jcheck/conf
> Fix for JDK-8301010
Marked as reviewed by kcr (Lead).
-
PR: https://git.openjdk.org/jfx11u/pull/125
On Thu, 26 Jan 2023 15:25:32 GMT, Johan Vos wrote:
> increase release version in build.properties and jcheck configuration
> Fix for JDK-8301011
Marked as reviewed by kcr (Lead).
-
PR: https://git.openjdk.org/jfx17u/pull/104
On Tue, 31 Jan 2023 10:30:22 GMT, Jose Pereda wrote:
> This PR simply applies the patch from
> [JDK-8218914](https://bugs.openjdk.org/browse/JDK-8218914) that solved the
> same issue for the JDK.
>
> I've tested it on Windows 11 (Version 22H2 Build 22621.1105).
>
> I have the Roboto font
This PR simply applies the patch from
[JDK-8218914](https://bugs.openjdk.org/browse/JDK-8218914) that solved the same
issue for the JDK.
I've tested it on Windows 11 (Version 22H2 Build 22621.1105).
I have the Roboto font installed under
C:\Users%user\AppData\Local\Microsoft\Windows\Fonts
48 matches
Mail list logo
