Re: [jfx20] RFR: 8304359: Create release notes for JavaFX 20 [v2]

2023-03-16 Thread Kevin Rushforth
On Thu, 16 Mar 2023 17:14:28 GMT, Kevin Rushforth wrote: >> Release notes for JavaFX 20, including one important change to note (the >> requirement of JDK 17 as the minimum needed to run JavaFX 20) and the list >> of enhancements and bugs fixed in this release. >> >> Note: This PR is targeted

Re: [jfx20] RFR: 8304359: Create release notes for JavaFX 20 [v3]

2023-03-16 Thread Kevin Rushforth
> Release notes for JavaFX 20, including one important change to note (the > requirement of JDK 17 as the minimum needed to run JavaFX 20) and the list of > enhancements and bugs fixed in this release. > > Note: This PR is targeted to `jfx20`. Kevin Rushforth has updated the pull request

Java 20 / JavaFX 20 launch event on March 21st

2023-03-16 Thread Kevin Rushforth
For next week's GA release of Java 20 and JavaFX 20, on March 21st, we are hosting a Java Developer Day as part of Oracle's new FREE "DevLive: Level Up" event series. I'll be presenting "JavaFX 20 and Beyond" at this event. You can attend either in-person or online. Learn more:

Re: RFR: 8264591: HBox/VBox child widths pixel-snap to wrong value [v7]

2023-03-16 Thread Michael Strauß
On Thu, 16 Mar 2023 19:19:06 GMT, Andy Goryachev wrote: >> Michael Strauß has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 12 commits: >> >> - changes per review >> - Merge branch 'master' into fixes/box-snap-to-pixel >> >>

Re: RFR: 8264591: HBox/VBox child widths pixel-snap to wrong value [v7]

2023-03-16 Thread Kevin Rushforth
On Tue, 3 Jan 2023 06:31:37 GMT, Michael Strauß wrote: >> The children of HBox/VBox don't always pixel-snap to the same value as the >> container itself when a render scale other than 1 is used. This can lead to >> a visual glitch where the content bounds don't line up with the container >>

Re: RFR: 8264591: HBox/VBox child widths pixel-snap to wrong value [v7]

2023-03-16 Thread Michael Strauß
On Thu, 16 Mar 2023 19:15:25 GMT, Andy Goryachev wrote: >> Michael Strauß has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 12 commits: >> >> - changes per review >> - Merge branch 'master' into fixes/box-snap-to-pixel >> >>

Re: RFR: 8264591: HBox/VBox child widths pixel-snap to wrong value [v7]

2023-03-16 Thread Andy Goryachev
On Tue, 3 Jan 2023 06:31:37 GMT, Michael Strauß wrote: >> The children of HBox/VBox don't always pixel-snap to the same value as the >> container itself when a render scale other than 1 is used. This can lead to >> a visual glitch where the content bounds don't line up with the container >>

Re: RFR: 8264591: HBox/VBox child widths pixel-snap to wrong value [v7]

2023-03-16 Thread Andy Goryachev
On Tue, 3 Jan 2023 06:31:37 GMT, Michael Strauß wrote: >> The children of HBox/VBox don't always pixel-snap to the same value as the >> container itself when a render scale other than 1 is used. This can lead to >> a visual glitch where the content bounds don't line up with the container >>

Re: [jfx20] RFR: 8304359: Create release notes for JavaFX 20 [v2]

2023-03-16 Thread Kevin Rushforth
On Thu, 16 Mar 2023 18:20:03 GMT, Nir Lisker wrote: > Isn't https://bugs.openjdk.org/browse/JDK-8298728 a bug and not an > enhancement? Yes, you're right. I'll fix that (both in JBS and in the release notes). - PR: https://git.openjdk.org/jfx/pull/1060

Re: RFR: 8264591: HBox/VBox child widths pixel-snap to wrong value

2023-03-16 Thread Michael Strauß
On Wed, 22 Sep 2021 18:48:13 GMT, Marius Hanl wrote: >> The children of HBox/VBox don't always pixel-snap to the same value as the >> container itself when a render scale other than 1 is used. This can lead to >> a visual glitch where the content bounds don't line up with the container >>

Integrated: 8303680 Virtual Flow freezes after calling scrollTo and scrollPixels in succession

2023-03-16 Thread Florian Kirmaier
On Mon, 6 Mar 2023 16:04:02 GMT, Florian Kirmaier wrote: > Possible fix for VirtualFlow freeze. > > I encountered the problem when experimenting with VirtualFlow. > > Guess @johanvos should take a look. > All tests are still green, so with some luck, this doesn't break anything but > fixes

Re: [jfx20] RFR: 8304359: Create release notes for JavaFX 20 [v2]

2023-03-16 Thread Nir Lisker
On Thu, 16 Mar 2023 17:14:28 GMT, Kevin Rushforth wrote: >> Release notes for JavaFX 20, including one important change to note (the >> requirement of JDK 17 as the minimum needed to run JavaFX 20) and the list >> of enhancements and bugs fixed in this release. >> >> Note: This PR is targeted

Re: [jfx20] RFR: 8304359: Create release notes for JavaFX 20 [v2]

2023-03-16 Thread Kevin Rushforth
> Release notes for JavaFX 20, including one important change to note (the > requirement of JDK 17 as the minimum needed to run JavaFX 20) and the list of > enhancements and bugs fixed in this release. > > Note: This PR is targeted to `jfx20`. Kevin Rushforth has updated the pull request

Re: [jfx20] RFR: 8304359: Create release notes for JavaFX 20

2023-03-16 Thread Kevin Rushforth
On Thu, 16 Mar 2023 16:53:25 GMT, Kevin Rushforth wrote: > Release notes for JavaFX 20, including one important change to note (the > requirement of JDK 17 as the minimum needed to run JavaFX 20) and the list of > enhancements and bugs fixed in this release. > > Note: This PR is targeted to

[jfx20] RFR: 8304359: Create release notes for JavaFX 20

2023-03-16 Thread Kevin Rushforth
Release notes for JavaFX 20, including one important change to note (the requirement of JDK 17 as the minimum needed to run JavaFX 20) and the list of enhancements and bugs fixed in this release. Note: This PR is targeted to `jfx20`. - Commit messages: - 8304359: Create release

Re: [jfx20] RFR: 8304359: Create release notes for JavaFX 20

2023-03-16 Thread Kevin Rushforth
On Thu, 16 Mar 2023 16:53:25 GMT, Kevin Rushforth wrote: > Release notes for JavaFX 20, including one important change to note (the > requirement of JDK 17 as the minimum needed to run JavaFX 20) and the list of > enhancements and bugs fixed in this release. > > Note: This PR is targeted to

[jfx20u] Integrated: 8304008: Update README.md and CONTRIBUTING.md for jfx update repos

2023-03-16 Thread Kevin Rushforth
On Fri, 10 Mar 2023 23:02:18 GMT, Kevin Rushforth wrote: > Update README and CONTRIBUTING guidelines for this repo as appropriate for > update releases (basically a copy from jfx17u with 17 changed to 20). This pull request has now been integrated. Changeset: 9733e7a9 Author:Kevin

Re: [jfx20u] RFR: 8304008: Update README.md and CONTRIBUTING.md for jfx update repos

2023-03-16 Thread Johan Vos
On Fri, 10 Mar 2023 23:02:18 GMT, Kevin Rushforth wrote: > Update README and CONTRIBUTING guidelines for this repo as appropriate for > update releases (basically a copy from jfx17u with 17 changed to 20). Marked as reviewed by jvos (Reviewer). - PR:

Re: RFR: 8303680 Virtual Flow freezes after calling scrollTo and scrollPixels in succession

2023-03-16 Thread Johan Vos
On Mon, 6 Mar 2023 16:04:02 GMT, Florian Kirmaier wrote: > Possible fix for VirtualFlow freeze. > > I encountered the problem when experimenting with VirtualFlow. > > Guess @johanvos should take a look. > All tests are still green, so with some luck, this doesn't break anything but > fixes

Re: RFR: 8172849: Non-intuitive baseline alignment for labeled controls with graphics

2023-03-16 Thread Karthik P K
On Thu, 16 Mar 2023 12:32:36 GMT, Karthik P K wrote: >> Please don't change all of the other comment blocks as part of this PR. You >> can file a follow-up bug if you like, but in that case, we should first >> define a "best practice", probably something that would align with what the >>

Re: RFR: 8172849: Non-intuitive baseline alignment for labeled controls with graphics

2023-03-16 Thread Karthik P K
On Thu, 16 Mar 2023 12:14:39 GMT, Kevin Rushforth wrote: >> Yes javadoc comment would look better. I used the comment block to keep it >> consistent with the other comments present in the same file. I think if >> changing, then better to change all the comment blocks in the file. >> Please let

Re: RFR: 8172849: Non-intuitive baseline alignment for labeled controls with graphics

2023-03-16 Thread Kevin Rushforth
On Thu, 16 Mar 2023 06:31:04 GMT, Karthik P K wrote: >> modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/LabelSkinTest.java >> line 2102: >> >>> 2100: >>> / >>> 2101: >>> 2102: //Test for

Integrated: 8301009: Update libxml2 to 2.10.3

2023-03-16 Thread Hima Bindu Meda
On Tue, 14 Mar 2023 08:04:04 GMT, Hima Bindu Meda wrote: > Updated Libxml2 to v2.10.3. verfied build and sanity testing on windows, mac > and Linux platforms. > No issue observed. This pull request has now been integrated. Changeset: 935c7b79 Author:Hima Bindu Meda URL:

Re: RFR: 8301009: Update libxml2 to 2.10.3

2023-03-16 Thread Joeri Sykora
On Tue, 14 Mar 2023 08:04:04 GMT, Hima Bindu Meda wrote: > Updated Libxml2 to v2.10.3. verfied build and sanity testing on windows, mac > and Linux platforms. > No issue observed. Building and running tests worked on windows, linux and macos. - Marked as reviewed by sykora

RFR: JDK-8304323 Provide infrastructure to make it possible for properties to delay listener registration

2023-03-16 Thread John Hendrikx
This PR contains changes to make it easier to implement properties which want to conserve resources until they're observed themselves. `isObserved` is promoted from `ObjectBinding` to the `ObservableValue` interface, allowing you to ask any `ObservableValue` if it is currently observed (ie.

Re: RFR: 8172849: Non-intuitive baseline alignment for labeled controls with graphics

2023-03-16 Thread Karthik P K
On Wed, 15 Mar 2023 18:18:45 GMT, Andy Goryachev wrote: >> Issue was observed because even when graphic height was less than text >> height of the Label, graphic height was considered while calculating the >> baseline offset. This was shifting the baseline offset and resulted in >>

Re: RFR: 8154038: Spinner's converter should update its editor [v2]

2023-03-16 Thread Karthik P K
> When converter was changed, `setText` method of spinner was not invoked to > update the spinner text using new converter. > > Added a listener to converter property of `SpinnerValueFactory` to call > `setText` so that spinner text is updated using new converter. > > Added unit test to

Re: RFR: 8154038: Spinner's converter should update its editor [v2]

2023-03-16 Thread Karthik P K
On Wed, 15 Mar 2023 12:15:14 GMT, Ajit Ghaisas wrote: >> Karthik P K has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address review comments > > modules/javafx.controls/src/main/java/javafx/scene/control/Spinner.java line > 545: > >>