I love this idea and would use it immediately!
On Fri, Mar 24, 2023 at 12:10 AM John Hendrikx
wrote:
> Hi list,
>
> I've been working on a potential new API (and proof of concept
> implementation) for adding a new type of fluent binding which can delay
> changing their values, and I'm wondering
Issue: Error copying file (if different) from
Source/JavaScriptCore/Scripts/wkbuiltins/builtins_generate_separate_header.py"
to
"modules/javafx.web/build/mac/Release/JavaScriptCcripts/builtins_generate_separate_header.py".
Root cause: The number of build threads more than 8, causing a synchroni
On Mon, 27 Mar 2023 23:05:00 GMT, John Hendrikx wrote:
> Fix bug in CSS caching code that could reset values on unrelated nodes.
>
> The bug occurs due to a cache entry being constructed incorrectly when the
> initial node that triggered the cache entry creation has user set values. The
> calc
Fix bug in CSS caching code that could reset values on unrelated nodes.
The bug occurs due to a cache entry being constructed incorrectly when the
initial node that triggered the cache entry creation has user set values. The
calculated values for properties with a user set value were omitted in
> I'd think a loss of focus might be considered as a trigger for "significant
> interaction". Or perhaps you could give us an example of a use case in which
> it'll be insufficient?
For example, for a text field, gaining and losing focus is probably
sufficient to count as an interaction. Everyt
I should add that aside from the javafx.scene.input.InputNode
interface, there is no addition to or modification of the core
platform.
Nothing in javaxf.graphics uses InputNode, it is provided solely as a
contract for the "significant interaction" information, which
third-party libraries can depend
On Sat, 25 Mar 2023 15:50:21 GMT, Kevin Rushforth wrote:
> This PR skips three headful tests on Linux until the issues with the tests
> can be fixed. These tests consistently fail on our physical Ubuntu 22.04 test
> machine. This is a step towards getting clean headful test runs. Each of the
>
Michael:
> 2. Just-in-time validation for every significant interaction
I'd think a loss of focus might be considered as a trigger for "significant
interaction". Or perhaps you could give us an example of a use case in which
it'll be insufficient?
> when did a user significantly interact with
Hi Andy, thanks for your feedback.
It's true that only an application knows which fields require feedback
and which don't. That's why I don't propose to create a validation
framework in the core platform.
However, I don't think your solution addresses the point that I've raised.
While using timer
On Sat, 25 Mar 2023 15:50:21 GMT, Kevin Rushforth wrote:
> This PR skips three headful tests on Linux until the issues with the tests
> can be fixed. These tests consistently fail on our physical Ubuntu 22.04 test
> machine. This is a step towards getting clean headful test runs. Each of the
>
I also am skeptical regarding the need for API in the core platform to
support this.
-- Kevin
On 3/27/2023 9:46 AM, Andy Goryachev wrote:
I think this functionality belongs to the application-level code, not
in the platform. It's the application that knows which parts of a
form need the v
It's true that a choice needs to be made as to what should be
considered a significant interaction.
This proposal delegates the choice to skins, as that's where these
kinds of choices are generally made.
For example, skins also decide when a button's action is invoked, or
when a context menu opens.
I think this functionality belongs to the application-level code, not in the
platform. It's the application that knows which parts of a form need the
visual feedback and which do not. In my opinion, there is no APIs that are
missing in order to implement a validation framework of any level of
I can compare this with Vuetify framework, generally because it uses
good abstractions. It provides the three types of validation.
1. Eager - an input is validated immediately after loading (adding to
the scene). Usually it's initialized with some default valid value to
not disturb user.
2. In
On Mon, 27 Mar 2023 15:56:52 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/main/java/javafx/css/Match.java line 79:
>>
>>> 77: * @return the pseudo class state
>>> 78: */
>>> 79: public Set getPseudoClasses() {
>>
>> does this change need a CSR?
>
> Yes, thanks for ch
On Mon, 27 Mar 2023 15:40:47 GMT, Andy Goryachev wrote:
>> The class `PseudoClassState` is private API, but was exposed erroneously in
>> the CSS API. Instead, `Set` should have been used. This PR
>> corrects this.
>
> modules/javafx.graphics/src/main/java/javafx/css/Match.java line 79:
>
>> 7
On Mon, 27 Mar 2023 13:50:40 GMT, John Hendrikx wrote:
> The class `PseudoClassState` is private API, but was exposed erroneously in
> the CSS API. Instead, `Set` should have been used. This PR
> corrects this.
modules/javafx.graphics/src/main/java/javafx/css/Match.java line 79:
> 77: *
On Mon, 27 Mar 2023 13:50:40 GMT, John Hendrikx wrote:
> The class `PseudoClassState` is private API, but was exposed erroneously in
> the CSS API. Instead, `Set` should have been used. This PR
> corrects this.
This was clearly a mistake back when the public API was first created in JDK 9.
--
> Makes `Subscription` public (removing some of its methods that are
> unnecessary), and adds methods that can provide `Subscription`s in
> `ObservableValue`.
John Hendrikx has updated the pull request incrementally with one additional
commit since the last revision:
Move Subscription method
JDK-8304933: BitSet (used for CSS pseudo class states) listener management is
incorrect
-
Commit messages:
- Fix spelling error
- Fix bug in BitSet listener management
Changes: https://git.openjdk.org/jfx/pull/1071/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1071&range
The class `PseudoClassState` is private API, but was exposed erroneously in the
CSS API. Instead, `Set` should have been used. This PR corrects
this.
-
Commit messages:
- Remove references to PseudoClassState (private) in Match (public API)
Changes: https://git.openjdk.org/jfx/pul
21 matches
Mail list logo
