Re: RFR: 8306121: Scene not rendered initially when changing scenes after fix for JDK-8296621 [v4]

On Sat, 22 Apr 2023 17:00:50 GMT, Thiago Milczarek Sayao wrote: >> I replicated the fix on #1054 on Linux. >> >> Also fixes [Monocle: Stage no longer gets focus after fix for >> JDK-8296621](https://bugs.openjdk.org/browse/JDK-8304734) > > Thiago Milczarek Sayao has updated the pull request in

Re: RFR: 8306121: Scene not rendered initially when changing scenes after fix for JDK-8296621 [v5]

> I replicated the fix on #1054 on Linux. > > Also fixes [Monocle: Stage no longer gets focus after fix for > JDK-8296621](https://bugs.openjdk.org/browse/JDK-8304734) Thiago Milczarek Sayao has updated the pull request incrementally with one additional commit since the last revision: Change

Re: RFR: 8306121: Scene not rendered initially when changing scenes after fix for JDK-8296621 [v4]

> I replicated the fix on #1054 on Linux. > > Also fixes [Monocle: Stage no longer gets focus after fix for > JDK-8296621](https://bugs.openjdk.org/browse/JDK-8304734) Thiago Milczarek Sayao has updated the pull request incrementally with one additional commit since the last revision: Revert

Re: [External] : Re: PR to new language features from project amber

You're right. It's that common developer urge to refactor things. -- Thiago. Em sáb., 22 de abr. de 2023 às 11:31, Kevin Rushforth < kevin.rushfo...@oracle.com> escreveu: > I see. > > No, I wouldn't want to see a global change like this. In new code (or code > that it being significantly changed

Re: RFR: 8306121: Scene not rendered initially when changing scenes after fix for JDK-8296621 [v3]

> I replicated the fix on #1054 on Linux. > > Also fixes [Monocle: Stage no longer gets focus after fix for > JDK-8296621](https://bugs.openjdk.org/browse/JDK-8304734) Thiago Milczarek Sayao has updated the pull request incrementally with one additional commit since the last revision: The wi

Re: RFR: 8306121: Scene not rendered initially when changing scenes after fix for JDK-8296621 [v2]

On Sat, 22 Apr 2023 14:42:10 GMT, Kevin Rushforth wrote: >> Thiago Milczarek Sayao has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Request Focus on setVisible > > I'll look at this early next week. My initial question for you is: Why was

Re: RFR: 8306121: Scene not rendered initially when changing scenes after fix for JDK-8296621 [v2]

On Sat, 22 Apr 2023 13:24:54 GMT, Thiago Milczarek Sayao wrote: >> I replicated the fix on #1054 on Linux. >> >> Also fixes [Monocle: Stage no longer gets focus after fix for >> JDK-8296621](https://bugs.openjdk.org/browse/JDK-8304734) > > Thiago Milczarek Sayao has updated the pull request in

Re: [External] : Re: PR to new language features from project amber

I see. No, I wouldn't want to see a global change like this. In new code (or code that it being significantly changed), it is fine to use new language features like pattern-matching switch statements. We've already done this in some cases. However, I wouldn't want to see a wholesale modificat

Re: Linux IME work

Hi, I would like to make Linux IME work again. Ongoing work here: https://github.com/openjdk/jfx/pull/1080 Since I am not an IME user myself I'm not qualified to say when "It's ready" so I need feedback to continue. But with use case examples I can try myself and get it fixed until it's done. T

Re: PR to new language features from project amber

Sure, I meant something like: if (owner != null && owner instanceof WindowStage) { ((WindowStage) owner).setEnabled(true); } To: if (owner instanceof WindowStage windowStage) { windowStage.setEnabled(true); } Em sáb., 22 de abr. de 2023 às 11:09, Kevin Rushforth < kevin.rushfo...@oracl

Re: PR to new language features from project amber

The minimum JDK version is 17, so JavaFX cannot use any features that are only available in a later JDK. Further, we cannot use any preview features. -- Kevin On 4/22/2023 6:59 AM, Thiago Milczarek Sayão wrote: Hi, Can I submit PR for pattern matching or enhanced switches? I was thinking a

PR to new language features from project amber

Hi, Can I submit PR for pattern matching or enhanced switches? I was thinking about creating an umbrella project like "Adopt new language features from project amber" and submit "per module" and "per feature" PRs. -- Cheers

Re: RFR: 8306121: Scene not rendered initially when changing scenes after fix for JDK-8296621 [v2]

> I replicated the fix on #1054 on Linux. Thiago Milczarek Sayao has updated the pull request incrementally with one additional commit since the last revision: Request Focus on setVisible - Changes: - all: https://git.openjdk.org/jfx/pull/1110/files - new: https://git.openjdk

RFR: 8306121: Scene not rendered initially when changing scenes after fix for JDK-8296621

I replicated the fix on #1054 on Linux. - Commit messages: - fix mistake - Scene not rendered initially when changing scenes after fix for JDK-8296621 - Merge branch 'openjdk:master' into master - Merge branch 'openjdk:master' into master - Merge branch 'openjdk:master' into mast

Re: RFR: 8264591: HBox/VBox child widths pixel-snap to wrong value [v7]

On Tue, 3 Jan 2023 06:31:37 GMT, Michael Strauß wrote: >> The children of HBox/VBox don't always pixel-snap to the same value as the >> container itself when a render scale other than 1 is used. This can lead to >> a visual glitch where the content bounds don't line up with the container >> bo