On Thu, 4 May 2023 15:30:20 GMT, Andy Goryachev wrote:
>> tests/system/src/test/java/test/javafx/embed/swing/SwingNodeMemoryLeakTest.java
>> line 80:
>>
>>> 78: });
>>> 79:
>>> 80: SwingUtilities.invokeAndWait(() -> Util.sleep(500));
>>
>> Sleeping on either the JavaFX Applica
On Thu, 4 May 2023 09:46:28 GMT, John Hendrikx wrote:
>> Region has floor and ceiling functions that ensure that calling them twice
>> in a row will yield the same result:
>>
>> ceil(x) = ceil(ceil(x))
>>
>> However, due to use of a constant `EPSILON` which is added/subtracted before
>>
Adding TextFlow.underlineShape() to add support for a spellchecker-like
decoration, using
getRange(start, end, TextLayout.TYPE_UNDERLINE);
which mirrors an existing method in Text with exactly the same signature.
-
Commit messages:
- use the same javadoc as in Text
- whitespace
On Tue, 18 Apr 2023 12:17:53 GMT, John Hendrikx wrote:
>> Fix bug in CSS caching code that could reset values on unrelated nodes.
>>
>> The bug occurs due to a cache entry being constructed incorrectly when the
>> initial node that triggered the cache entry creation has user set values.
>> The
Note: the Java-side changes in this PR are also in #694 which fixes the same
issue (and more) on Linux. Unfortunately the Linux Robot code is not working
making it difficult to test on that platform (see #718).
KeyCharacterCombinations allow the specification of accelerators based on
characters
On Thu, 4 May 2023 12:05:45 GMT, Kevin Rushforth wrote:
>> Lukasz Kostyra has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update javafx.web classpath to include JMemoryBuddy
>
> tests/system/src/test/java/test/javafx/embed/swing/SwingNod
On Thu, 4 May 2023 09:47:02 GMT, John Hendrikx wrote:
> I think it was important to track down the root cause here
You are so right! I'll try to take a look today.
Without looking at the code, could we add a test (unless already done) which
exercise all the possible corner cases with Double -
On Thu, 4 May 2023 12:11:13 GMT, buedi wrote:
> Hello John, this issue occurs very rarely, approximately 1-2 times per month,
> on systems that run 24/7. However, when it does occur, the JavaFx application
> gets stuck in an endless loop (-->
> [logError-JavaFxScene.txt](https://github.com/ope
On Mon, 26 Dec 2022 03:03:50 GMT, Michael Strauß wrote:
> On Windows, a `Stage` that is restricted by minimum and maximum sizes can
> briefly be observed to appear with incorrect dimensions when it is first
> shown. The root cause of this bug is that the native `WinWindow._setBounds`
> method
On Thu, 4 May 2023 08:21:15 GMT, Lukasz Kostyra wrote:
>> Verified these changes on all platforms and saw no abnormalities in test
>> execution.
>>
>> This change is based on a preliminary patch done by @aghaisas , with some
>> minor changes and the addition of one Leak-related web test.
>> E
On Wed, 3 May 2023 11:46:50 GMT, buedi wrote:
> A null pointer exception occurs on the ScenePulseListener when iterating
> through the dirty node list.
> A null check is needed on the node before calling node.getScene().
>
> The error occurs occasionally and causes the application to crash.
He
On Wed, 3 May 2023 11:46:50 GMT, buedi wrote:
> A null pointer exception occurs on the ScenePulseListener when iterating
> through the dirty node list.
> A null check is needed on the node before calling node.getScene().
>
> The error occurs occasionally and causes the application to crash.
Hi
On Tue, 18 Apr 2023 16:17:52 GMT, John Hendrikx wrote:
> Focused only on raw type problems, and removing casts that were no longer
> needed because of the changes.
Patch seems okay for me, I also run it on Windows and macOS and tests are all
good.
I left a minor comment about some leftover im
On Wed, 3 May 2023 21:22:10 GMT, Marius Hanl wrote:
>> This PR adds a new constructor to `GridPane` that accepts a `hgap` and a
>> `vgap`.
>> As also written in the ticket, this is a small enhancement to improve the
>> creation of a layout involving a `GridPane` without FXML.
>> In my experienc
On Thu, 27 Apr 2023 15:23:33 GMT, Andy Goryachev wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix NaN returns when using Math.ulp
>
> modules/javafx.graphics/src/main/java/javafx/scene/layout/Region.java line
On Thu, 4 May 2023 09:46:28 GMT, John Hendrikx wrote:
>> Region has floor and ceiling functions that ensure that calling them twice
>> in a row will yield the same result:
>>
>> ceil(x) = ceil(ceil(x))
>>
>> However, due to use of a constant `EPSILON` which is added/subtracted before
>>
> Region has floor and ceiling functions that ensure that calling them twice in
> a row will yield the same result:
>
> ceil(x) = ceil(ceil(x))
>
> However, due to use of a constant `EPSILON` which is added/subtracted before
> doing the rounding, this only works for small numbers (in the r
> Verified these changes on all platforms and saw no abnormalities in test
> execution.
>
> This change is based on a preliminary patch done by @aghaisas , with some
> minor changes and the addition of one Leak-related web test.
> EventListenerLeak test was not touched, as it is a separate manu
On Wed, 3 May 2023 09:20:14 GMT, Lukasz Kostyra wrote:
>> Verified these changes on all platforms and saw no abnormalities in test
>> execution.
>>
>> This change is based on a preliminary patch done by @aghaisas , with some
>> minor changes and the addition of one Leak-related web test.
>> E
19 matches
Mail list logo
