On Sat, 20 May 2023 14:58:40 GMT, Kevin Rushforth wrote:
> Update the compiler on Windows to Visual Studio 2022 17.5.0. This provides
> the needed C++20 support for the next WebKit update.
>
> On Windows, the existing WebKit 615.1 build fails with Visual Studio 2022
> 17.5.0 -- see [JDK-830374
> Add the common base component for all the new implementing native classes
> Change native peer creation to use the new base component The new code will
> instantiate new protocol implementation for the given role if it exists or
> an old one if it does not exist
> Added BUTTON role implementi
On Thu, 25 May 2023 16:49:10 GMT, Kevin Rushforth wrote:
> This looks good. If you haven't already done so, can you change `@link` to
> `@code` in the CSR to match? I'll review that next.
done. Thanks for the reminder!
-
PR Comment: https://git.openjdk.org/jfx/pull/1135#issuecomme
On Thu, 25 May 2023 19:20:45 GMT, Kevin Rushforth wrote:
> Probably this is because the JDK decided to defer the update until JDK 22,
> but I'll check and let you know what I find.
Yes, I confirmed that this is the reason it didn't get pushed to jdk. The
following diff was used to produce our
On Sat, 20 May 2023 14:58:40 GMT, Kevin Rushforth wrote:
> Update the compiler on Windows to Visual Studio 2022 17.5.0. This provides
> the needed C++20 support for the next WebKit update.
>
> On Windows, the existing WebKit 615.1 build fails with Visual Studio 2022
> 17.5.0 -- see [JDK-830374
On Sat, 20 May 2023 14:56:16 GMT, Kevin Rushforth wrote:
> Update the compiler on Linux to gcc 12.2. This provides the needed C++20
> support for the next WebKit update.
Probably this is because the JDK decided to defer the update until JDK 22, but
I'll check and let you know what I find.
---
On Sat, 20 May 2023 14:56:16 GMT, Kevin Rushforth wrote:
> Update the compiler on Linux to gcc 12.2. This provides the needed C++20
> support for the next WebKit update.
I noticed that the devkit files in the OpenJDK project do not support gcc 12.2
yet?
https://github.com/openjdk/jdk/blob/mast
On Sat, 20 May 2023 14:58:40 GMT, Kevin Rushforth wrote:
> Update the compiler on Windows to Visual Studio 2022 17.5.0. This provides
> the needed C++20 support for the next WebKit update.
>
> On Windows, the existing WebKit 615.1 build fails with Visual Studio 2022
> 17.5.0 -- see [JDK-830374
On Fri, 19 May 2023 00:10:25 GMT, John Hendrikx wrote:
>> The class `PseudoClassState` is private API, but was exposed erroneously in
>> the CSS API. Instead, `Set` should have been used. This PR
>> corrects this.
>
> John Hendrikx has refreshed the contents of this pull request, and previous
> Update the compiler on macOS to Xcode 14.3. In addition to providing the
> needed C++20 support for the next WebKit update, initial testing by the JDK
> team shows that this fixes a reproducible builds problem, so it might help
> address [JDK-8306886](https://bugs.openjdk.org/browse/JDK-830688
On Thu, 25 May 2023 13:06:00 GMT, Nir Lisker wrote:
> Do you think that the "Size all columns to fit" option should be added here?
Added where? In his example custom menu? Maybe, but it isn't directly relevant
to the PR. Or did you mean something else?
-
PR Comment: https://git.op
On Wed, 24 May 2023 16:55:11 GMT, Marius Hanl wrote:
>> This PR implements a way to override the table column menu.
>> When the `cornerRegion` is pressed, it will now call the `showColumnMenu`
>> method. This new method is protected and therefore can be overidden by
>> developers. If not overr
On Thu, 27 Apr 2023 09:02:43 GMT, Nir Lisker wrote:
>> Notes to reviewers:
>>
>> 1. The `-since` option does not play well with the javafx one: if
>> documentation was added on a `private` property field with the `@since` tag,
>> it will not be included in the NEW and DEPRECATED lists. I presu
On Sat, 20 May 2023 14:47:50 GMT, Kevin Rushforth wrote:
> Update the compiler on macOS to Xcode 14.3. In addition to providing the
> needed C++20 support for the next WebKit update, initial testing by the JDK
> team shows that this fixes a reproducible builds problem, so it might help
> addre
On Sat, 20 May 2023 14:47:50 GMT, Kevin Rushforth wrote:
> Update the compiler on macOS to Xcode 14.3. In addition to providing the
> needed C++20 support for the next WebKit update, initial testing by the JDK
> team shows that this fixes a reproducible builds problem, so it might help
> addre
On Wed, 24 May 2023 16:55:11 GMT, Marius Hanl wrote:
>> This PR implements a way to override the table column menu.
>> When the `cornerRegion` is pressed, it will now call the `showColumnMenu`
>> method. This new method is protected and therefore can be overidden by
>> developers. If not overr
On Sat, 20 May 2023 14:56:16 GMT, Kevin Rushforth wrote:
> Update the compiler on Linux to gcc 12.2. This provides the needed C++20
> support for the next WebKit update.
Marked as reviewed by arapte (Reviewer).
-
PR Review: https://git.openjdk.org/jfx/pull/1141#pullrequestreview-1
On Wed, 24 May 2023 20:09:37 GMT, Nir Lisker wrote:
> For comparison, this is the Win 10 menu:
This one is the 'extended' menu (which funny enough looks like my example
above) (it's in german):
--
18 matches
Mail list logo
