Withdrawn: 8218745: TableView: visual glitch at borders on horizontal scrolling

2023-05-26 Thread duke
On Thu, 23 Sep 2021 19:01:52 GMT, Marius Hanl wrote: > This PR fixes an issue which is probably in JavaFX since VirtualFlow exists. > While horizontal scrolling any VirtualFlow control the left blue border > sometimes disappear/gets smaller. (see also image below) > > This can be fixed by **sna

Withdrawn: 8267546: Add CSS themes as a first-class concept

2023-05-26 Thread duke
On Fri, 21 May 2021 04:30:28 GMT, Michael Strauß wrote: > This PR adds style themes as a first-class concept to OpenJFX. A style theme > is a collection of stylesheets and the logic that governs them. Style themes > can respond to OS notifications and update their stylesheets dynamically. > Th

Withdrawn: 8273743: KeyCharacterCombination for "+" does not work on US QWERTY keyboard layout

2023-05-26 Thread duke
On Tue, 28 Sep 2021 21:01:13 GMT, Martin Fox wrote: > There was a mismatch between the way `get_glass_key` generated the Java key > code for a given key press and how `getKeyCodeForChar` determined the key > code for the matching character. For example, when pressing the plus sign on > a US ke

Withdrawn: 8274967: KeyCharacterCombinations for punctuation and symbols fail on non-US keyboards

2023-05-26 Thread duke
On Mon, 15 Nov 2021 20:13:11 GMT, Martin Fox wrote: > The code that maps from a Windows virtual key code to a Java key code in > `getKeyCodeForChar` did not match the similar code in > `ViewContainer::HandleViewKeyEvent`. The OEM keys are assigned to printable > punctuation and symbols in ways

Withdrawn: 8090522: Allow support for disabling stage iconification (minimization)

2023-05-26 Thread duke
On Thu, 19 May 2022 12:44:44 GMT, Paweł Kruszczyński wrote: > `Stage` minimalizing (iconified state) cannot be disabled for the user. The > same for `Stage` closable state. > PR adds these features without breaking backward compatibility. This pull request has been closed without being integrat

Withdrawn: 8290274: DRT 27 tests fail due to xml not well formed error on window

2023-05-26 Thread duke
On Wed, 10 Aug 2022 10:06:21 GMT, Jay Bhaskar wrote: > Issue: xml not well-formed error occurs at XML document parser. > Issue: doEnd() call not needed for JAVA platform, as it is making > XMLDocumentParserLibxml2 xml not well-formed error. This pull request has been closed without being integr

RFR: 8299756: Minor updates in CSS Reference

2023-05-26 Thread Andy Goryachev
Minor fixes and addition of missing sections: - The 'system' font is missing from the list of generic font family names in the section. ✓ - Explicitly add text color property -fx-fill to Text section, so as not to confuse with Labeled -fx-text-fill ✓ - TextFlow section is missing, properties: -

Re: RFR: 8293836: Rendering performance degradation at bottom of TableView with many rows

2023-05-26 Thread Andy Goryachev
On Wed, 19 Apr 2023 12:14:45 GMT, Johan Vos wrote: > Only update the VirtualFlow parameters in case the size of a cell has changed. > > The fixes for JDK-8298728 and JDK-8277785 introduced an unconditional > recalculation in case the size of a cell is set. This recalculation is only > needed i

Re: RFR: 8293836: Rendering performance degradation at bottom of TableView with many rows

2023-05-26 Thread Andy Goryachev
On Wed, 19 Apr 2023 12:14:45 GMT, Johan Vos wrote: > Only update the VirtualFlow parameters in case the size of a cell has changed. > > The fixes for JDK-8298728 and JDK-8277785 introduced an unconditional > recalculation in case the size of a cell is set. This recalculation is only > needed i

Re: RFR: 8308308: Update to Visual Studio 2022 version 17.5.0 on Windows

2023-05-26 Thread Joeri Sykora
On Sat, 20 May 2023 14:58:40 GMT, Kevin Rushforth wrote: > Update the compiler on Windows to Visual Studio 2022 17.5.0. This provides > the needed C++20 support for the next WebKit update. > > On Windows, the existing WebKit 615.1 build fails with Visual Studio 2022 > 17.5.0 -- see [JDK-830374

Application freeze on dialog close [Mac]

2023-05-26 Thread Craig Raw
I have multiple reports of application freeze (spinning beach ball) when a Dialog opened with showAndWait() is closed. The application does not recover and must be terminated with force quit. No error logging is produced. This only occurs on a Mac, and is rare, but can be consistently reproduced o