Withdrawn: 8252936: Optimize removal of listeners from ExpressionHelper.Generic

2023-06-09 Thread duke
On Thu, 6 Feb 2020 16:13:33 GMT, dannygonzalez wrote: > https://bugs.openjdk.java.net/browse/JDK-8185886 > > Optimisation to ExpressionHelper.Generic class to use Sets rather than Arrays > to improve listener removal speed. > > This was due to the removal of listeners in TableView taking up

Withdrawn: 8268642: Improve property system to facilitate correct usage

2023-06-09 Thread duke
On Tue, 27 Jul 2021 23:15:10 GMT, Michael Strauß wrote: > Based on previous discussions, this PR attempts to improve the JavaFX > property system by enforcing correct API usage in several cases that are > outlined below. It also streamlines the API by deprecating untyped APIs in > favor of

Re: RFR: JDK-8199216: Memory leak and quadratic layout time with nested nodes (hbox) and pseudo-class in style sheet [v8]

2023-06-09 Thread John Hendrikx
On Fri, 9 Jun 2023 22:08:53 GMT, Andy Goryachev wrote: > one question: since the JBS talks about memory leak, is it possible to devise > a test for that? > > otherwise, looks good. It's not really a memory leak, the amount of memory that it can take can just be quite large in the right

Re: RFR: JDK-8199216: Memory leak and quadratic layout time with nested nodes (hbox) and pseudo-class in style sheet [v6]

2023-06-09 Thread John Hendrikx
On Fri, 9 Jun 2023 22:11:10 GMT, Andy Goryachev wrote: >> modules/javafx.graphics/src/main/java/com/sun/javafx/css/BitSet.java line 44: >> >>> 42: * which makes matching faster. >>> 43: */ >>> 44: abstract class BitSet extends AbstractSet implements >>> ObservableSet { >> >> Since this is

Re: RFR: 8306021: Add event handler management to EventTarget [v4]

2023-06-09 Thread Kevin Rushforth
On Mon, 17 Apr 2023 06:00:19 GMT, Michael Strauß wrote: >> This PR adds the following methods to the `EventTarget` interface: >> 1. `addEventHandler` >> 2. `removeEventHandler` >> 3. `addEventFilter` >> 4. `removeEventFilter` > > Michael Strauß has updated the pull request incrementally with one

Re: RFR: JDK-8199216: Memory leak and quadratic layout time with nested nodes (hbox) and pseudo-class in style sheet [v6]

2023-06-09 Thread Andy Goryachev
On Tue, 25 Apr 2023 17:26:54 GMT, Andy Goryachev wrote: >> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Avoid using Lambda in ImmutablePseudoClassSetsCache.of() > >

Re: RFR: JDK-8199216: Memory leak and quadratic layout time with nested nodes (hbox) and pseudo-class in style sheet [v6]

2023-06-09 Thread Andy Goryachev
On Tue, 25 Apr 2023 07:14:07 GMT, John Hendrikx wrote: >> This fix introduces immutable sets of `PseudoClass` almost everywhere, as >> they are rarely modified. These are re-used by caching them in a new class >> `ImmutablePseudoClassSetsCache`. >> >> In order to make this work, `BitSet` had

Re: RFR: 8273743: KeyCharacterCombination for "+" does not work on US QWERTY keyboard layout [v5]

2023-06-09 Thread Martin Fox
On Fri, 9 Jun 2023 00:22:57 GMT, Thiago Milczarek Sayao wrote: >> Martin Fox has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updating classpath for Eclipse users > > tests/manual/events/KeyCharacterCombinationTest.java line 45: > >>

Re: RFR: JDK-8199216: Memory leak and quadratic layout time with nested nodes (hbox) and pseudo-class in style sheet [v8]

2023-06-09 Thread Andy Goryachev
On Fri, 9 Jun 2023 12:45:02 GMT, John Hendrikx wrote: >> This fix introduces immutable sets of `PseudoClass` almost everywhere, as >> they are rarely modified. These are re-used by caching them in a new class >> `ImmutablePseudoClassSetsCache`. >> >> In order to make this work, `BitSet` had

Re: RFR: 8089373: Translation from character to key code is not sufficient [v3]

2023-06-09 Thread Martin Fox
On Thu, 11 May 2023 02:46:47 GMT, Martin Fox wrote: >> Note: the Java-side changes in this PR are also in #694 which fixes the same >> issue (and more) on Linux. Unfortunately the Linux Robot code is not working >> making it difficult to test on that platform (see #718). >> >>

Re: RFR: 8089373: Translation from character to key code is not sufficient [v3]

2023-06-09 Thread Andy Goryachev
On Fri, 9 Jun 2023 18:25:39 GMT, Martin Fox wrote: > App developers have a hard time sorting this out There was a discussion on the mailing list about adding a doc/ folder with markdown informational notes. (Build instructions and snapping rules were the prime candidates for such notes).

Re: RFR: 8089373: Translation from character to key code is not sufficient [v3]

2023-06-09 Thread Martin Fox
On Thu, 11 May 2023 02:46:47 GMT, Martin Fox wrote: >> Note: the Java-side changes in this PR are also in #694 which fixes the same >> issue (and more) on Linux. Unfortunately the Linux Robot code is not working >> making it difficult to test on that platform (see #718). >> >>

Re: RFR: 8273743: KeyCharacterCombination for "+" does not work on US QWERTY keyboard layout [v3]

2023-06-09 Thread Andy Goryachev
On Fri, 9 Jun 2023 00:27:05 GMT, Martin Fox wrote: > The portion of this PR that is platform-agnostic was also submitted in PR > #1126. will take a look, thanks! - PR Comment: https://git.openjdk.org/jfx/pull/694#issuecomment-1584807626

Re: [External] : Text Surrounding

2023-06-09 Thread Andy Goryachev
Thiago: The IME support is in the plans, so thank you for the info. I am not there yet, but at least I can ask one question regarding the "surrounding" feature: how much text does it expect from the control? Is one line or paragraph enough? Let me ask another question: is the current IME

Re: RFR: 8309508: Possible memory leak in JPEG image loader

2023-06-09 Thread Kevin Rushforth
On Fri, 9 Jun 2023 05:18:16 GMT, Jayathirth D V wrote: > On code inspection it is revealed that in jpegloader.c->decompressIndirect() > we are allocating memory for "scanline_ptr", but if we error_exit() from > jpeg_read_scanlines() we are not releasing this memory. > > Added release of

Re: RFR: JDK-8199216: Memory leak and quadratic layout time with nested nodes (hbox) and pseudo-class in style sheet [v3]

2023-06-09 Thread John Hendrikx
On Tue, 25 Apr 2023 05:35:57 GMT, John Hendrikx wrote: >> modules/javafx.graphics/src/main/java/com/sun/javafx/css/BitSet.java line >> 243: >> >>> 241: public boolean containsAll(Collection c) { >>> 242: if (c == null) { >>> 243:throw new NullPointerException("c cannot

Re: RFR: JDK-8199216: Memory leak and quadratic layout time with nested nodes (hbox) and pseudo-class in style sheet [v8]

2023-06-09 Thread John Hendrikx
> This fix introduces immutable sets of `PseudoClass` almost everywhere, as > they are rarely modified. These are re-used by caching them in a new class > `ImmutablePseudoClassSetsCache`. > > In order to make this work, `BitSet` had to be cleaned up. It made > assumptions about the

Re: RFR: 8264449: Enable reproducible builds with SOURCE_DATE_EPOCH [v14]

2023-06-09 Thread Kevin Rushforth
On Wed, 26 Apr 2023 04:17:23 GMT, John Neffenger wrote: >> This pull request allows for reproducible builds of JavaFX on Linux, macOS, >> and Windows by defining the `SOURCE_DATE_EPOCH` environment variable. For >> example, the following commands create a reproducible build: >> >> >> $

Re: RFR: JDK-8199216: Memory leak and quadratic layout time with nested nodes (hbox) and pseudo-class in style sheet [v7]

2023-06-09 Thread John Hendrikx
> This fix introduces immutable sets of `PseudoClass` almost everywhere, as > they are rarely modified. These are re-used by caching them in a new class > `ImmutablePseudoClassSetsCache`. > > In order to make this work, `BitSet` had to be cleaned up. It made > assumptions about the

Re: RFR: JDK-8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v11]

2023-06-09 Thread John Hendrikx
> This provides and uses a new implementation of `ExpressionHelper`, called > `ListenerManager` with improved semantics. > > # Behavior > > |Listener...|ExpressionHelper|ListenerManager| > |---|---|---| > |Invocation Order|In order they were registered, invalidation listeners > always before

Intellij Idea project gradle import bug

2023-06-09 Thread Thiago Milczarek Sayão
Hi, The systemTests module is not being correctly imported on Intellij, so I reported a bug here: https://youtrack.jetbrains.com/issue/IDEA-322108/Intellij-Idea-fails-to-import-JavaFx-gradle-project-correctly Just letting Idea users know. -- Thiago.

Text Surrounding

2023-06-09 Thread Thiago Milczarek Sayão
Hi Andy, I understand you're working on a Rich Text control. While working on IME (Input Method Editor) for Linux, I noticed that there is a feature called "surrounding" that it supports to give the IME information about the text being inputted. More info here:

Re: How to run an app headless?

2023-06-09 Thread Thiago Milczarek Sayão
Hi Johan, I just wanted to replicate a simple test outside of the testing system to see why the behavior change in focus is happening on https://github.com/openjdk/jfx/pull/1110 So the solution Kevin replied to in this email was enough. The fix for this PR seems to have focused the button that

Re: How to run an app headless?

2023-06-09 Thread Johan Vos
The monocle classes are not included in the default distributions/artifact. In our downloads on https://gluonhq.com/products/javafx/ we have specific SDK's that include the Monocle classes. Note that we currently don't have automated builds for Linux x86-64, since we use a devkit compiled from

Re: RFR: 8087370: [odroid] Monocle: Touch is still broken on Odroid

2023-06-09 Thread Fabian Wolter
On Fri, 29 Apr 2022 14:59:41 GMT, Alexander Scherbatiy wrote: >> There are sometimes multitouch events detected, when only a single touch >> should be detected under certain conditions. This lead to touch events on >> previous touch positions. >> >> The referenced bug is closed with "won't