Re: RFR: 8304922: [testbug] SliderTooltipNPETest fails on Linux [v3]

2023-06-12 Thread Karthik P K
> The test was failing on the first run and then it was not failing. Cause for > the failure looked to be the UI state not getting updated. Hence added call > to `Toolkit` `firePulse` method. > > Able to run the test consistently without failure in Linux after the fix. Karthik P K has updated t

Re: RFR: 8304922: [testbug] SliderTooltipNPETest fails on Linux [v2]

2023-06-12 Thread Karthik P K
On Mon, 12 Jun 2023 21:35:46 GMT, Kevin Rushforth wrote: >> Karthik P K has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add latch for tooltip hide and mouse move events > > It still fails the first time I run it. I ran it on a physical m

Integrated: 8306021: Add event handler management to EventTarget

2023-06-12 Thread Michael Strauß
On Wed, 12 Apr 2023 18:19:11 GMT, Michael Strauß wrote: > This PR adds the following methods to the `EventTarget` interface: > 1. `addEventHandler` > 2. `removeEventHandler` > 3. `addEventFilter` > 4. `removeEventFilter` This pull request has now been integrated. Changeset: 614dc55f Author:

Re: RFR: 8278924: [Linux] Robot key test can fail if multiple keyboard layouts are installed [v3]

2023-06-12 Thread Martin Fox
On Mon, 17 Apr 2023 18:13:38 GMT, Martin Fox wrote: >> The Robot implementation on Linux did not consult the current layout when >> mapping from a KeyCode to a hardware code. Internally it retrieved results >> for all the layouts but just picked the first one it saw leading to random >> effect

Re: RFR: 8306021: Add event handler management to EventTarget [v5]

2023-06-12 Thread Kevin Rushforth
On Mon, 12 Jun 2023 18:17:17 GMT, Michael Strauß wrote: >> This PR adds the following methods to the `EventTarget` interface: >> 1. `addEventHandler` >> 2. `removeEventHandler` >> 3. `addEventFilter` >> 4. `removeEventFilter` > > Michael Strauß has updated the pull request incrementally with two

Re: RFR: 8306021: Add event handler management to EventTarget [v5]

2023-06-12 Thread John Hendrikx
On Mon, 12 Jun 2023 18:17:17 GMT, Michael Strauß wrote: >> This PR adds the following methods to the `EventTarget` interface: >> 1. `addEventHandler` >> 2. `removeEventHandler` >> 3. `addEventFilter` >> 4. `removeEventFilter` > > Michael Strauß has updated the pull request incrementally with two

Re: RFR: 8304922: [testbug] SliderTooltipNPETest fails on Linux [v2]

2023-06-12 Thread Kevin Rushforth
On Thu, 11 May 2023 12:00:59 GMT, Karthik P K wrote: >> The test was failing on the first run and then it was not failing. Cause for >> the failure looked to be the UI state not getting updated. Hence added call >> to `Toolkit` `firePulse` method. >> >> Able to run the test consistently withou

Re: RFR: 8306021: Add event handler management to EventTarget [v5]

2023-06-12 Thread Marius Hanl
On Mon, 12 Jun 2023 18:17:17 GMT, Michael Strauß wrote: >> This PR adds the following methods to the `EventTarget` interface: >> 1. `addEventHandler` >> 2. `removeEventHandler` >> 3. `addEventFilter` >> 4. `removeEventFilter` > > Michael Strauß has updated the pull request incrementally with two

Re: RFR: 8306021: Add event handler management to EventTarget [v5]

2023-06-12 Thread Andy Goryachev
On Mon, 12 Jun 2023 18:17:17 GMT, Michael Strauß wrote: >> This PR adds the following methods to the `EventTarget` interface: >> 1. `addEventHandler` >> 2. `removeEventHandler` >> 3. `addEventFilter` >> 4. `removeEventFilter` > > Michael Strauß has updated the pull request incrementally with two

Re: RFR: 8306021: Add event handler management to EventTarget [v5]

2023-06-12 Thread Nir Lisker
On Mon, 12 Jun 2023 18:17:17 GMT, Michael Strauß wrote: >> This PR adds the following methods to the `EventTarget` interface: >> 1. `addEventHandler` >> 2. `removeEventHandler` >> 3. `addEventFilter` >> 4. `removeEventFilter` > > Michael Strauß has updated the pull request incrementally with two

Withdrawn: JDK-8304323 Provide infrastructure to make it possible for properties to delay listener registration

2023-06-12 Thread duke
On Sun, 5 Feb 2023 13:07:25 GMT, John Hendrikx wrote: > This PR contains changes to make it easier to implement properties which want > to conserve resources until they're observed themselves. > > `isObserved` is promoted from `ObjectBinding` to the `ObservableValue` > interface, allowing yo

Re: RFR: 8306021: Add event handler management to EventTarget [v5]

2023-06-12 Thread Michael Strauß
> This PR adds the following methods to the `EventTarget` interface: > 1. `addEventHandler` > 2. `removeEventHandler` > 3. `addEventFilter` > 4. `removeEventFilter` Michael Strauß has updated the pull request incrementally with two additional commits since the last revision: - added tests - Co

Integrated: 8309508: Possible memory leak in JPEG image loader

2023-06-12 Thread Jayathirth D V
On Fri, 9 Jun 2023 05:18:16 GMT, Jayathirth D V wrote: > On code inspection it is revealed that in jpegloader.c->decompressIndirect() > we are allocating memory for "scanline_ptr", but if we error_exit() from > jpeg_read_scanlines() we are not releasing this memory. > > Added release of "scanl

Integrated: 8306648: Update the JavaDocs to show the NEW section and DEPRECATED versions

2023-06-12 Thread Nir Lisker
On Fri, 21 Apr 2023 13:18:31 GMT, Nir Lisker wrote: > Adds the javadoc commands to generate the NEW page and to be able to select > versions in the DEPRECATED page. This pull request has now been integrated. Changeset: 9913b23a Author:Nir Lisker URL: https://git.openjdk.org/jfx/com

Re: RFR: 8306648: Update the JavaDocs to show the NEW section and DEPRECATED versions [v2]

2023-06-12 Thread Andy Goryachev
On Thu, 27 Apr 2023 11:39:24 GMT, Nir Lisker wrote: >> Adds the javadoc commands to generate the NEW page and to be able to select >> versions in the DEPRECATED page. > > Nir Lisker has updated the pull request incrementally with one additional > commit since the last revision: > > Auto-dete

Re: RFR: 8309508: Possible memory leak in JPEG image loader

2023-06-12 Thread Ambarish Rapte
On Fri, 9 Jun 2023 05:18:16 GMT, Jayathirth D V wrote: > On code inspection it is revealed that in jpegloader.c->decompressIndirect() > we are allocating memory for "scanline_ptr", but if we error_exit() from > jpeg_read_scanlines() we are not releasing this memory. > > Added release of "scanl