Re: RFR: JDK-8310681: Update WebKit to 616.1

2023-07-23 Thread Jay Bhaskar
On Sun, 23 Jul 2023 15:55:39 GMT, Johan Vos wrote: > > Oh, I see that now. What led me to ask this question was that there is an > > alternative implementation in `#if PLATFORM(JAVA)`, which implies that we > > removed the call to `stripLeadingAndTrailingHTMLSpaces` and that it is > > still pr

Re: RFR: JDK-8310681: Update WebKit to 616.1

2023-07-23 Thread Jay Bhaskar
On Fri, 21 Jul 2023 16:52:27 GMT, Jay Bhaskar wrote: > absoluteLinkURL Agree - PR Comment: https://git.openjdk.org/jfx/pull/1180#issuecomment-1647113499

Re: RFR: JDK-8310681: Update WebKit to 616.1

2023-07-23 Thread Jay Bhaskar
On Sun, 23 Jul 2023 10:28:18 GMT, yosbits wrote: > I found a change to turn off DFGJIT by default, is this a fix for some > problem? > > modules/javafx.web/src/main/java/com/sun/webkit/WebPage.java The Change is required, as it is making issues with complex js code written for a website. ---

Re: Platform preferences API

2023-07-23 Thread Michael Strauß
I'd like to wrap up the discussion around the new `Appearance` enumeration proposed for the Platform Preferences API: public enum javafx.application.Appearance { LIGHT, DARK } When viewed with the goal of eventually supporting style themes, this might seem a bit limiting at first.

RFR: 8309558: Create implementation of NSAccessibilityCheckBox protocol

2023-07-23 Thread Alexander Zuev
also 8309629: Create implementation of NSAccessibilityRadioButton protocol Create implementation of NSAccessibilityCheckBox and NSAccessibilityRadioButton protocols Add workaround for the wrong focus owner announcement with radio buttons Add workaround for wrong magnifier text on buttons ---

Re: RFR: JDK-8310681: Update WebKit to 616.1

2023-07-23 Thread Johan Vos
On Fri, 21 Jul 2023 17:04:44 GMT, Kevin Rushforth wrote: > Oh, I see that now. What led me to ask this question was that there is an > alternative implementation in `#if PLATFORM(JAVA)`, which implies that we > removed the call to `stripLeadingAndTrailingHTMLSpaces` and that it is still > pres

Re: RFR: JDK-8310681: Update WebKit to 616.1

2023-07-23 Thread yosbits
On Thu, 20 Jul 2023 15:36:28 GMT, Hima Bindu Meda wrote: > Updated JavaFX Webkit to GTK WebKit 2.40 (616.1). > Verified the updated version build, sanity tests and stability. No issues > have been observed. I found a change to turn off DFGJIT by default, is this a fix for some problem? modules