Re: RFR: 8274932: Render scales in EmbeddedWindow are not properly updated [v8]

2023-08-02 Thread Prasanta Sadhukhan
> When the JavaFX scene is set before it is really shown, then the scale > factors are not properly propagated to the EmbeddedWindow, resulting in > showing wrong scales. > Fix is made to update scales to EmbeddedWindow Prasanta Sadhukhan has updated the pull request incrementally with one

Re: RFR: 8274932: Render scales in EmbeddedWindow are not properly updated [v6]

2023-08-02 Thread Kevin Rushforth
On Wed, 2 Aug 2023 04:24:37 GMT, Prasanta Sadhukhan wrote: > Only question I have is, should updateSceneState be called in > QuantumToolkit.runWithRenderLock synchronization? We probably do need to acquire the lock. All but one call to that method is done with the `renderLock` held. A bigger

Re: RFR: 8301302: Platform preferences API [v4]

2023-08-02 Thread Kevin Rushforth
On Mon, 24 Jul 2023 17:45:31 GMT, Michael Strauß wrote: >> Please read [this >> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) >> for an introduction to the Platform Preferences API, and how it interacts >> with the proposed style theme and stage appearance

RFR: JDK-8311983: ListView sometimes throws an IndexOutOfBoundsException

2023-08-02 Thread Marius Hanl
An IOOBE was thrown when scrolling up via the trough (-> `VirtualScrollBar#adjustValue`). This happened only when it has bigger cells than the viewport. If the the uppermost cell with the index 0 is only visible (although not completely scrolled to the top) and then an attempt is made to scroll

Re: RFR: JDK-8313628: Column drag header, overlay and line are not correctly aligned

2023-08-02 Thread Marius Hanl
On Wed, 2 Aug 2023 16:36:47 GMT, Marius Hanl wrote: > When a table has padding or the `layoutChildren` method inside the table skin > is overridden (and x/y are modified), the drag drag header, column overlay > and column line are not correctly aligned. > > The reason is that the positions

RFR: JDK-8313628: Column drag header, overlay and line are not correctly aligned

2023-08-02 Thread Marius Hanl
When a table has padding or the `layoutChildren` method inside the table skin is overridden (and x/y are modified), the drag drag header, column overlay and column line are not correctly aligned. The reason is that the positions were calculated incorrectly. - **Column overlay and column line**

Re: RFR: 8274932: Render scales in EmbeddedWindow are not properly updated [v6]

2023-08-02 Thread Kevin Rushforth
On Wed, 2 Aug 2023 04:24:37 GMT, Prasanta Sadhukhan wrote: > I think JDK-8274932 is about scale correction and JDK-809 is about > content refresh in different-scaled configuration so I dont think one is > duplicate of another. OK, thanks for doing the `/issue add` then. Don't forget do

[jfx21u] Integrated: 8313177: Web Workers timeout with Webkit 616.1

2023-08-02 Thread Jay Bhaskar
clean backport for jfx21u. The fix is for the js web worker timeout ( some tests fail to finish) - Commit messages: - Backport 5f5e54feb2e816dcb351a28862c798117c3f81e8 Changes: https://git.openjdk.org/jfx21u/pull/5/files Webrev: https://webrevs.openjdk.org/?repo=jfx21u=5=00

[jfx21u] Integrated: 8313177: Web Workers timeout with Webkit 616.1

2023-08-02 Thread Jay Bhaskar
On Wed, 2 Aug 2023 12:23:04 GMT, Jay Bhaskar wrote: > clean backport for jfx21u. The fix is for the js web worker timeout ( some > tests fail to finish) This pull request has now been integrated. Changeset: a9161e83 Author:Jay Bhaskar URL:

Re: RFR: 8260342: FXMLLoader fails to load a sub layout using fx:include with the resources attribute [v2]

2023-08-02 Thread Guillaume Tâche
On Tue, 1 Aug 2023 10:04:25 GMT, Ajit Ghaisas wrote: >> Guillaume Tâche has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Empty commit > > modules/javafx.fxml/src/main/java/javafx/fxml/FXMLLoader.java line 1101: > >> 1099:

Re: RFR: 8260342: FXMLLoader fails to load a sub layout using fx:include with the resources attribute [v3]

2023-08-02 Thread Guillaume Tâche
> This fixes ResourceBundle loading by calling `ResourceBundle.getBundle(value, > Locale.getDefault())` when the loader resources are null or their classloader > is null. > Apparently the original author of the bug report said they would submit a > pull request, but it seems like it never

Withdrawn: JDK-8222209: Repaint properly when JFXPanel moves to another screen

2023-08-02 Thread John Hendrikx
On Fri, 28 Jul 2023 09:26:35 GMT, John Hendrikx wrote: > Alternative fix for JFXPanel issues. > > I added an extra line to **really** trigger the repainting in > `EmbeddedScene`. This was inspired by this code in `GlassWindowEventHandler` > which reacts to `WindowEvent.RESCALE`. It not only