Backport of https://bugs.openjdk.org/browse/JDK-8312058
-
Commit messages:
- Backport be2c7aea20c7752f069e526d2c3f9bea11bc1634
Changes: https://git.openjdk.org/jfx/pull/1218/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1218&range=00
Issue: https://bugs.openjdk.org/brows
On Fri, 9 Jun 2023 12:00:06 GMT, John Hendrikx wrote:
>> This provides and uses a new implementation of `ExpressionHelper`, called
>> `ListenerManager` with improved semantics.
>>
>> # Behavior
>>
>> |Listener...|ExpressionHelper|ListenerManager|
>> |---|---|---|
>> |Invocation Order|In order
On Mon, 21 Aug 2023 15:56:59 GMT, Andy Goryachev wrote:
>> 1. Creating a new `javafx.scene.ContainsProperties` interface that declares
>> two methods:
>> - public ObservableMap getProperties();
>> - public boolean hasProperties();
>>
>> 2. Node, MenuItem, and Toggle now extend ContainsPropertie
On Mon, 21 Aug 2023 23:11:49 GMT, Andy Goryachev wrote:
>> In the Control hierarchy, all property accessor methods must be declared
>> `final`.
>>
>> Added a test to check for missing `final` keyword and added the said keyword
>> where required.
>
> Andy Goryachev has updated the pull request
On Mon, 21 Aug 2023 22:16:12 GMT, Nir Lisker wrote:
>> Thank you for suggestions!
>>
>> Frankly, I don't see much value in rewriting of this method. A more
>> interesting problem is how to enumerate all descendants of the Control class
>> using the package name, in such a way that will relia
> In the Control hierarchy, all property accessor methods must be declared
> `final`.
>
> Added a test to check for missing `final` keyword and added the said keyword
> where required.
Andy Goryachev has updated the pull request incrementally with one additional
commit since the last revision:
On Mon, 21 Aug 2023 22:16:50 GMT, Andy Goryachev wrote:
>>> these classes (in javafx.scene.control.cell) are public and in the Control
>>> hierarchy, so are subject of the 'final' limitation.
>>
>> I'm confused. Which classes should appear in this list exactly (what are the
>> rules to determi
On Mon, 21 Aug 2023 22:14:28 GMT, Nir Lisker wrote:
> Which classes should appear in this list exactly
subclasses of javafx.scene.control.Control
-
PR Review Comment: https://git.openjdk.org/jfx/pull/1213#discussion_r1300705312
On Mon, 21 Aug 2023 15:27:44 GMT, Andy Goryachev wrote:
> these classes (in javafx.scene.control.cell) are public and in the Control
> hierarchy, so are subject of the 'final' limitation.
I'm confused. Which classes should appear in this list exactly (what are the
rules to determine that)?
>
On Mon, 21 Aug 2023 20:52:51 GMT, Martin Fox wrote:
> behavior is erratic
thank you for testing and the insights, @beldenfox !
this is exactly my experience, esp. re: exact steps to reproduce. which makes
me think that the issue might be in the way we call either swing or fx from the
wrong t
On Mon, 21 Aug 2023 16:19:55 GMT, Andy Goryachev wrote:
>> When Japanse (IME on) is inputted to the TextFIeld, which is on JFXPanel,
>> small window for inputting appears on top-left side of screen
>>
>> ` method for
>> character index calculation was not correct when Text node was embedded in
>> TextFlow. Hence wrong character index value was calculated for the same.
>>
>> Since only
On Mon, 21 Aug 2023 14:40:09 GMT, Andy Goryachev wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/text/PrismTextLayout.java
> line 782:
>
>>
> The text run selected in `PrismTextLayout::getHitInfo()` method for character
> index calculation was not correct when Text node was embedded in TextFlow.
> Hence wrong character index value was calculated for the same.
>
> Since only x, y coordinates were available in the above mentioned meth
On Tue, 4 Jul 2023 05:54:54 GMT, Prasanta Sadhukhan
wrote:
> When Japanse (IME on) is inputted to the TextFIeld, which is on JFXPanel,
> small window for inputting appears on top-left side of screen
>
> ;
> - public boolean hasProperties();
>
> 2. Node, MenuItem, and Toggle now extend ContainsProperties interface.
>
> 3. Making implemented methods in Node, MenuIte
On Sun, 20 Aug 2023 06:16:06 GMT, Nir Lisker wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comments
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/ControlPropertiesTest.java
> line
> In the Control hierarchy, all property accessor methods must be declared
> `final`.
>
> Added a test to check for missing `final` keyword and added the said keyword
> where required.
Andy Goryachev has updated the pull request with a new target base due to a
merge or a rebase. The incrementa
On Sun, 20 Aug 2023 21:17:18 GMT, Nir Lisker wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comments
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/ControlPropertiesTest.java
> line
On Mon, 21 Aug 2023 14:01:06 GMT, Karthik P K wrote:
>> The text run selected in `PrismTextLayout::getHitInfo()` method for
>> character index calculation was not correct when Text node was embedded in
>> TextFlow. Hence wrong character index value was calculated for the same.
>>
>> Since only
On Mon, 21 Aug 2023 14:01:06 GMT, Karthik P K wrote:
>> The text run selected in `PrismTextLayout::getHitInfo()` method for
>> character index calculation was not correct when Text node was embedded in
>> TextFlow. Hence wrong character index value was calculated for the same.
>>
>> Since only
On Wed, 16 Aug 2023 20:32:54 GMT, Andy Goryachev wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix character index calculation issue when Text node content is wrapped
>
> modules/javafx.graphics/src/main/java/com/
On Wed, 16 Aug 2023 20:15:05 GMT, Andy Goryachev wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix character index calculation issue when Text node content is wrapped
>
> modules/javafx.graphics/src/main/java/com/
> The text run selected in `PrismTextLayout::getHitInfo()` method for character
> index calculation was not correct when Text node was embedded in TextFlow.
> Hence wrong character index value was calculated for the same.
>
> Since only x, y coordinates were available in the above mentioned meth
On Thu, 13 Jul 2023 21:13:06 GMT, John Hendrikx wrote:
> Incorporates documentation review comments from #1069.
>
> This PR should be kept minimal so it can be backported to JFX21; it should
> only contain documentation changes.
This pull request has now been integrated.
Changeset: be2c7aea
A
On Fri, 11 Aug 2023 22:03:28 GMT, John Hendrikx wrote:
>> Incorporates documentation review comments from #1069.
>>
>> This PR should be kept minimal so it can be backported to JFX21; it should
>> only contain documentation changes.
>
> John Hendrikx has updated the pull request incrementally w
On Thu, 6 Jul 2023 13:10:44 GMT, Prasanta Sadhukhan
wrote:
> When the JavaFX scene is set before it is really shown, then the scale
> factors are not properly propagated to the EmbeddedWindow, resulting in
> showing wrong scales.
> Fix is made to update scales to EmbeddedWindow
This pull requ
28 matches
Mail list logo
