RFR: 8315317: Add test for JDK-8262518

Added automated test for 8262518:SwingNode.setContent does not close previous content, resulting in memory leak - Commit messages: - jckeck fix - 8315317: Add test for JDK-8262518 Changes: https://git.openjdk.org/jfx/pull/1228/files Webrev: https://webrevs.openjdk.org/?repo=jfx&p

Re: [jfx-tests] RFR: JDK-8315409: Fix jfx-tests so they work with latest jfx build

On Thu, 31 Aug 2023 20:22:09 GMT, Alexandre Iline wrote: > JDK-8315409: Fix jfx-tests so they work with latest jfx build The changes look reasonable to me. I'll rely on Ajit to sanity test it. I did note a few copyright issues that you might want to look at. At a minimum, the missing comma af

Re: [jfx-tests] RFR: JDK-8315409: Fix jfx-tests so they work with latest jfx build

On Thu, 31 Aug 2023 20:22:09 GMT, Alexandre Iline wrote: > JDK-8315409: Fix jfx-tests so they work with latest jfx build Normally, a single reviewer would be sufficient (as with most test bugs), but for this initial fix, I'd like @aghaisas to sanity check it as well. - PR Comment

Re: RFR: 8255248: NullPointerException in JFXPanel due to race condition in HostContainer [v7]

On Thu, 31 Aug 2023 20:13:40 GMT, John Hendrikx wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add nullcheck for sceneState > > The changes as they are now are IMHO entirely inadequate. Simply surrounding

Re: RFR: 8255248: NullPointerException in JFXPanel due to race condition in HostContainer [v7]

On Thu, 31 Aug 2023 20:13:40 GMT, John Hendrikx wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add nullcheck for sceneState > > The changes as they are now are IMHO entirely inadequate. Simply surrounding

[jfx-tests] RFR: JDK-8315409: Fix jfx-tests so they work with latest jfx build

JDK-8315409: Fix jfx-tests so they work with latest jfx build - Commit messages: - JDK-8315409: Fix jfx-tests so they work with latest jfx build Changes: https://git.openjdk.org/jfx-tests/pull/1/files Webrev: https://webrevs.openjdk.org/?repo=jfx-tests&pr=1&range=00 Issue: https:

Re: RFR: 8255248: NullPointerException in JFXPanel due to race condition in HostContainer [v7]

On Wed, 30 Aug 2023 06:49:52 GMT, Prasanta Sadhukhan wrote: >> Due to transient datatype of scenePeer, it can become null which can result >> in NPE in scenarios where scene is continuously been reset and set, which >> warrants a null check, as is done in other places for the same variable. >

Re: RFR: 8255248: NullPointerException in JFXPanel due to race condition in HostContainer [v7]

On Wed, 30 Aug 2023 06:49:52 GMT, Prasanta Sadhukhan wrote: >> Due to transient datatype of scenePeer, it can become null which can result >> in NPE in scenarios where scene is continuously been reset and set, which >> warrants a null check, as is done in other places for the same variable. >

Re: RFR: 8255248: NullPointerException in JFXPanel due to race condition in HostContainer [v7]

On Wed, 30 Aug 2023 06:49:52 GMT, Prasanta Sadhukhan wrote: >> Due to transient datatype of scenePeer, it can become null which can result >> in NPE in scenarios where scene is continuously been reset and set, which >> warrants a null check, as is done in other places for the same variable. >

Re: RFR: 8255248: NullPointerException in JFXPanel due to race condition in HostContainer [v3]

On Fri, 21 Jul 2023 18:06:22 GMT, Andy Goryachev wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Check FXEnabled initially > > tests/system/src/test/java/test/javafx/embed/swing/JFXPanelNPETest.java line > 1

Re: RFR: 8296266: TextArea: Navigation breaks with RTL text

On Wed, 30 Aug 2023 12:10:37 GMT, Karthik P K wrote: >> The fix uses character BreakIterator instead of the logic that relies on >> caretBounds/hitTest/rangeShape in TextInputControl.nextCharacterVisually(). >> >> I believe this is a more reliable method of navigation, as it behaves in >> sync

Re: RFR: 8313556: Create implementation of NSAccessibilitySlider protocol [v3]

On Wed, 30 Aug 2023 17:50:37 GMT, Alexander Zuev wrote: >> Create implementation for Slider and Stepper accessibility protocols. >> Fix mapping. >> Fix performAction parameter type in declaration. > > Alexander Zuev has updated the pull request incrementally with one additional > commit since th

jfx21u open for JavaFX 21.0.1 backports

I just noticed that I didn't send this out. I thought I had sent this over a month ago, but it was sitting in my Drafts folder. Given where we are in the release cycle for the October release, plan to get fixes for JavaFX 21.0.1 into jfx21u no later than Monday, September 11th. -

Re: RFR: 8311097: Synchron XMLHttpRequest not receiving data

On Wed, 30 Aug 2023 14:32:37 GMT, Andrew Brygin wrote: > This issue is a regression from 7e48413eb0 8285881: Update WebKit to 614.1. > For synchronous requests, we have an additional buffer to collect data, and > the appending data into this buffer is doing in a wrong way: we use > Vector::a

Re: RFR: 8311097: Synchron XMLHttpRequest not receiving data

On Wed, 30 Aug 2023 14:32:37 GMT, Andrew Brygin wrote: > This issue is a regression from 7e48413eb0 8285881: Update WebKit to 614.1. > For synchronous requests, we have an additional buffer to collect data, and > the appending data into this buffer is doing in a wrong way: we use > Vector::a

Re: Page size inaccurate/broken, which solution?

Did you mean javafx.print.Paper instead of java.print.Page? If so, then I think that the getWidth/getHeight functions should be fixed as they're not specified to do any rounding.  They return a double, and specify they return this in points.  Nowhere does it mention they're rounded to an integ

jfx-tests repo: JemmyFX test suite

As part of an effort to increase test coverage of JavaFX, particularity in the graphics area, we are reviving the JemmyFX test suite that was hosted in the Mercurial jfx-dev/tests repo [1]. To that end, we have converted the tests repo to git (using the Skara tooling), and made it available on

Page size inaccurate/broken, which solution?

Hi JavaFX Developer! The Problem: On the class java.print.Page , the methods “getWidth" and “getHeight" don’t return the correct values. It especially causes problems when the Paper is defined in mm. This happens mainly because of this method, which rounds down to full p