Integrated: 8283675: Line not removed from LineChart when series cleared

2023-09-03 Thread Karthik P K
On Fri, 18 Aug 2023 07:25:28 GMT, Karthik P K wrote: > The issue is present in AreaChart along with the LineChart. Issue is fixed in > both the charts as part of this PR. > The line elements in case of Line chart and both line element and fill > element in the case of Area charts were not

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor

2023-09-03 Thread Thiago Milczarek Sayao
On Mon, 15 May 2023 00:15:05 GMT, Martin Fox wrote: >> Dead keys should work now, but not sure I covered them all. > > @tsayao You should expand your test app to show TYPED KeyEvents or use the > KeyEventViewer app I just attached to the original bug report. Then run it > against an unmodified

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor

2023-09-03 Thread leewyatt
On Sun, 2 Apr 2023 20:38:25 GMT, Thiago Milczarek Sayao wrote: > This replaces obsolete XIM and uses gtk api for IME. > Gtk uses [ibus](https://github.com/ibus/ibus) > > Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative > positioning on `InputMethodRequest`. Thank

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor

2023-09-03 Thread Martin Fox
On Sun, 14 May 2023 22:17:30 GMT, Thiago Milczarek Sayao wrote: >> This replaces obsolete XIM and uses gtk api for IME. >> Gtk uses [ibus](https://github.com/ibus/ibus) >> >> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative >> positioning on `InputMethodRequest`. >

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor

2023-09-03 Thread Martin Fox
On Sat, 6 May 2023 23:11:21 GMT, Thiago Milczarek Sayao wrote: >> I see that this PR changes the behavior of dead keys. You may be aware of >> this but I thought I would write this up for others to review. >> >> In the past when the user pressed a dead key they got no feedback until they >>

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor

2023-09-03 Thread Thiago Milczarek Sayao
On Sun, 2 Apr 2023 20:38:25 GMT, Thiago Milczarek Sayao wrote: > This replaces obsolete XIM and uses gtk api for IME. > Gtk uses [ibus](https://github.com/ibus/ibus) > > Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative > positioning on `InputMethodRequest`. Thank

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor

2023-09-03 Thread Thiago Milczarek Sayao
On Tue, 25 Apr 2023 19:13:14 GMT, Martin Fox wrote: >> This replaces obsolete XIM and uses gtk api for IME. >> Gtk uses [ibus](https://github.com/ibus/ibus) >> >> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative >> positioning on `InputMethodRequest`. > > I see that

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor

2023-09-03 Thread Martin Fox
On Sun, 2 Apr 2023 20:38:25 GMT, Thiago Milczarek Sayao wrote: > This replaces obsolete XIM and uses gtk api for IME. > Gtk uses [ibus](https://github.com/ibus/ibus) > > Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative > positioning on `InputMethodRequest`. I see

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor

2023-09-03 Thread Glavo
On Sun, 2 Apr 2023 20:38:25 GMT, Thiago Milczarek Sayao wrote: > This replaces obsolete XIM and uses gtk api for IME. > Gtk uses [ibus](https://github.com/ibus/ibus) > > Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative > positioning on `InputMethodRequest`. I am a

RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor

2023-09-03 Thread Thiago Milczarek Sayao
This replaces obsolete XIM and uses gtk api for IME. Gtk uses [ibus](https://github.com/ibus/ibus) Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative positioning on `InputMethodRequest`. - Commit messages: - Don't highlight for dead keys - Don't move the

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor

2023-09-03 Thread Thiago Milczarek Sayao
On Mon, 3 Apr 2023 12:20:10 GMT, Glavo wrote: >> This replaces obsolete XIM and uses gtk api for IME. >> Gtk uses [ibus](https://github.com/ibus/ibus) >> >> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative >> positioning on `InputMethodRequest`. > > I am a native

[jfx17u] Integrated: 8307960: Create Table Column PopupMenu lazily

2023-09-03 Thread Jose Pereda
On Sun, 3 Sep 2023 18:46:48 GMT, Jose Pereda wrote: > Almost clean backport of 8307960: Create Table Column PopupMenu lazily > Reviewed-by: angorya > > There was a conflict from JDK-8297414: Remove easy warnings in > javafx.controls, that was easily fixed. This pull request has now been

Re: [jfx17u] RFR: 8307960: Create Table Column PopupMenu lazily

2023-09-03 Thread Johan Vos
On Sun, 3 Sep 2023 18:46:48 GMT, Jose Pereda wrote: > Almost clean backport of 8307960: Create Table Column PopupMenu lazily > Reviewed-by: angorya > > There was a conflict from JDK-8297414: Remove easy warnings in > javafx.controls, that was easily fixed. There was only a very minor change

[jfx17u] RFR: 8307960: Create Table Column PopupMenu lazily

2023-09-03 Thread Jose Pereda
Almost clean backport of 8307960: Create Table Column PopupMenu lazily Reviewed-by: angorya There was a conflict from JDK-8297414: Remove easy warnings in javafx.controls, that was easily fixed. - Commit messages: - 8307960: Create Table Column PopupMenu lazily Changes:

Re: RFR: 8308644: [Linux] Missing mappings for dead keys + Alt Gr [v5]

2023-09-03 Thread Thiago Milczarek Sayao
On Thu, 22 Jun 2023 11:45:30 GMT, Thiago Milczarek Sayao wrote: >> This PR adds missing key mappings for dead keys and fixes "Alt Gr" for some >> systems. > > Thiago Milczarek Sayao has updated the pull request with a new target base > due to a merge or a rebase. The incremental webrev

Re: RFR: 8251240: Menus inaccessible on Linux with i3 wm

2023-09-03 Thread Thiago Milczarek Sayao
On Sun, 9 Jul 2023 17:43:05 GMT, Thiago Milczarek Sayao wrote: > The bug happens because `gdk_window_get_frame_extents` is not returning the > correct position when o i3-wm, probably by some bug on the wm itself. > > Te fix replaces the usage of the function for already known extents value >