On Mon, 11 Sep 2023 15:55:44 GMT, Kevin Rushforth wrote:
> This PR adds missing range checks in the native `_getItemAsRawImage` and
> `ByteArrayFromPixels` methods in `GlassPasteboard.m` (for both mac and ios).
>
> Note that these checks are _very_ unlikely to ever detect an error in
> practic
On Mon, 11 Sep 2023 15:55:44 GMT, Kevin Rushforth wrote:
> This PR adds missing range checks in the native `_getItemAsRawImage` and
> `ByteArrayFromPixels` methods in `GlassPasteboard.m` (for both mac and ios).
>
> Note that these checks are _very_ unlikely to ever detect an error in
> practic
On Tue, 12 Sep 2023 22:42:10 GMT, Kevin Rushforth wrote:
>> Release notes for JavaFX 21, including four important changes, and the list
>> of enhancements and bugs fixed in this release.
>>
>> I plan to integrate this on Monday, Sep 18th, and backport it to `jfx21` in
>> time for Tuesday's rel
On Tue, 12 Sep 2023 22:42:10 GMT, Kevin Rushforth wrote:
>> Release notes for JavaFX 21, including four important changes, and the list
>> of enhancements and bugs fixed in this release.
>>
>> I plan to integrate this on Monday, Sep 18th, and backport it to `jfx21` in
>> time for Tuesday's rel
> This fix introduces immutable sets of `PseudoClass` almost everywhere, as
> they are rarely modified. These are re-used by caching them in a new class
> `ImmutablePseudoClassSetsCache`.
>
> In order to make this work, `BitSet` had to be cleaned up. It made
> assumptions about the collection
On Tue, 12 Sep 2023 17:17:09 GMT, Kevin Rushforth wrote:
> @hjohn Can you review the important change notices for the return type of
> `javafx.css.Match::getPseudoClasses` and the addition of the event handler
> methods to the `EventTarget` interface?
I've reviewed both, and they both look goo
On Tue, 12 Sep 2023 22:42:10 GMT, Kevin Rushforth wrote:
>> Release notes for JavaFX 21, including four important changes, and the list
>> of enhancements and bugs fixed in this release.
>>
>> I plan to integrate this on Monday, Sep 18th, and backport it to `jfx21` in
>> time for Tuesday's rel
On Tue, 12 Sep 2023 07:07:27 GMT, Marius Hanl wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/ControlContractTest.java
>> line 44:
>>
>>> 42: import static org.junit.jupiter.api.Assertions.assertTrue;
>>> 43:
>>> 44: class ControlContractTest {
>>
>> Do you plan to a
On Thu, 7 Sep 2023 00:25:48 GMT, John Hendrikx wrote:
>> This fix introduces immutable sets of `PseudoClass` almost everywhere, as
>> they are rarely modified. These are re-used by caching them in a new class
>> `ImmutablePseudoClassSetsCache`.
>>
>> In order to make this work, `BitSet` had t
> Release notes for JavaFX 21, including four important changes, and the list
> of enhancements and bugs fixed in this release.
>
> I plan to integrate this on Monday, Sep 18th, and backport it to `jfx21` in
> time for Tuesday's release of JavaFX 21.
Kevin Rushforth has updated the pull request
On Tue, 12 Sep 2023 20:38:06 GMT, Abhinay Agarwal wrote:
> Why are [8305885](https://bugs.openjdk.org/browse/JDK-8305885) and
> [8304290](https://bugs.openjdk.org/browse/JDK-8304290) not included in
> release notes?
They were in the initial list I had, and then I went through and excluded a
n
On Tue, 12 Sep 2023 17:31:23 GMT, Kevin Rushforth wrote:
>> doc-files/release-notes-21.md line 13:
>>
>>> 11: ### JavaFX Requires macOS 11 or Later
>>> 12:
>>> 13: On Mac platforms, JavaFX 21 requires macOS 11 or later. An exception
>>> will be thrown when initializing the JavaFX runtime on ol
On Tue, 12 Sep 2023 13:19:46 GMT, John Hendrikx wrote:
>> John Hendrikx has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Use standard asserts in test
>> - Add copyright header
>
> I think this will be as ready as it gets, let me know i
On Tue, 12 Sep 2023 17:14:28 GMT, Kevin Rushforth wrote:
> Release notes for JavaFX 21, including four important changes, and the list
> of enhancements and bugs fixed in this release.
>
> I plan to integrate this on Monday, Sep 18th, and backport it to `jfx21` in
> time for Tuesday's release
On Tue, 12 Sep 2023 17:25:12 GMT, Andy Goryachev wrote:
>> Release notes for JavaFX 21, including four important changes, and the list
>> of enhancements and bugs fixed in this release.
>>
>> I plan to integrate this on Monday, Sep 18th, and backport it to `jfx21` in
>> time for Tuesday's rele
On Tue, 12 Sep 2023 17:14:28 GMT, Kevin Rushforth wrote:
> Release notes for JavaFX 21, including four important changes, and the list
> of enhancements and bugs fixed in this release.
>
> I plan to integrate this on Monday, Sep 18th, and backport it to `jfx21` in
> time for Tuesday's release
On Tue, 12 Sep 2023 17:14:28 GMT, Kevin Rushforth wrote:
> Release notes for JavaFX 21, including four important changes, and the list
> of enhancements and bugs fixed in this release.
>
> I plan to integrate this on Monday, Sep 18th, and backport it to `jfx21` in
> time for Tuesday's release
Release notes for JavaFX 21, including four important changes, and the list of
enhancements and bugs fixed in this release.
I plan to integrate this on Monday, Sep 18th, and backport it to `jfx21` in
time for Tuesday's release of JavaFX 21.
-
Commit messages:
- 8316135: Create rel
On Thu, 7 Sep 2023 00:25:48 GMT, John Hendrikx wrote:
>> This fix introduces immutable sets of `PseudoClass` almost everywhere, as
>> they are rarely modified. These are re-used by caching them in a new class
>> `ImmutablePseudoClassSetsCache`.
>>
>> In order to make this work, `BitSet` had t
On Tue, 12 Sep 2023 14:38:12 GMT, Ajit Ghaisas wrote:
> test/scenegraph/functional/graphics/Effects2Test.java has a total of 123 test
> cases. Out of which 122 test cases pass and 1 test case (Lightningspotlight)
> fails consistently. Right now, the root cause of this test failure is unknown.
>
On Tue, 12 Sep 2023 14:38:12 GMT, Ajit Ghaisas wrote:
> test/scenegraph/functional/graphics/Effects2Test.java has a total of 123 test
> cases. Out of which 122 test cases pass and 1 test case (Lightningspotlight)
> fails consistently. Right now, the root cause of this test failure is unknown.
>
test/scenegraph/functional/graphics/Effects2Test.java has a total of 123 test
cases. Out of which 122 test cases pass and 1 test case (Lightningspotlight)
fails consistently. Right now, the root cause of this test failure is unknown.
This PR marks this test case with `@Ignore`. It will be fixed
On Thu, 7 Sep 2023 00:25:48 GMT, John Hendrikx wrote:
>> This fix introduces immutable sets of `PseudoClass` almost everywhere, as
>> they are rarely modified. These are re-used by caching them in a new class
>> `ImmutablePseudoClassSetsCache`.
>>
>> In order to make this work, `BitSet` had t
test/scenegraph/richtext/RichTextLabeledsTest.java
test/scenegraph/richtext/RichTextMixedTest.java
test/scenegraph/richtext/RichTextRectangleTest.java
test/scenegraph/richtext/RichTextTextTest.java
These tests were failing with - java.lang.IllegalStateException: This
operation is permitted on th
On Mon, 11 Sep 2023 15:55:44 GMT, Kevin Rushforth wrote:
> This PR adds missing range checks in the native `_getItemAsRawImage` and
> `ByteArrayFromPixels` methods in `GlassPasteboard.m` (for both mac and ios).
>
> Note that these checks are _very_ unlikely to ever detect an error in
> practic
On Thu, 7 Sep 2023 22:04:46 GMT, Andy Goryachev wrote:
>> Marius Hanl has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> JDK-8315569: Set a min size
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/ControlContractTest.jav
26 matches
Mail list logo
