RFR: 8318115: Webkit build fails after gradle 8.4

2023-10-13 Thread Ambarish Rapte
Few dependency were missed to be added for webkit build. With this change webkit build completes successfully. Please review - Commit messages: - webkit build fail fix Changes: https://git.openjdk.org/jfx/pull/1261/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1261&range=0

RFR: 8314968: Public InputMap

2023-10-13 Thread Andy Goryachev
Summary: - public InputMap, KeyBinding, BehaviorBase in javafx.scene.control.behavior package - InputMap allows for adding key mappings on control (user-defined) and behavior (defined by the skin) levels - two stage mapping: key binding -> function tag -> function; enables a wide range of contro

Re: RFR: 8306083: Text.hitTest is incorrect when more than one Text node in TextFlow [v10]

2023-10-13 Thread Andy Goryachev
On Fri, 13 Oct 2023 07:01:51 GMT, Karthik P K wrote: >> The text run selected in `PrismTextLayout::getHitInfo()` method for >> character index calculation was not correct when hitTest was invoked for >> Text node in a TextFlow with more than one Text child. Hence wrong character >> index value

Re: RFR: 8296266: TextArea: Navigation breaks with RTL text [v3]

2023-10-13 Thread Andy Goryachev
> The fix uses character BreakIterator instead of the logic that relies on > caretBounds/hitTest/rangeShape in TextInputControl.nextCharacterVisually(). > > I believe this is a more reliable method of navigation, as it behaves in sync > with the jdk break iterator, thought it might work differen

Integrated: 8314906: [testbug] Create behavior tests for text input controls

2023-10-13 Thread Andy Goryachev
On Wed, 23 Aug 2023 23:30:50 GMT, Andy Goryachev wrote: > Creating the first batch of tests and testing framework that enables writing > behavior tests for javafx controls, focusing on key bindings. The idea is to > make writing such tests a simple process. > > This PR deals with the descen

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v10]

2023-10-13 Thread Thiago Milczarek Sayao
On Thu, 28 Sep 2023 01:05:20 GMT, Thiago Milczarek Sayao wrote: >> This replaces obsolete XIM and uses gtk api for IME. >> Gtk uses [ibus](https://github.com/ibus/ibus) >> >> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative >> positioning on `InputMethodRequest`. >>

Re: RFR: 8306083: Text.hitTest is incorrect when more than one Text node in TextFlow [v10]

2023-10-13 Thread Karthik P K
On Fri, 13 Oct 2023 07:01:51 GMT, Karthik P K wrote: >> The text run selected in `PrismTextLayout::getHitInfo()` method for >> character index calculation was not correct when hitTest was invoked for >> Text node in a TextFlow with more than one Text child. Hence wrong character >> index value

Re: RFR: 8314906: [testbug] Create behavior tests for text input controls [v11]

2023-10-13 Thread Ajit Ghaisas
On Thu, 12 Oct 2023 17:08:39 GMT, Andy Goryachev wrote: >> Creating the first batch of tests and testing framework that enables writing >> behavior tests for javafx controls, focusing on key bindings. The idea is >> to make writing such tests a simple process. >> >> This PR deals with the d

Re: RFR: 8306083: Text.hitTest is incorrect when more than one Text node in TextFlow [v9]

2023-10-13 Thread Karthik P K
On Thu, 12 Oct 2023 09:40:18 GMT, Karthik P K wrote: >> The text run selected in `PrismTextLayout::getHitInfo()` method for >> character index calculation was not correct when hitTest was invoked for >> Text node in a TextFlow with more than one Text child. Hence wrong character >> index value

Re: RFR: 8306083: Text.hitTest is incorrect when more than one Text node in TextFlow [v10]

2023-10-13 Thread Karthik P K
> The text run selected in `PrismTextLayout::getHitInfo()` method for character > index calculation was not correct when hitTest was invoked for Text node in a > TextFlow with more than one Text child. Hence wrong character index value was > calculated. > > Since only x, y coordinates were avai