Re: RFR: 8301302: Platform preferences API [v15]

2023-10-16 Thread Michael Strauß
On Fri, 8 Sep 2023 05:17:43 GMT, Michael Strauß wrote: >> Please read [this >> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) >> for an introduction to the Platform Preferences API, and how it interacts >> with the proposed style theme and stage appearance features.

Re: RFR: JDK-8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v11]

2023-10-16 Thread Michael Strauß
On Mon, 24 Jul 2023 22:09:49 GMT, John Hendrikx wrote: >> modules/javafx.base/src/main/java/com/sun/javafx/binding/ListenerManager.java >> line 143: >> >>> 141: */ >>> 142: public void fireValueChanged(I instance, T oldValue) { >>> 143: Object data = getData(instance); >> >>

Re: RFR: 8306083: Text.hitTest is incorrect when more than one Text node in TextFlow [v7]

2023-10-16 Thread Karthik P K
On Wed, 27 Sep 2023 15:33:17 GMT, Phil Race wrote: >> Changes requested by prr (Reviewer). > >> @prrace could you please take a look at this? > > Hmm. I did last week, but I see my review comments were still pending. I > don't know why, I thought I submitted them. Now submitted for sure.

RFR: 8318204: Use new EventTarget methods in ListenerHelper

2023-10-16 Thread Michael Strauß
As of OpenJFX 21, `EventTarget` has methods to add and remove event listeners. The `instanceof` checks in `com.sun.javafx.scene.control.ListenerHelper` should be removed and replaced by a simple call to the respective interface method. - Commit messages: - Use new EventTarget

Re: Wayland

2023-10-16 Thread Thiago Milczarek Sayão
Hi, I am investigating about prism on Wayland. It looks like we could just replace the GLX calls on X11 backend to EGL and it will work on both (maybe rename it). It will need some work to pass the native display around - it assumes X11 Display everywhere and it could be a Display or a

Re: RFR: 8317508: Provide media support for libavcodec version 60

2023-10-16 Thread Victor Dyakov
On Fri, 13 Oct 2023 01:24:36 GMT, Alexander Matveev wrote: > - Added support for libavcodec version 60. > - Tested on Ubuntu 23.10 with all possible media formats. > - Changed "--disable-yasm" to "--disable-asm". "--disable-asm" disables all > assembler optimization and "--disable-yasm" only

Re: [External] : Re: [Request for Comments] Behavior / InputMap

2023-10-16 Thread Andy Goryachev
Sorry, I meant an example / use case where it is important and cannot be solved by the existing machinery. Any change in this area is going to introduce a major regression risk, and before we talk about changing the foundation we need to make sure we are solving a problem that exists. -andy

Re: [External] : Re: [Request for Comments] Behavior / InputMap

2023-10-16 Thread Martin Fox
Andy, John Hendrikx has given specific instances where this is breaking down already. The JavaDoc suggest that you can handle events on a node by installing event handlers. What it does not say is that a control may have already installed some unknown number of event handlers and there’s no

Re: Alternative approach for behaviors, leveraging existing event system

2023-10-16 Thread John Hendrikx
Hi Andy, Thanks for the quick response! Let me see if I can clarify some of your questions. Thank you, John, for a detailed writeup. Before going into details, I would like to ask you to clarify some of the aspects of the alternative proposal: 1. What is the API for setting user event

Re: [External] : Re: [Request for Comments] Behavior / InputMap

2023-10-16 Thread Andy Goryachev
Martin: What would be the use case for creating a public EventHandlerManager? In general, what is the problem we are trying to address that is impossible to solve using the existing machinery? Thank you -andy From: Martin Fox Date: Saturday, October 14, 2023 at 14:48 To: John Hendrikx Cc:

Re: [External] : Re: [Request for Comments] Behavior / InputMap

2023-10-16 Thread Andy Goryachev
Thank you for clarification! I just want to mention that here we are straying into what looks like a parallel discussion about skins (nothing wrong about it!). just the Skin part. This would likely be a big effort but perhaps it could be split into smaller tasks till the end goal is achieved.

Re: Alternative approach for behaviors, leveraging existing event system

2023-10-16 Thread Andy Goryachev
Thank you, John, for a detailed writeup. Before going into details, I would like to ask you to clarify some of the aspects of the alternative proposal: 1. What is the API for setting user event handlers vs. behavior event handlers? 2. Is there a way to conditionally invoke the default

Re: [External] : Re: Question: bidi navigation

2023-10-16 Thread Andy Goryachev
Nir, thank you for responding! The behavior you describe (“logical” navigation) is what can be seen in many, but not all applications, and that is what puzzles me. What’s more interesting, the applications that use a “visual” kind of navigation, that is the RIGHT ARROW key always moving the

Re: Question: bidi navigation

2023-10-16 Thread Nir Lisker
This is a tricky one. All applications I have seen, and I think that's what people expect, is that the cursor changes direction during traversal. A key point is where the paragraph is aligned to (in Windows adjusted with left CTRL+SHIFT and right CTRL+SHIFT). This sets the forward and backward

Alternative approach for behaviors, leveraging existing event system

2023-10-16 Thread John Hendrikx
Hi Andy, hi list, I've had the weekend to think about the proposal made by Andy Goryachev to make some of the API's surrounding InputMap / Behaviors public. I'm having some nagging doubts if that proposal is really the way forward, and I'd like to explore a different approach which leverages