Integrated: JDK-8315569: Tests for the contract of SkinBase.layoutChildren(..)

On Sat, 2 Sep 2023 12:54:36 GMT, Marius Hanl wrote: > This PR adds a test that verifies the `SkinBase.layoutChildren(..)` method > with different scales. > While not explicitly documented, this method will receive the snapped and > correctly calculated x, y, width and height values, so that chi

Re: RFR: 8185831: Psuedo selectors do not appear to work in Node.lookupAll() [v2]

On Wed, 18 Oct 2023 18:07:53 GMT, Andy Goryachev wrote: >> Sai Pradeep Dandem has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8185831: Fixed test failing issues and code review comments > > modules/javafx.graphics/src/main/java/javafx/sc

Re: RFR: 8185831: Psuedo selectors do not appear to work in Node.lookupAll() [v4]

On Wed, 18 Oct 2023 18:03:05 GMT, Andy Goryachev wrote: >> Sai Pradeep Dandem has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8185831: Fixed code review comments > > modules/javafx.graphics/src/test/java/test/javafx/scene/Node_lookup_Tes

Re: RFR: 8185831: Psuedo selectors do not appear to work in Node.lookupAll() [v4]

> **Issue:** > Using pseudo classes in programmatic query using Node.lookupAll() or > Node.lookup() gives unexpected results. > > **Cause:** > There is no check for checking the psuedo states matching in the applies() > method of SimpleSelector.java. So checking for "applies()" alone is not > s

Re: RFR: 8185831: Psuedo selectors do not appear to work in Node.lookupAll() [v3]

> **Issue:** > Using pseudo classes in programmatic query using Node.lookupAll() or > Node.lookup() gives unexpected results. > > **Cause:** > There is no check for checking the psuedo states matching in the applies() > method of SimpleSelector.java. So checking for "applies()" alone is not > s

Re: RFR: 8314968: Public InputMap [v2]

> Summary: > - public InputMap, KeyBinding, BehaviorBase in javafx.scene.control.behavior > package > - InputMap allows for adding key mappings on control (user-defined) and > behavior (defined by the skin) levels > - two stage mapping: key binding -> function tag -> function; enables a wide > r

Re: [External] : Re: Alternative approach for behaviors, leveraging existing event system

Dear John, thank you for clarifications. Sorry for my delayed response. I think we need more meat for question #1 - it is not yet clear. All event handlers end up in the control’s list, and we know that the ordering may be undetermined (or, rather, depend on whether it’s the first skin, or the

Re: Alternative approach for behaviors, leveraging existing event system

I wonder if this might encroach upon application-specific requirements/logic (that is, does not belong to the control behavior). For example, when the user enters text in a TextArea inside of a multi-cell notebook style application, SELECT_ALL (ctrl-A) may trigger select all on that TextArea, o

Re: [External] : Re: [Request for Comments] Behavior / InputMap

Dear Michael: Thank you for the feedback! Some of it should, in my opinion, be discussed in a separate email thread (feel free to start one), but let me respond to your comments relevant to the input map proposal. The whole reason we are having this discussion is to come to an agreement. The

Re: [External] : Re: Question: bidi navigation

So it seems Swing never calls Java2D's TextLayout.getCaretShapes() API which is what would provide the split carets. Swing's caret is an instance of javax.swing.text.DefaultCaret which has support for rendering a "flag" that indicates the direction of the caret bias. Split caret is however us

Re: RFR: 8185831: Psuedo selectors do not appear to work in Node.lookupAll() [v2]

On Wed, 18 Oct 2023 03:45:32 GMT, Sai Pradeep Dandem wrote: >> **Issue:** >> Using pseudo classes in programmatic query using Node.lookupAll() or >> Node.lookup() gives unexpected results. >> >> **Cause:** >> There is no check for checking the psuedo states matching in the applies() >> method

Re: RFR: 8185831: Psuedo selectors do not appear to work in Node.lookupAll() [v2]

On Tue, 19 Sep 2023 12:43:12 GMT, Kevin Rushforth wrote: >> Sai Pradeep Dandem has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8185831: Fixed test failing issues and code review comments > > This causes many test failures, which suggests

Re: RFR: 8316419: [macos] Setting X/Y makes Stage maximization not work before show

On Thu, 12 Oct 2023 05:52:04 GMT, Martin Fox wrote: > When a window is visible the maximized, iconified, and fullscreen properties > are two-way streets; changes made in Java are sent on to the platform window > and changes in the platform window are sent back into Java. > > When a window is h

Re: [External] : Re: Question: bidi navigation

Thank you, Nir. Try this link: https://web.archive.org/web/20120802192035/http://developer.apple.com/legacy/mac/library/documentation/Carbon/Conceptual/ATSUI_Concepts/atsui.pdf

Re: RFR: 8317508: Provide media support for libavcodec version 60

On Fri, 13 Oct 2023 01:24:36 GMT, Alexander Matveev wrote: > - Added support for libavcodec version 60. > - Tested on Ubuntu 23.10 with all possible media formats. > - Changed "--disable-yasm" to "--disable-asm". "--disable-asm" disables all > assembler optimization and "--disable-yasm" only x8

Re: Alternative approach for behaviors, leveraging existing event system

John, I want to explore this a bit further. I think there are two separate proposals in here. In most UI toolkits there’s one or may ways to translate a key event into an action. For example, Ctrl-C yields the Copy action and the right arrow key yields the moveRight action. This is done in a c

Re: [External] : Re: Question: bidi navigation

I've never seen this dual caret system. The link you gave leads to a 404 error. I can't comment as to the plan without knowing what Prism was designed to do, but it's rather unusual. The logical navigation choice seems correct regardless. On Tue, Oct 17, 2023 at 7:13 PM Andy Goryachev wrote: >

Re: RFR: 8205067: Resizing window with TextField hides text value

On Tue, 17 Oct 2023 12:15:14 GMT, Karthik P K wrote: > Because of a missing conditional check in the `updateTextPos()`, the > `textTranslateX` value was not getting updated when TextField size was > changed as a result of resizing window. > > Updated the CENTER and LEFT cases in the `updateTe

Re: RFR: 8317508: Provide media support for libavcodec version 60

On Fri, 13 Oct 2023 01:24:36 GMT, Alexander Matveev wrote: > - Added support for libavcodec version 60. > - Tested on Ubuntu 23.10 with all possible media formats. > - Changed "--disable-yasm" to "--disable-asm". "--disable-asm" disables all > assembler optimization and "--disable-yasm" only x8

Integrated: 8313321 : Set minimum python version in WebKit cmake scripts

On Wed, 9 Aug 2023 07:31:57 GMT, Hima Bindu Meda wrote: > Minimum version of python ,to run webkit build , on linux is set to 3.6 and > for other platforms, minimum version of python is set to 3.8. > > Verified build on all platforms. No issue seen This pull request has now been integrated. C

Not an issue [Re: JavaFX, WebView and the WebP vulnerability]

I apologize for not testing this earlier. Safari supports WebP images, so I naively assumed this to be a generic feature of WebKit. As it turns out, this it not the case. The WebView component in JavaFX does not support WebP so I assume that JavaFX was never affected by the WebP vulnerability.

Re: RFR: 8185831: Psuedo selectors do not appear to work in Node.lookupAll() [v2]

On Wed, 18 Oct 2023 03:45:32 GMT, Sai Pradeep Dandem wrote: >> **Issue:** >> Using pseudo classes in programmatic query using Node.lookupAll() or >> Node.lookup() gives unexpected results. >> >> **Cause:** >> There is no check for checking the psuedo states matching in the applies() >> method

Re: RFR: 8313321 : Set minimum python version in WebKit cmake scripts [v3]

On Wed, 11 Oct 2023 03:58:01 GMT, Hima Bindu Meda wrote: >> Minimum version of python ,to run webkit build , on linux is set to 3.6 and >> for other platforms, minimum version of python is set to 3.8. >> >> Verified build on all platforms. No issue seen > > Hima Bindu Meda has updated the pull

Re: RFR: 8318204: Use new EventTarget methods in ListenerHelper

On Tue, 17 Oct 2023 14:27:19 GMT, Andy Goryachev wrote: > it's a functional interface, so no gadgets at all. Both are functional interfaces. I think that `Subscription` can replace it, but isn't critical. - PR Comment: https://git.openjdk.org/jfx/pull/1262#issuecomment-1768249992

Re: RFR: 8316419: [macos] Setting X/Y makes Stage maximization not work before show

On Thu, 12 Oct 2023 05:52:04 GMT, Martin Fox wrote: > When a window is visible the maximized, iconified, and fullscreen properties > are two-way streets; changes made in Java are sent on to the platform window > and changes in the platform window are sent back into Java. > > When a window is h