Re: Prioritized event handlers

2023-10-24 Thread Michael Strauß
Hi John, > - Would an event handler like KeyEvent.ANY at Preferred priority be > called before one for KeyEvent.KEY_PRESSED at Default or System priority? Yes. > - The consumed flag doesn't change any other behavior? Consumed events > only are passed to handlers at the same level, but are not b

Re: Several GTK issues on latest Ubuntu release

2023-10-24 Thread Thiago Milczarek Sayão
I suspect something changed on the window manager (mutter in the case of default Ubuntu/gnome). One problem is that focusing the window is restoring it's state - so if you focus a maximized window the window manager restores it - looks like a bug. In the case of JavaFX the native side is calling

RFR: 8318630: TextAreaBehaviorRobotTest.testNonMacBindings fails on Linux

2023-10-24 Thread Andy Goryachev
Corrected the test: ctrl-DOWN moves to the end of the current paragraph (linux) or beginning of the next paragraph (windows). - Commit messages: - linux Changes: https://git.openjdk.org/jfx/pull/1270/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1270&range=00 Issue: htt

Re: RFR: 8316423: [linux] Secondary Stage does not respect Scene's dimensions when shown [v7]

2023-10-24 Thread Thiago Milczarek Sayao
On Sun, 15 Oct 2023 13:25:15 GMT, Thiago Milczarek Sayao wrote: >> The bug on the title happens because `gtk_widget_realize()` was called on >> the constructor. It creates the internal underlying window `GdkWindow` and >> `XWindow` messing the Gtk expected order. It's probably a Mutter change

Re: RFR: 8316423: [linux] Secondary Stage does not respect Scene's dimensions when shown [v8]

2023-10-24 Thread Thiago Milczarek Sayao
> The bug on the title happens because `gtk_widget_realize()` was called on the > constructor. It creates the internal underlying window `GdkWindow` and > `XWindow` messing the Gtk expected order. It's probably a Mutter change > rather than Gtk. But makes sense to not realize it before expected

Re: RFR: Draft: 8316423: [linux] Secondary Stage does not respect Scene's dimensions when shown [v7]

2023-10-24 Thread Thiago Milczarek Sayao
On Sun, 15 Oct 2023 13:25:15 GMT, Thiago Milczarek Sayao wrote: >> The bug on the title happens because `gtk_widget_realize()` was called on >> the constructor. It creates the internal underlying window `GdkWindow` and >> `XWindow` messing the Gtk expected order. It actually it's probably a M

Integrated: 8318708: FX: Update copyright year in docs, readme files to 2024

2023-10-24 Thread Ambarish Rapte
On Tue, 24 Oct 2023 11:13:54 GMT, Ambarish Rapte wrote: > Update Copyright year in these 3 doc files to 2024. This pull request has now been integrated. Changeset: 2aa69e01 Author:Ambarish Rapte URL: https://git.openjdk.org/jfx/commit/2aa69e0120976c77df35adcdb4908df1b55f8281 Stats:

Integrated: 8318714: Update copyright header for files modified in 2023

2023-10-24 Thread Ambarish Rapte
On Tue, 24 Oct 2023 12:28:34 GMT, Ambarish Rapte wrote: > Update copyright year to 2023 in files modified in this year 2023. This pull request has now been integrated. Changeset: bce15aa9 Author:Ambarish Rapte URL: https://git.openjdk.org/jfx/commit/bce15aa9e4c3e454a20ac17840f7abfe6

Re: RFR: 8318714: Update copyright header for files modified in 2023

2023-10-24 Thread Kevin Rushforth
On Tue, 24 Oct 2023 12:28:34 GMT, Ambarish Rapte wrote: > Update copyright year to 2023 in files modified in this year 2023. Marked as reviewed by kcr (Lead). - PR Review: https://git.openjdk.org/jfx/pull/1268#pullrequestreview-1694747979

Re: RFR: 8318708: FX: Update copyright year in docs, readme files to 2024

2023-10-24 Thread Kevin Rushforth
On Tue, 24 Oct 2023 11:13:54 GMT, Ambarish Rapte wrote: > Update Copyright year in these 3 doc files to 2024. Marked as reviewed by kcr (Lead). - PR Review: https://git.openjdk.org/jfx/pull/1267#pullrequestreview-1694735888

RFR: 8318714: Update copyright header for files modified in 2023

2023-10-24 Thread Ambarish Rapte
Update copyright year to 2023 in files modified in this year 2023. - Commit messages: - copyright year 2023 Changes: https://git.openjdk.org/jfx/pull/1268/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1268&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318714 Sta

Re: [External] : Re: Proof of concept pull request for Behavior API (PR 1265)

2023-10-24 Thread John Hendrikx
On 23/10/2023 23:57, Andy Goryachev wrote: You'd create a new class, `MyBehavior`, By “customizing” I also mean at run time. Creating new classes wouldn’t work. This would also work at runtime, as the class you create can be instantiated with parameters that control its key binding behavio

RFR: 8318708: FX: Update copyright year in docs, readme files to 2024

2023-10-24 Thread Ambarish Rapte
Update Copyright year in these 3 doc files to 2024. - Commit messages: - update cpr-year in docs to 2024 Changes: https://git.openjdk.org/jfx/pull/1267/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1267&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318708 Stats:

Re: Exploring the prism es2 land - couple of questions

2023-10-24 Thread Thiago Milczarek Sayão
Lukasz, Thanks for the answer, it makes sense. I was able to replace GLX with EGL for X11, but it does not work on Wayland rendering directly to the window (I've confirmed with GTK devs). So the way to go is to use DMABUF to render offscreen and share the buffer with GTK - by my research it's do

Re: Prioritized event handlers

2023-10-24 Thread John Hendrikx
Looks very nice Michael, I especially like the more sane behavior with regards to consumed events. I have a few questions on this: - Would an event handler like KeyEvent.ANY at Preferred priority be called before one for KeyEvent.KEY_PRESSED at Default or System priority? - The consumed flag

RE: Exploring the prism es2 land - couple of questions

2023-10-24 Thread Lukasz Kostyra
Hi, I don’t have much ES2 experience, so I cannot really answer 1). But I think I can somewhat answer 2) based on Windows OpenGL knowledge. This might be a situation similar to how Windows handles GL contexts. When you create a context in modern GL (3.0 and onwards, aka. Core) you must acquire