On Tue, 17 Oct 2023 12:15:14 GMT, Karthik P K wrote:
> Because of a missing conditional check in the `updateTextPos()`, the
> `textTranslateX` value was not getting updated when TextField size was
> changed as a result of resizing window.
>
> Updated the CENTER and LEFT cases in the `updateTe
On Wed, 25 Oct 2023 15:28:14 GMT, Andy Goryachev wrote:
> Can you provide an automated test for this fix?
I agree on the points shared by @andy-goryachev-oracle on this.
I also tried to write both unit test and system test but couldn't succeed
because the issue could not be reproduced in the un
> - The consumed flag doesn't change any other behavior? Consumed events
> only are passed to handlers at the same level, but are not bubbled up
> (or captured down); having consumed events not be passed to event
> handlers (even at the same level) seems like a more sane default for sure
I pulled
On Tue, 19 Sep 2023 11:56:39 GMT, Florian Kirmaier
wrote:
> The Method javafx.print.getWidth and getHeight returns a double of points.
> But the values are always rounded to full integers. This causes especially
> problems,
> with mm based Papers.
>
> I asked in the mailing list, with the conc
On Tue, 8 Aug 2023 23:44:58 GMT, Jose Pereda wrote:
>> So far, BorderPane does the calculation for the children min/pref
>> width/height taken into account only the margin applied to them, if any, but
>> not the total padding that could be applied as well to the BorderPane itself.
>>
>> Howeve
> Summary:
> - public InputMap, KeyBinding, BehaviorBase in javafx.scene.control.behavior
> package
> - InputMap allows for adding key mappings on control (user-defined) and
> behavior (defined by the skin) levels
> - two stage mapping: key binding -> function tag -> function; enables a wide
> r
Dear John:
It is difficult to review the alternative proposal for a number of reasons. A
prototype is a good start, but for any proposal to go forward we need a bit
more work. Let me enumerate the steps that we expect:
1. Provide an overview of the proposal following a JEP outline:
Summary
G
On Wed, 25 Oct 2023 22:16:59 GMT, Andy Goryachev wrote:
>> Florian Kirmaier has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> c
On Tue, 26 Sep 2023 08:43:47 GMT, Florian Kirmaier
wrote:
>> It's "a bit" complicated.
>> In some situations, getRuns get's called because listeners on bounds are set.
>> This causes TextFlow to layout to compute the runs.
>> Afterward, the bounds of the parents get updated.
>> This triggers a
On Tue, 24 Oct 2023 22:40:54 GMT, Andy Goryachev wrote:
> Corrected the test:
> ctrl-DOWN moves to the end of the current paragraph (linux) or beginning of
> the next paragraph (windows).
This pull request has now been integrated.
Changeset: 1672960d
Author:Andy Goryachev
URL:
http
On Wed, 21 Jun 2023 06:34:00 GMT, Karthik P K wrote:
> The text run selected in `PrismTextLayout::getHitInfo()` method for character
> index calculation was not correct when hitTest was invoked for Text node in a
> TextFlow with more than one Text child. Hence wrong character index value was
>
On Tue, 24 Oct 2023 22:40:54 GMT, Andy Goryachev wrote:
> Corrected the test:
> ctrl-DOWN moves to the end of the current paragraph (linux) or beginning of
> the next paragraph (windows).
Marked as reviewed by kcr (Lead).
Looks good.
-
PR Review: https://git.openjdk.org/jfx/pull/
I tested on Wayland and X.org, and they both show exactly the same behavior.
(Apologies if this mail somehow breaks the mailing list chain, the
digest mode makes it hard to reply to some mails)
On 10/25/2023 5:21 PM, openjfx-dev-requ...@openjdk.org wrote:
Question for the original poster of t
On Tue, 26 Sep 2023 08:43:47 GMT, Florian Kirmaier
wrote:
>> It's "a bit" complicated.
>> In some situations, getRuns get's called because listeners on bounds are set.
>> This causes TextFlow to layout to compute the runs.
>> Afterward, the bounds of the parents get updated.
>> This triggers a
On Tue, 24 Oct 2023 23:07:04 GMT, Thiago Milczarek Sayao
wrote:
>> The bug on the title happens because `gtk_widget_realize()` was called on
>> the constructor. It creates the internal underlying window `GdkWindow` and
>> `XWindow` messing the Gtk expected order. It's probably a Mutter change
On Sat, 21 Oct 2023 00:10:50 GMT, Martin Fox wrote:
>> When a window is visible the maximized, iconified, and fullscreen properties
>> are two-way streets; changes made in Java are sent on to the platform window
>> and changes in the platform window are sent back into Java.
>>
>> When a window
On Wed, 25 Oct 2023 15:19:13 GMT, Kevin Rushforth wrote:
> Can you provide an automated test for this fix?
I wonder.
1. this test ought to be headful, since the font metrics are involved
2. it might be better to develop a wider test that verifies that the caret (at
least in the case of a single
On Wed, 25 Oct 2023 10:12:01 GMT, Karthik P K wrote:
>> Because of a missing conditional check in the `updateTextPos()`, the
>> `textTranslateX` value was not getting updated when TextField size was
>> changed as a result of resizing window.
>>
>> Updated the CENTER and LEFT cases in the `upd
Question for the original poster of this thread: Are you running the
Wayland server or the X.org server?
-- Kevin
On 10/24/2023 5:53 PM, Thiago Milczarek Sayão wrote:
I suspect something changed on the window manager (mutter in the case
of default Ubuntu/gnome).
One problem is that focusing
On Wed, 25 Oct 2023 13:51:35 GMT, Johan Vos wrote:
> bump release version to 17.0.10
Marked as reviewed by jpereda (Reviewer).
-
PR Review: https://git.openjdk.org/jfx17u/pull/165#pullrequestreview-1697544862
On Wed, 25 Oct 2023 13:51:35 GMT, Johan Vos wrote:
> bump release version to 17.0.10
Marked as reviewed by kcr (Lead).
-
PR Review: https://git.openjdk.org/jfx17u/pull/165#pullrequestreview-1697434819
bump release version to 17.0.10
-
Commit messages:
- Bump version to 17.0.10
Changes: https://git.openjdk.org/jfx17u/pull/165/files
Webrev: https://webrevs.openjdk.org/?repo=jfx17u&pr=165&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8318823
Stats: 2 lines in 2 files chan
Thank you for the update!
It looks like it was missed to backport it to 17.0.9.
Any plans to backport it and make another release?
I think this fix is quite important - especially to make a good impression
about the stability of JavaFX.
On Wed, 4 Oct 2023 at 15:31, Kevin Rushforth
wrote:
> The
> Because of a missing conditional check in the `updateTextPos()`, the
> `textTranslateX` value was not getting updated when TextField size was
> changed as a result of resizing window.
>
> Updated the CENTER and LEFT cases in the `updateTextPos()` method to fix the
> issue.
>
> The fix can b
On Tue, 17 Oct 2023 12:15:14 GMT, Karthik P K wrote:
> Because of a missing conditional check in the `updateTextPos()`, the
> `textTranslateX` value was not getting updated when TextField size was
> changed as a result of resizing window.
>
> Updated the CENTER and LEFT cases in the `updateTe
On Sat, 21 Oct 2023 00:10:50 GMT, Martin Fox wrote:
>> When a window is visible the maximized, iconified, and fullscreen properties
>> are two-way streets; changes made in Java are sent on to the platform window
>> and changes in the platform window are sent back into Java.
>>
>> When a window
26 matches
Mail list logo
