On Tue, 18 Jul 2023 06:05:06 GMT, Prasanta Sadhukhan
wrote:
> Due to transient datatype of scenePeer, it can become null which can result
> in NPE in scenarios where scene is continuously been reset and set, which
> warrants a null check, as is done in other places for the same variable.
On Thu, 26 Oct 2023 18:16:26 GMT, Andy Goryachev wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Optimization
>
> modules/javafx.swing/src/main/java/javafx/embed/swing/JFXPanel.java line 817:
>
>> 815:
> FX Nodes embedded in a Swing JFXPanel does not track the component
> orientation and FX nodes remain unaffected when component orientation changes.
> Fix made sure JavaFX scene embedded in a JFXPanel should inherit the value
> from the JFXPanel.
Prasanta Sadhukhan has updated the pull request
> FX Nodes embedded in a Swing JFXPanel does not track the component
> orientation and FX nodes remain unaffected when component orientation changes.
> Fix made sure JavaFX scene embedded in a JFXPanel should inherit the value
> from the JFXPanel.
Prasanta Sadhukhan has updated the pull request
> **Issue:**
> Using pseudo classes in programmatic query using Node.lookupAll() or
> Node.lookup() gives unexpected results.
>
> **Cause:**
> There is no check for checking the psuedo states matching in the applies()
> method of SimpleSelector.java. So checking for "applies()" alone is not
>
> **Issue:**
> Using pseudo classes in programmatic query using Node.lookupAll() or
> Node.lookup() gives unexpected results.
>
> **Cause:**
> There is no check for checking the psuedo states matching in the applies()
> method of SimpleSelector.java. So checking for "applies()" alone is not
>
On Tue, 29 Aug 2023 10:10:54 GMT, Alexander Zuev wrote:
> Create implementation for Slider and Stepper accessibility protocols.
> Fix mapping.
> Fix performAction parameter type in declaration.
This pull request has been closed without being integrated.
-
PR:
On Mon, 23 Oct 2023 23:11:53 GMT, Sai Pradeep Dandem wrote:
>> **Issue:**
>> Using pseudo classes in programmatic query using Node.lookupAll() or
>> Node.lookup() gives unexpected results.
>>
>> **Cause:**
>> There is no check for checking the psuedo states matching in the applies()
>> method
On Thu, 26 Oct 2023 16:27:03 GMT, Prasanta Sadhukhan
wrote:
>> FX Nodes embedded in a Swing JFXPanel does not track the component
>> orientation and FX nodes remain unaffected when component orientation
>> changes.
>> Fix made sure JavaFX scene embedded in a JFXPanel should inherit the value
On Thu, 26 Oct 2023 16:27:03 GMT, Prasanta Sadhukhan
wrote:
>> FX Nodes embedded in a Swing JFXPanel does not track the component
>> orientation and FX nodes remain unaffected when component orientation
>> changes.
>> Fix made sure JavaFX scene embedded in a JFXPanel should inherit the value
On Thu, 26 Oct 2023 15:31:02 GMT, Andy Goryachev wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Optimization
>
> modules/javafx.swing/src/main/java/javafx/embed/swing/JFXPanel.java line 817:
>
>> 815:
> FX Nodes embedded in a Swing JFXPanel does not track the component
> orientation and FX nodes remain unaffected when component orientation changes.
> Fix made sure JavaFX scene embedded in a JFXPanel should inherit the value
> from the JFXPanel.
Prasanta Sadhukhan has updated the pull request
On Thu, 19 Oct 2023 15:04:59 GMT, Andy Goryachev wrote:
>> I must say I'm again baffled at how this is implemented.
>>
>> Red flag one: it uses a `LinkedList` which are known to be rarely the right
>> choice, and I doubt this case is any different.
>>
>> Red flag two: a `List` is
On Thu, 26 Oct 2023 09:34:17 GMT, Prasanta Sadhukhan
wrote:
> FX Nodes embedded in a Swing JFXPanel does not track the component
> orientation and FX nodes remain unaffected when component orientation changes.
> Fix made sure JavaFX scene embedded in a JFXPanel should inherit the value
> from
On Sat, 21 Oct 2023 00:10:50 GMT, Martin Fox wrote:
>> When a window is visible the maximized, iconified, and fullscreen properties
>> are two-way streets; changes made in Java are sent on to the platform window
>> and changes in the platform window are sent back into Java.
>>
>> When a
FX Nodes embedded in a Swing JFXPanel does not track the component orientation
and FX nodes remain unaffected when component orientation changes.
Fix made sure JavaFX scene embedded in a JFXPanel should inherit the value from
the JFXPanel.
-
Commit messages:
- 8317836: FX nodes
The normal procedure I think is also to first provide a JEP for review,
before starting on the implementation...
Given the doubts raised, feedback given and potential alternatives
proposed, I don't see why you are still moving forward with your own
proposal. The critiques I've given have been
On Sat, 21 Oct 2023 00:10:50 GMT, Martin Fox wrote:
>> When a window is visible the maximized, iconified, and fullscreen properties
>> are two-way streets; changes made in Java are sent on to the platform window
>> and changes in the platform window are sent back into Java.
>>
>> When a
Hi Michael,
Yeah, I also think it is an oversight, or may even be qualified as a
bug. Now you have to be really careful to start event handlers with a
`if (!event.isConsumed())` check, just in case there is another handler
that is before you at the same level that may have consumed the
On Thu, 26 Oct 2023 00:31:52 GMT, Michael Strauß wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Migrate old tests to JUnit 5
>
> modules/javafx.graphics/src/main/java/javafx/scene/layout/BorderPane.java
> line
On Tue, 17 Oct 2023 12:15:14 GMT, Karthik P K wrote:
> Because of a missing conditional check in the `updateTextPos()`, the
> `textTranslateX` value was not getting updated when TextField size was
> changed as a result of resizing window.
>
> Updated the CENTER and LEFT cases in the
On Wed, 25 Oct 2023 15:28:14 GMT, Andy Goryachev wrote:
> Can you provide an automated test for this fix?
I agree on the points shared by @andy-goryachev-oracle on this.
I also tried to write both unit test and system test but couldn't succeed
because the issue could not be reproduced in the
22 matches
Mail list logo
